From: Dave Martin <Dave.Martin@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Julien Grall <julien@xen.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Zhang Lei <zhang.lei@jp.fujitsu.com>,
Julien Grall <julien.grall@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Daniel Kiss <Daniel.Kiss@arm.com>
Subject: Re: [PATCH v4 3/8] arm64/fpsimdmacros: Allow the macro "for" to be used in more cases
Date: Tue, 22 Sep 2020 15:07:27 +0100 [thread overview]
Message-ID: <20200922140727.GE6642@arm.com> (raw)
In-Reply-To: <20200922135956.GU4792@sirena.org.uk>
On Tue, Sep 22, 2020 at 02:59:56PM +0100, Mark Brown wrote:
> On Tue, Sep 22, 2020 at 02:51:41PM +0100, Dave Martin wrote:
> > On Mon, Sep 21, 2020 at 07:09:10PM +0100, Mark Brown wrote:
>
> > > Yes, this was my understanding of what this was doing when I looked
> > > through things when taking over the code - if we're going to use a
> > > different macro mode to the rest of the code then it seems sensible to
> > > make sure we don't try to build any other code with that macro mode
> > > otherwise it'll doubtless blow up in our faces at some point.
>
> > I think that it's unlikely ever to be used except for this kind of
> > purpose, since it doesn't offer much over normal macro mode.
>
> > altmacro mode is off by default, and can't be turned on via command-line
> > options IIRC, so it seems unlikely to be turned on everywhere by
> > accident.
>
> Right, the issue is that if altmacro mode expansions pull in something
> that misbehaves when interpreted using altmacro mode that'd cause
> trouble so usages like this should take care to ensure that only code
> specifically writen for altmacro mode gets interpreted using it.
Agreed -- which is what this code is actually doing IIUC.
Cheers
---Dave
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-22 14:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 18:11 [PATCH v4 0/8] arm64/sve: First steps towards optimizing syscalls Mark Brown
2020-08-28 18:11 ` [PATCH v4 1/8] arm64/fpsimd: Update documentation of do_sve_acc Mark Brown
2020-08-28 18:11 ` [PATCH v4 2/8] arm64/signal: Update the comment in preserve_sve_context Mark Brown
2020-08-28 18:11 ` [PATCH v4 3/8] arm64/fpsimdmacros: Allow the macro "for" to be used in more cases Mark Brown
2020-09-21 12:38 ` Will Deacon
2020-09-21 16:53 ` Dave Martin
2020-09-21 18:09 ` Mark Brown
2020-09-22 13:51 ` Dave Martin
2020-09-22 13:59 ` Mark Brown
2020-09-22 14:07 ` Dave Martin [this message]
2020-08-28 18:11 ` [PATCH v4 4/8] arm64/fpsimdmacros: Introduce a macro to update ZCR_EL1.LEN Mark Brown
2020-08-28 18:11 ` [PATCH v4 5/8] arm64/sve: Implement a helper to flush SVE registers Mark Brown
2020-08-28 18:11 ` [PATCH v4 6/8] arm64/sve: Implement a helper to load SVE registers from FPSIMD state Mark Brown
2020-08-28 18:11 ` [PATCH v4 7/8] arm64/sve: Don't disable SVE on syscalls return Mark Brown
2020-09-21 12:36 ` Will Deacon
2020-09-21 18:03 ` Mark Brown
2020-09-22 14:03 ` Dave Martin
2020-09-22 16:04 ` Mark Brown
2020-08-28 18:11 ` [PATCH v4 8/8] arm64/sve: Rework SVE trap access to use TIF_SVE_NEEDS_FLUSH Mark Brown
2020-09-21 12:42 ` [PATCH v4 0/8] arm64/sve: First steps towards optimizing syscalls Will Deacon
2020-09-21 12:56 ` Mark Brown
2020-09-21 13:08 ` Will Deacon
2020-09-21 18:17 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922140727.GE6642@arm.com \
--to=dave.martin@arm.com \
--cc=Daniel.Kiss@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=julien.grall@arm.com \
--cc=julien@xen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=will@kernel.org \
--cc=zhang.lei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).