From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 509A9C4363D for ; Tue, 22 Sep 2020 18:09:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 036D22376F for ; Tue, 22 Sep 2020 18:09:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BfX81/7J"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="CRd63rpN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 036D22376F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+zeqbvpwFG2x75QlljpANkePyxXJsVa7sszP45CzEQk=; b=BfX81/7JFzsN7ceTo5iiRKlIP 22s2br6T0a/MY9WncaZLHP5DGjI4uY676fKWnMq9lkx7Mjh4u572ivwz7FdiLYa2uyph9bhMQvYpH C7CcLeVvp6uSzYmYvzOryPgQ6vX58WPIzcV3wY7SfRIP/5g7vZ0lZcYM1ZS6UPnjX2hM6ueGLJ48a 7l1wvSZBFXqTWausz5g8KCS6jQ61ncMkd+ca8ih3nQmPfg3acWhx9X1sVbuZqgORfn45634QdYWq7 4SnkgHG0un7wkUOMcfE8ypJGoTEX6zBopclrJUgPS4ecc967qefoyOAEF4doH8+LLGcEQk3NLfm/B sLE8ouGZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKmhk-0006Jv-7Z; Tue, 22 Sep 2020 18:07:52 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKmhg-0006JE-VS for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 18:07:49 +0000 Received: by mail-wr1-x443.google.com with SMTP id c18so18110382wrm.9 for ; Tue, 22 Sep 2020 11:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6y72uZ7YdWD1XXfQ+XTc3NqqPVXw5bQyVkymr14fQGQ=; b=CRd63rpNjyrzDcmAXaGmKY+nIczGjjMJGpL77E2ju9oloTgn2/h43kyf7RWLd6TSb1 drxGmpeR76PV5D4kIrtMak0BTXiG5QqFMzjzRfQlbfXHW05r/mynwAVi8WOU7EzJz668 1OQ4vm0VTMoo+qE1KCxXK/ZC2MaA+0D0xpWJECvrWvULe4ay+hp8jpleCDlSQl6ynXDm hdn5fKFjis/9QrlFTJZ65bXGTQnbSyH4tgejSXC753c+nYjHnfeoxaGtt5vIr7zmYhnN eQl+KORPu/uRAmRcXz71wLELsQ70yI9fMXN5m2dnfT3ZLENatNSfDyQyWqxnCJ+hp3Lj Jh9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6y72uZ7YdWD1XXfQ+XTc3NqqPVXw5bQyVkymr14fQGQ=; b=AOJyEaTTAziuzP4hn68YAut4jSn+upCPJGFmqmKuGC8Jce24RrM+1KBJZ5pOJ1nCFL cU+TaIZlWGqBlGLkWMcC/ogekbHJQRAIktm44Z9JEA623U2PiW/P7fzIiT2jHd27OJQT x68s9v+QHV5EUWUOTQLO7/4oQXb+ZY+3tZrpHDqzZfIzwkYm/x6p2nAglSTCYnVm4HkG aYN5I6Yfj9NQ6v028RxMQXQwkAYeRzKbbeOTZuqZnOQqY2Le4PndVULuJwyZHhfrdzpc 2RaYExciXMuBoQU01mJuErOd1oOEt15p48Hih62n+GaYa8my8in8XMrWU4QcaR70XH24 S7eg== X-Gm-Message-State: AOAM532XS4iUu576zY6FCQazkAXPUULdNJIviiJK46kKj56wQBd9yByE eU28KlQCPMNpeI96DrR8Jm1Mbg== X-Google-Smtp-Source: ABdhPJwZPTozi74qAG3/aClHpnw3RnRnKS0i65Quxl7eR1kjuVfhlagjStYPlzzSrntMUCfignnPpQ== X-Received: by 2002:a5d:46cf:: with SMTP id g15mr6822937wrs.107.1600798067242; Tue, 22 Sep 2020 11:07:47 -0700 (PDT) Received: from google.com ([2a01:4b00:8523:2d03:55c2:2cdf:ff31:96a3]) by smtp.gmail.com with ESMTPSA id e1sm28558820wrp.49.2020.09.22.11.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 11:07:46 -0700 (PDT) Date: Tue, 22 Sep 2020 19:07:45 +0100 From: David Brazdil To: Will Deacon Subject: Re: [PATCH v3 07/11] kvm: arm64: Duplicate arm64_ssbd_callback_required for nVHE hyp Message-ID: <20200922180745.m6bjgjzz6cwercgf@google.com> References: <20200916173439.32265-1-dbrazdil@google.com> <20200916173439.32265-8-dbrazdil@google.com> <20200918115911.GB31096@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200918115911.GB31096@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_140749_071713_E63AB2D2 X-CRM114-Status: GOOD ( 16.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , linux-arm-kernel@lists.infradead.org, Marc Zyngier , Tejun Heo , Dennis Zhou , Christoph Lameter , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > u64 *ptr; > > > > - ptr = per_cpu_ptr(&arm64_ssbd_callback_required, cpu); > > + ptr = per_cpu_ptr_nvhe(arm64_ssbd_callback_required, cpu); > > err = create_hyp_mappings(ptr, ptr + 1, PAGE_HYP); > > if (err) > > return err; > > + > > + /* Copy value from kernel to hyp. */ > > + *ptr = per_cpu(arm64_ssbd_callback_required, cpu); > > Hmm. Is this correct for late arriving CPUs, where we don't know whether > a callback is required at the point we do the copy? > > That sounds fiddly to resolve, but this _might_ all be moot because I'm > about to post a series that allows us to remove the hyp mapping of this > variable entirely. So leave this for now, but maybe stick a comment in > that it doesn't work for late cpus. Ah, good point. I'll move the value copy at the end of cpu_init_hyp_mode(). It must be known at that point. And if your series gets rid of this completely, even better. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel