From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF8AC2D0E2 for ; Tue, 22 Sep 2020 19:55:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39FA920888 for ; Tue, 22 Sep 2020 19:55:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rwHHxiiT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39FA920888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mBSdhosX/zghQ13a75QuwxPMgBnnh+oh4OhiKXYTyV0=; b=rwHHxiiTn89qF9ZGRF2Z/yi4+ +UgmzejtXBoJTGK8Vlh14Z1ngk65gWoZ832eUJQeTUhIDbJf2tU5ASD2W/XNu734tLygrBoYCsYlt zp854GFBKWAOoHlHuDIUL3Dhg8g7XKt6vbdLFdHbWxQL6tJGkRe8XkA+9v8hHYvML1/UK8OxTHo37 6ToX8Bqkg8AFwRESbimS1ZA04RXmXXye9eV1+jYzcOiteiI7Q+xRxVcJ+gdiQ7EgconLpJ/9kGYel OZadfpEg2nzJJZxNNabLzgS2hpfG2/JKBDRlW0WPnzB3+8GixiBLQilBNIOsWufeKGtFPJRQz3+GR 4h/at7yvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKoMi-0007Td-LR; Tue, 22 Sep 2020 19:54:16 +0000 Received: from mail-io1-f67.google.com ([209.85.166.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKoMf-0007Sz-Cl for linux-arm-kernel@lists.infradead.org; Tue, 22 Sep 2020 19:54:14 +0000 Received: by mail-io1-f67.google.com with SMTP id y74so20995035iof.12 for ; Tue, 22 Sep 2020 12:54:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+qF2EAj+xZ27M9bstX87bUprxWqOcd9qGhCKaOFiGNc=; b=l92V9QiXqawiCk2OFZFW5BE7ZOBij3JyTrtODEasQUZ3tSww4/5CySO2Ko5gdPI/e9 MzSiXsPwN7y6kp8jtr+U5NuOsVecHcWiqiGMIpvcUPjgAk+dy/HaEj8kUuvLej/+GsNl wRSftKng5ZjWIXMFAHCvPaEjCk5asUJdYsuz91nPwR4bZIfHqmYb5Yf8TwqhHtHVou8z tp9ZResrXr1GFnDt6SiSUz0cIo3jHMFIX0KJIEhm6BJZVyDcn4CMAZo9TGFv698dMPiI uIUT+v8xJMtAYDqkc7zU32RMi2CRPV8Oht1UZgqIsCprtKEBdZTH/iGV8Tn312iO3Fop guWg== X-Gm-Message-State: AOAM5324KejLcxwgJWHJHAo0C9qR8DRgaxrLNjTVRKOResFJ15Ta7oiF Ot+SewBrOrKNUTEe+Bdaww== X-Google-Smtp-Source: ABdhPJzijmPheoOp8k8M0D8ZYTknwbf0gqU6P2fI0sRjA5TFSpfxcEdmfuQ37IRLZxfB19R2VHB5Zg== X-Received: by 2002:a05:6602:2e0e:: with SMTP id o14mr4889500iow.111.1600804452622; Tue, 22 Sep 2020 12:54:12 -0700 (PDT) Received: from xps15 ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id e9sm9498571ilr.20.2020.09.22.12.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 12:54:11 -0700 (PDT) Received: (nullmailer pid 3131804 invoked by uid 1000); Tue, 22 Sep 2020 19:54:10 -0000 Date: Tue, 22 Sep 2020 13:54:10 -0600 From: Rob Herring To: Manish Narani Subject: Re: [PATCH v2 1/2] dt-bindings: usb: dwc3-xilinx: Add documentation for Versal DWC3 Controller Message-ID: <20200922195410.GA3122345@bogus> References: <1599678185-119412-1-git-send-email-manish.narani@xilinx.com> <1599678185-119412-2-git-send-email-manish.narani@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1599678185-119412-2-git-send-email-manish.narani@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200922_155413_525161_5C260BCB X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, git@xilinx.com, p.zabel@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 10, 2020 at 12:33:04AM +0530, Manish Narani wrote: > Add documentation for Versal DWC3 controller. Add required property > 'reg' for the same. Also add optional properties for snps,dwc3. > > Signed-off-by: Manish Narani > --- > .../devicetree/bindings/usb/dwc3-xilinx.txt | 20 +++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt b/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt > index 4aae5b2cef56..219b5780dbee 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.txt > @@ -1,7 +1,8 @@ > Xilinx SuperSpeed DWC3 USB SoC controller > > Required properties: > -- compatible: Should contain "xlnx,zynqmp-dwc3" > +- compatible: May contain "xlnx,zynqmp-dwc3" or "xlnx,versal-dwc3" > +- reg: Base address and length of the register control block > - clocks: A list of phandles for the clocks listed in clock-names > - clock-names: Should contain the following: > "bus_clk" Master/Core clock, have to be >= 125 MHz for SS > @@ -13,12 +14,24 @@ Required child node: > A child node must exist to represent the core DWC3 IP block. The name of > the node is not important. The content of the node is defined in dwc3.txt. > > +Optional properties for snps,dwc3: > +- dma-coherent: Enable this flag if CCI is enabled in design. Adding this > + flag configures Global SoC bus Configuration Register and > + Xilinx USB 3.0 IP - USB coherency register to enable CCI. > +- snps,enable-hibernation: Add this flag to enable hibernation support for > + peripheral mode. This belongs in the DWC3 binding. It also implies that hibernation is not supported by any other DWC3 based platform. Can't this be implied by the compatible string (in the parent)? > +- interrupt-names: Should contain the following: > + "dwc_usb3" USB gadget mode interrupts > + "otg" USB OTG mode interrupts > + "hiber" USB hibernation interrupts > + > Example device node: > > usb@0 { > #address-cells = <0x2>; > #size-cells = <0x1>; > compatible = "xlnx,zynqmp-dwc3"; > + reg = <0x0 0xff9d0000 0x0 0x100>; > clock-names = "bus_clk" "ref_clk"; > clocks = <&clk125>, <&clk125>; > ranges; > @@ -26,7 +39,10 @@ Example device node: > dwc3@fe200000 { > compatible = "snps,dwc3"; > reg = <0x0 0xfe200000 0x40000>; > - interrupts = <0x0 0x41 0x4>; > + interrupt-names = "dwc_usb3", "otg", "hiber"; > + interrupts = <0 65 4>, <0 69 4>, <0 75 4>; > dr_mode = "host"; > + dma-coherent; > + snps,enable-hibernation; > }; > }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel