From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AC02C4363D for ; Wed, 23 Sep 2020 06:55:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF85B20658 for ; Wed, 23 Sep 2020 06:55:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S6TZA4d3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF85B20658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kF6pAbKdU0LRqgd243j52UUX+G+bs1vSR20eFPQNYzc=; b=S6TZA4d32eFF4Dx846oyh0FhJ BiKpF4q5jFOhNxCxvWbYg2LDk0rlK6PyjQwFcSEtxNkUjLJ1bw0r46H3xDONFFawBIbpCGm+nqWg8 butVLUG8sYGak6cICAZNsztncicdFV0vK7eeKvAXorabBoSMAiwg66YWrzo+CWVyOA4k4L+sXxFO0 omF9umMoOylbZHLhZ8PxWBVEeNuS8E93zgtAzGFkKDzk8gC5SfCme7NtWsQ8M1WuK4mcJi/NVB8vO eULHLAo0hG4/r1HWg8/dDG5XpMNESM6AknZuAqIhFEhl5RDa41JW9DPbo61GKvJPrewlczdqGKNId 1FD5sTqVA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKyfc-0002Os-Ra; Wed, 23 Sep 2020 06:54:28 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKyfa-0002OL-Qn for linux-arm-kernel@lists.infradead.org; Wed, 23 Sep 2020 06:54:27 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id D420080A0; Wed, 23 Sep 2020 06:54:26 +0000 (UTC) Date: Wed, 23 Sep 2020 09:55:20 +0300 From: Tony Lindgren To: Drew Fustini Subject: Re: [PATCH v2] pinctrl: single: fix debug output when #pinctrl-cells = 2 Message-ID: <20200923065520.GP7101@atomide.com> References: <20200913230306.2061645-1-drew@beagleboard.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200913230306.2061645-1-drew@beagleboard.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_025426_934741_7FA65BE5 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Trent Piepho , Jason Kridner , Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Rob Herring , Haojian Zhuang , bcousson@baylibre.com, linux-omap@vger.kernel.org, Robert Nelson , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Drew Fustini [200913 23:04]: > The debug output in pcs_parse_one_pinctrl_entry() needs to be updated > to print the correct pinctrl register value when #pinctrl-cells is 2. > > Fixes: a13395418888 ("pinctrl: single: parse #pinctrl-cells = 2") > Reported-by: Trent Piepho > Link: https://lore.kernel.org/linux-omap/3139716.CMS8C0sQ7x@zen.local/ > Signed-off-by: Drew Fustini > --- > v2 change: > this is a fix to my prior email where I referred to #pinctrl-cells = 3 > which is incorrect. pinctrl_spec.args_count is 3 but #pinctrl-cells = 2 > https://lore.kernel.org/linux-omap/20200913224746.2048603-1-drew@beagleboard.org/ Acked-by: Tony Lindgren > drivers/pinctrl/pinctrl-single.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c > index 5cbf0e55087c..f3cd7e296712 100644 > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -1033,7 +1033,7 @@ static int pcs_parse_one_pinctrl_entry(struct pcs_device *pcs, > } > > dev_dbg(pcs->dev, "%pOFn index: 0x%x value: 0x%x\n", > - pinctrl_spec.np, offset, pinctrl_spec.args[1]); > + pinctrl_spec.np, offset, vals[found].val); > > pin = pcs_get_pin_by_offset(pcs, offset); > if (pin < 0) { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel