From: Catalin Marinas <catalin.marinas@arm.com>
To: Gavin Shan <gshan@redhat.com>
Cc: mark.rutland@arm.com, anshuman.khandual@arm.com,
robin.murphy@arm.com, linux-kernel@vger.kernel.org,
shan.gavin@gmail.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/2] arm64/mm: Enable color zero pages
Date: Wed, 23 Sep 2020 09:43:17 +0100 [thread overview]
Message-ID: <20200923084317.GA13434@gaia> (raw)
In-Reply-To: <20200923053721.28873-1-gshan@redhat.com>
Hi Gavin,
On Wed, Sep 23, 2020 at 03:37:19PM +1000, Gavin Shan wrote:
> The feature of color zero pages isn't enabled on arm64, meaning all
> read-only (anonymous) VM areas are backed up by same zero page. It
> leads pressure to L1 (data) cache on reading data from them. This
> tries to enable color zero pages.
>
> PATCH[1/2] decouples the zero PGD table from zero page
> PATCH[2/2] allocates the needed zero pages according to L1 cache size
To save you (and potential reviewers) some time, please include in the
cover letter details of a realistic workload/benchmark that is improved
by this patchset, backed by numbers. Just because it's doable and the
patches aren't too complex is not a good enough reason for merging.
Thanks.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-23 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 5:37 [PATCH v2 0/2] arm64/mm: Enable color zero pages Gavin Shan
2020-09-23 5:37 ` [PATCH v2 1/2] arm64/mm: Introduce zero PGD table Gavin Shan
2020-09-23 5:37 ` [PATCH v2 2/2] arm64/mm: Enable color zero pages Gavin Shan
2020-09-23 8:43 ` Catalin Marinas [this message]
2020-09-23 22:47 ` [PATCH v2 0/2] " Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923084317.GA13434@gaia \
--to=catalin.marinas@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox