From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33FFEC2D0A8 for ; Wed, 23 Sep 2020 20:53:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8E5C214F1 for ; Wed, 23 Sep 2020 20:53:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OsIXkcg/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RM+T9ohJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8E5C214F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k2s7YPwYyX+iNDO/tCrUuQcY/BuD8NhTbkKz0UvlwJY=; b=OsIXkcg/eZFJe360P/M5O0WYf u0HJEA4cwdMSV9hLpJaf9wdDkMLnp9wf6d0AMtEeL5EUlwtjafXbS8zGN6YWt/VSxUhTcdXBMdKBi fq5z0jVxeJvsyzuk9q/CPMSy8llEfq48bC3g4lNVxeCoZizPGDGRTOXD6vRJDnlmd3sHqAM/CHLPj Pn7HDgDh5kU0gSFrhsexRcvEZsI5qIg3PZvraigQoKI0VbpRNTBZOIroSthVtjdKxwEaMrubbZ+Ce w7JoXFwc39ZyqGnZyNGE94iq84nzbpI4NtRWRp09npmLsPpY1zGkGDrVAtRo86OzdBF56QYJOHkYh wVTTiJZRQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLBkg-0000Un-I1; Wed, 23 Sep 2020 20:52:34 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLBke-0000TV-94 for linux-arm-kernel@lists.infradead.org; Wed, 23 Sep 2020 20:52:32 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 331EC214F1; Wed, 23 Sep 2020 20:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600894350; bh=Q06p8Et9US/NfgUeEtjZnh3mkPhqpZz0306QBf0WJPs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RM+T9ohJJqm2UxXudwE51CP564QadUXTGiUXONJqMn3Hc94O2xnXlDbroE6uOaHaz YqrzHaRhJEkPu1qY/5Wcn3TubfoxstyN/Btz2zdBN/K6SoDLKvtCV7jcuX5Fq+pnfB p/qsWoX5SraJZXlEC5GLvkb3vuOOYAa5VbgpCCe8= Date: Wed, 23 Sep 2020 21:52:25 +0100 From: Jonathan Cameron To: Wang ShaoBo Subject: Re: [PATCH -next] iio: adc: at91-sama5d2_adc: Use devm_platform_get_and_ioremap_resource() Message-ID: <20200923215158.1d3d73fc@archlinux> In-Reply-To: <20200918082837.32610-1-bobo.shaobowang@huawei.com> References: <20200918082837.32610-1-bobo.shaobowang@huawei.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_165232_409104_317919F3 X-CRM114-Status: GOOD ( 19.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cj.chengjian@huawei.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, huawei.libin@huawei.com, Jonathan.Cameron@huawei.com, eugen.hristev@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 18 Sep 2020 16:28:37 +0800 Wang ShaoBo wrote: > Make use of devm_platform_get_and_ioremap_resource() provided by > driver core platform instead of duplicated analogue. > > Signed-off-by: Wang ShaoBo Hi, Thanks. As far as I can see this boilerplate removal with no side effects, so applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it. Thanks, Jonathan > --- > drivers/iio/adc/at91-sama5d2_adc.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index de9583d6cddd..ad7d9819f83c 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -1764,17 +1764,13 @@ static int at91_adc_probe(struct platform_device *pdev) > mutex_init(&st->lock); > INIT_WORK(&st->touch_st.workq, at91_adc_workq_handler); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) > - return -EINVAL; > + st->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); > + if (IS_ERR(st->base)) > + return PTR_ERR(st->base); > > /* if we plan to use DMA, we need the physical address of the regs */ > st->dma_st.phys_addr = res->start; > > - st->base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(st->base)) > - return PTR_ERR(st->base); > - > st->irq = platform_get_irq(pdev, 0); > if (st->irq <= 0) { > if (!st->irq) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel