From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE62C2D0A8 for ; Wed, 23 Sep 2020 20:55:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63B6C2068D for ; Wed, 23 Sep 2020 20:55:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MjeGpeuS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bpKhHnhj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63B6C2068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5sr+ErKzs5rOvAsMtcwOGnBzNhSwpGNtPq8dvXG+B3g=; b=MjeGpeuSi4sWWM1b1OE1YNl4i XNmIZo3egCTpClVIGWRh6UrAt1Ob14OXeeHs4qKixBHRznpxMDQte4OtJdfnF2Lnp7WoyDjtB7D8S RB6z4f07V5Y3VZYy6RZhaKKWzN9N4pSVRPPgPBZkm+cxDvHnGkCXqTl69jx/wljweb3kX1wlrxBcq DRQGiWebhkr07Z375vE4+WoWGDuMf490ZC08M0yAH3OD8lWGQFW23evZen2ataFCqH+Eo2zUlhQTC IXHbezr2zU4IdyHBE92iAunDPedajMPzTQ+5eyyg2nDxSFb8Ut6chE6dFB3RLaSNvMeIRMaIqfvog +W8s3s6NA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLBmP-0000xc-C3; Wed, 23 Sep 2020 20:54:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLBmL-0000w3-Mi for linux-arm-kernel@lists.infradead.org; Wed, 23 Sep 2020 20:54:19 +0000 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FEFE214F1; Wed, 23 Sep 2020 20:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600894456; bh=4W8tkVEnVbxByODEUPomYSterl2xwqTlOxfLZTbwLt0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bpKhHnhjyQreXsGYfaJ5ArX8UDxNgxTCpzvBIGlT6fcSULxC+13epxTa19yMiz7dk KoTinHrYH2aztpNLmskjxsSYucKSLpvVRmGbw9HXCOhoyq35Pr1kgGa2eMPtIzpIgn LpoX4sLVR15oFiAlxSdXYzEQ8OVgc7xarT8UHqD8= Date: Wed, 23 Sep 2020 21:54:12 +0100 From: Jonathan Cameron To: Wang ShaoBo Subject: Re: [PATCH -next] iio: adc: stm32-dfsdm: Use devm_platform_get_and_ioremap_resource() Message-ID: <20200923215357.26f8959d@archlinux> In-Reply-To: <20200918083142.32816-1-bobo.shaobowang@huawei.com> References: <20200918083142.32816-1-bobo.shaobowang@huawei.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200923_165417_822064_2C635636 X-CRM114-Status: GOOD ( 20.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cj.chengjian@huawei.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, huawei.libin@huawei.com, Jonathan.Cameron@huawei.com, fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 18 Sep 2020 16:31:42 +0800 Wang ShaoBo wrote: > Make use of devm_platform_get_and_ioremap_resource() provided by > driver core platform instead of duplicated analogue, dev_err() is > removed because it has been done in devm_ioremap_resource(). > > Signed-off-by: Wang ShaoBo Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to see if they can find any problems. Thanks, Jonathan > --- > drivers/iio/adc/stm32-dfsdm-core.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/adc/stm32-dfsdm-core.c b/drivers/iio/adc/stm32-dfsdm-core.c > index 0b8bea88b011..42a7377704a4 100644 > --- a/drivers/iio/adc/stm32-dfsdm-core.c > +++ b/drivers/iio/adc/stm32-dfsdm-core.c > @@ -226,16 +226,13 @@ static int stm32_dfsdm_parse_of(struct platform_device *pdev, > if (!node) > return -EINVAL; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "Failed to get memory resource\n"); > - return -ENODEV; > - } > - priv->dfsdm.phys_base = res->start; > - priv->dfsdm.base = devm_ioremap_resource(&pdev->dev, res); > + priv->dfsdm.base = devm_platform_get_and_ioremap_resource(pdev, 0, > + &res); > if (IS_ERR(priv->dfsdm.base)) > return PTR_ERR(priv->dfsdm.base); > > + priv->dfsdm.phys_base = res->start; > + > /* > * "dfsdm" clock is mandatory for DFSDM peripheral clocking. > * "dfsdm" or "audio" clocks can be used as source clock for _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel