From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35807C4363D for ; Thu, 24 Sep 2020 13:36:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC03F20674 for ; Thu, 24 Sep 2020 13:36:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qVuHouiU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="wWMf+nQe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC03F20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VB4mD6TTZqURPR2u+A9ZC757VD3w+APCMg/PnkgtoXs=; b=qVuHouiU3/8lVKsW//7NKs6lh lWNwSk5tKoaVbv0APcRJadejQNklbNN3GE2kuvLer0hZzvfqnmnH5dyCFT2Boqyhp88pAziwIQuuc oTfGEXVCxiBjD8d/4jwbiJJnISwYaUFe7FX2v2ihbWhdJKn6/mXUKJ2Hc+8u+8urAAN+pzLpgvGDw DiRjAPn2gF1BZjfxIgmSzoI2EM/wCAo0C9q9DgN7zA2oTCpdRCqRMCLv0lAp6u6J7oyMFZqnpcWu+ hA2Cg4VpDd981cosIXDgmPxZJb8gPcCwIOUp+PYnoCwWqWeOCeLoqjVZovHSP/3IaWmxAxRhJWK8p x84Zbp5yQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLROi-0004ih-RP; Thu, 24 Sep 2020 13:34:56 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLROe-0004fK-Ta for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2020 13:34:53 +0000 Received: by mail-wr1-x443.google.com with SMTP id x14so3803220wrl.12 for ; Thu, 24 Sep 2020 06:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=AHmQxIHTPufi+UR2RfGLNgHO/eGPtc+JmSaoagltYVc=; b=wWMf+nQe5B/34hqIN8sqpervlaXL5/2jAPnWv88YCj6AJTvL9Viemp26b9S/QzgjJT Kvn0I9+JfmDm7IvImZnITMdUtGXfvGsZv2gBPwDhzaXG2bUGvPWjyCQwN0sYWdJu57IX ViFp2j1SODpDHoK2ZMPTh6/j229FaCU9pHDQBdjdytT+Eo1dFyqwKKl0WXdelRTT6f1J x5Hs8COVRdDhy1UQwpQ+0itqy9Cj6GBMRZHLHWSJWuyoAEToYU5lm4OVDCZb+HPvJ+n1 1A7qBk0UVwrsz9a3Ci56pRhlnuCLuVtG0gNbu4se+m2dhLTI/GO4IC/PAkIRIOIR6WxK QQ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AHmQxIHTPufi+UR2RfGLNgHO/eGPtc+JmSaoagltYVc=; b=eJ6Q8DmSicFZqLQC7BpKX2O3hXPSiiRiCIWoHEzoBgvMP06vdIlhELbBPuXULTrlMr V4fLo6tA2z2oAHj8/4HeqmZ4GpxXF9wo1ajHGYsjVTYwyMUT8kjQQnsluJ6KAfWbRMu5 SJX0ZrcYD7068nYF4eD9GRsefO7S8slakFoAcCN1gYuZAv0gEegzeq38Rkx7vDZXbrK5 p7fWbmi9Bp4X92A4T/c9O6bd8NY80EwMriWwYJ+haxyQTMN9xeHtWTyDKyFNShIoah6F bnn3mS6scfJyB+2gO753PbqLV9IRZpuSsE6+u9yMTWWhzGuKWdXLZvpGUOik/RZ5oaQb qDFw== X-Gm-Message-State: AOAM531kktj8eCNUEod2lvLTbTt+hbhbM7i4Yt0p0cUhO5eQEsbOhufM wX+on/Y+m9NulPEVZonJx5eJPw== X-Google-Smtp-Source: ABdhPJzz1iuxB8yMgk8VfJVBob6+7W+AlkLoqZKC4tAXB33eouYnScSHMBpBmeoACCVJjNkW7/U/eg== X-Received: by 2002:adf:f986:: with SMTP id f6mr4949309wrr.270.1600954490182; Thu, 24 Sep 2020 06:34:50 -0700 (PDT) Received: from google.com ([2a00:79e0:d:110:f693:9fff:fef4:a7ef]) by smtp.gmail.com with ESMTPSA id j26sm4411495wrc.79.2020.09.24.06.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2020 06:34:49 -0700 (PDT) Date: Thu, 24 Sep 2020 14:34:46 +0100 From: Quentin Perret To: Ionela Voinescu Subject: Re: [PATCH 1/3] sched/topology,schedutil: wrap sched domains rebuild Message-ID: <20200924133446.GA3920949@google.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-2-ionela.voinescu@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200924123937.20938-2-ionela.voinescu@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200924_093452_963216_11B29D31 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vincent.guittot@linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, valentin.schneider@arm.com, mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 24 Sep 2020 at 13:39:35 (+0100), Ionela Voinescu wrote: > @@ -433,6 +437,7 @@ static bool build_perf_domains(const struct cpumask *cpu_map) > } > #else > static void free_pd(struct perf_domain *pd) { } > +void rebuild_sched_domains_energy(void) { } Nit: maybe make that stub static inline in a header instead? I guess LTO and friends ought to clean that up for you, but it shouldn't hurt to give the compiler a little bit of help here. Otherwise, LGTM: Acked-by: Quentin Perret > #endif /* CONFIG_ENERGY_MODEL && CONFIG_CPU_FREQ_GOV_SCHEDUTIL*/ > > static void free_rootdomain(struct rcu_head *rcu) > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel