From: Ionela Voinescu <ionela.voinescu@arm.com>
To: Quentin Perret <qperret@google.com>
Cc: vincent.guittot@linaro.org, linux-pm@vger.kernel.org,
peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, valentin.schneider@arm.com,
mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org,
dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] sched/topology,schedutil: wrap sched domains rebuild
Date: Thu, 24 Sep 2020 17:07:48 +0100 [thread overview]
Message-ID: <20200924160748.GA17927@arm.com> (raw)
In-Reply-To: <20200924133446.GA3920949@google.com>
Hey,
On Thursday 24 Sep 2020 at 14:34:46 (+0100), Quentin Perret wrote:
> On Thursday 24 Sep 2020 at 13:39:35 (+0100), Ionela Voinescu wrote:
> > @@ -433,6 +437,7 @@ static bool build_perf_domains(const struct cpumask *cpu_map)
> > }
> > #else
> > static void free_pd(struct perf_domain *pd) { }
> > +void rebuild_sched_domains_energy(void) { }
>
> Nit: maybe make that stub static inline in a header instead? I guess LTO
> and friends ought to clean that up for you, but it shouldn't hurt to give
> the compiler a little bit of help here.
>
Makes sense and will do!
Thank you,
Ionela.
> Otherwise, LGTM:
>
> Acked-by: Quentin Perret <qperret@google.com>
>
> > #endif /* CONFIG_ENERGY_MODEL && CONFIG_CPU_FREQ_GOV_SCHEDUTIL*/
> >
> > static void free_rootdomain(struct rcu_head *rcu)
> > --
> > 2.17.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-24 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 12:39 [PATCH 0/3] condition EAS enablement on FI support Ionela Voinescu
2020-09-24 12:39 ` [PATCH 1/3] sched/topology,schedutil: wrap sched domains rebuild Ionela Voinescu
2020-09-24 13:34 ` Quentin Perret
2020-09-24 16:07 ` Ionela Voinescu [this message]
2020-09-24 12:39 ` [PATCH 2/3] sched/topology: condition EAS enablement on FIE support Ionela Voinescu
2020-09-24 12:39 ` [PATCH 3/3] arm64: rebuild sched domains on invariance status changes Ionela Voinescu
2020-09-24 13:39 ` Quentin Perret
2020-09-24 16:10 ` Ionela Voinescu
2020-09-25 13:59 ` Quentin Perret
2020-09-28 11:55 ` Dietmar Eggemann
2020-09-28 14:23 ` Ionela Voinescu
2020-09-24 13:37 ` [PATCH 0/3] condition EAS enablement on FI support Quentin Perret
2020-09-24 16:08 ` Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924160748.GA17927@arm.com \
--to=ionela.voinescu@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).