From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C023C4363D for ; Thu, 24 Sep 2020 16:09:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D186323600 for ; Thu, 24 Sep 2020 16:09:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IdbIC8zM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D186323600 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TAtEpo1C+NqecqhAUIB+zGhxALuzjB5zeOE9oBRwZ6s=; b=IdbIC8zMvpAJlunhyuYZA3UlX VWrmLs6OeP70kR4n57c8ckQrKjKkl4dcxP+F9dF3/c8sU6d1GbiNs3B0z/waJKlftX0/OYAveSx2I Z4/UPExjWS2NDJeZNDg1v4enyoNWj13ZYN+Gy9V8R/l+cCZFYr7Mi6yK1IAtG10unlSNuvKovNDI5 MNcF/q1CGcNbtrA7KLwpy8S7GP2Qpf4QlN6PIRkUKcPB0aOtXLqyHk01z5xWT9MP0vhGSsQeni2ln fgDErFCC1xkn8SHbn5wZ5M9EyEbv9Tz9tpxxTqfvMlj4Oc58ogOV8HwbwQ0+AcbUcq9ERK1QqFeJe 7BTBSKeZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLTml-0002Q5-FM; Thu, 24 Sep 2020 16:07:55 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLTmi-0002Os-Qb for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2020 16:07:53 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E0B71396; Thu, 24 Sep 2020 09:07:50 -0700 (PDT) Received: from localhost (unknown [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3964A3F718; Thu, 24 Sep 2020 09:07:50 -0700 (PDT) Date: Thu, 24 Sep 2020 17:07:48 +0100 From: Ionela Voinescu To: Quentin Perret Subject: Re: [PATCH 1/3] sched/topology,schedutil: wrap sched domains rebuild Message-ID: <20200924160748.GA17927@arm.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-2-ionela.voinescu@arm.com> <20200924133446.GA3920949@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200924133446.GA3920949@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200924_120752_901810_311FAF4D X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vincent.guittot@linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, valentin.schneider@arm.com, mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey, On Thursday 24 Sep 2020 at 14:34:46 (+0100), Quentin Perret wrote: > On Thursday 24 Sep 2020 at 13:39:35 (+0100), Ionela Voinescu wrote: > > @@ -433,6 +437,7 @@ static bool build_perf_domains(const struct cpumask *cpu_map) > > } > > #else > > static void free_pd(struct perf_domain *pd) { } > > +void rebuild_sched_domains_energy(void) { } > > Nit: maybe make that stub static inline in a header instead? I guess LTO > and friends ought to clean that up for you, but it shouldn't hurt to give > the compiler a little bit of help here. > Makes sense and will do! Thank you, Ionela. > Otherwise, LGTM: > > Acked-by: Quentin Perret > > > #endif /* CONFIG_ENERGY_MODEL && CONFIG_CPU_FREQ_GOV_SCHEDUTIL*/ > > > > static void free_rootdomain(struct rcu_head *rcu) > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel