From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73229C2D0E2 for ; Thu, 24 Sep 2020 16:11:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8E86206C3 for ; Thu, 24 Sep 2020 16:11:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DYGjLhnA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8E86206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QHOvx5ZycdHm41KLUdmoQdRfmZ+8wTZqzC+It971V0g=; b=DYGjLhnAWee7PvB9GnosBEbAY RHnZgJXmnhyJb+caoVgiDIgOD2+zltdffpzVoQIWxneHTWKiaWQIfrVNwqaB84tgaobBLPmL6ipFU iEf/l4k9CvY5KJESjW31QvELnNKQGH6CRpKybQbrDyI8RopuAO/EMznNR9m+7mUZR6Mki0PldGi// 2aZ+j01k2OfIyckyKeETyTq3sO9MhV0GKTUk7XlwC79Rpn5btK85Zgc6NfHbawG7rsyg2iHuMoUqn RHqNRGMF5S7g3a3UaSTJBcbDPCeu/WGpxA6ZAqmWQ0gE1u/eJzbs4MAQDOAGtJ9p3IFKQAR5Nucln Yqq3bStjg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLTot-0002nS-ID; Thu, 24 Sep 2020 16:10:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLToq-0002mS-Qk for linux-arm-kernel@lists.infradead.org; Thu, 24 Sep 2020 16:10:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F01961396; Thu, 24 Sep 2020 09:10:03 -0700 (PDT) Received: from localhost (unknown [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 91EFB3F718; Thu, 24 Sep 2020 09:10:03 -0700 (PDT) Date: Thu, 24 Sep 2020 17:10:02 +0100 From: Ionela Voinescu To: Quentin Perret Subject: Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes Message-ID: <20200924161002.GC17927@arm.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-4-ionela.voinescu@arm.com> <20200924133925.GC3920949@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200924133925.GC3920949@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200924_121004_930617_37E2650A X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vincent.guittot@linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, valentin.schneider@arm.com, mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday 24 Sep 2020 at 14:39:25 (+0100), Quentin Perret wrote: > On Thursday 24 Sep 2020 at 13:39:37 (+0100), Ionela Voinescu wrote: > > For arm64 this affects the task scheduler behavior which builds its > > scheduling domain hierarchy well before the late counter-based FI init. > > During that process it will disable EAS due to its dependency on FI. > > Does it mean we get a warn on every boot, even though this is a > perfectly normal scenario? > Yes, we will get a few "Disabling EAS: frequency-invariant load tracking not supported" warnings until the final rebuild of the sched domains finds FI supported and enables EAS (silently this time, which possibly makes things worse). We have the same behavior for removing and adding the schedutil governor. I'm not sure what is a good way of fixing this.. I could add more info to the warning to suggest it might be temporary ("Disabling EAS: frequency-invariant load tracking currently not supported"). For further debugging there are the additional prints guarded by sched_debug(). I'll look over the code some more to see if other ideas pop out. Any suggestions are appreciated. Many thanks for the review, Ionela. > Thanks, > Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel