From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E5F4C4363D for ; Fri, 25 Sep 2020 09:38:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5857207C4 for ; Fri, 25 Sep 2020 09:38:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZSp1sF32" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B5857207C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QnUkp9SxQ9VMA/F8lykUZLHin8bkmYAjtimswmOrga4=; b=ZSp1sF32QIt4DMYOMEgatwv3s 2bR2Bb2C3LCh3VaqvScYSR+emfpsvilTQOhFpJRo+URw5eBrdVVOIbnk9ku3TcWsfxR0Y7ttpfAbX ZNpyi419MNOwqBJBLIrCnq15Ep3C1Ko3cEF0X647JdqRWKsLY/oL9UmfnoSvoz+Vg4DNDZvkrxPLM tE7HBMpf4/AiFVsuNfwwpYjmJnP05K3/OaSOILkqTGWV+KUsbgU20GujVOTlNAPv++LVCi6089bW6 eSNWSMRj8am88l7m9s8PxEJb96/I5xqL9BVuAVhu7Vkxh7AQKFc1MIXTTAJcNRQrBhm7v8L0EP6VJ Wtdyw8WSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLk9x-0006VL-BX; Fri, 25 Sep 2020 09:36:57 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLk9Q-0006Is-Vn for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 09:36:27 +0000 X-Originating-IP: 90.65.88.165 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 4F9B3FF809; Fri, 25 Sep 2020 09:36:15 +0000 (UTC) Date: Fri, 25 Sep 2020 11:36:14 +0200 From: Alexandre Belloni To: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= Subject: Re: [PATCH v3 5/7] rtc: New driver for RTC in Netronix embedded controller Message-ID: <20200925093614.GZ9675@piout.net> References: <20200924192455.2484005-1-j.neuschaefer@gmx.net> <20200924192455.2484005-6-j.neuschaefer@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200924192455.2484005-6-j.neuschaefer@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_053625_238403_F6D0AAE2 X-CRM114-Status: GOOD ( 37.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , devicetree@vger.kernel.org, Linus Walleij , Thierry Reding , Fabio Estevam , linux-rtc@vger.kernel.org, Arnd Bergmann , Mauro Carvalho Chehab , Sam Ravnborg , Daniel Palmer , Andy Shevchenko , Andreas Kemnade , NXP Linux Team , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-pwm@vger.kernel.org, Stephan Gerhold , allen , Sascha Hauer , Lubomir Rintel , Rob Herring , Lee Jones , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , linux-kernel@vger.kernel.org, Mark Brown , Pengutronix Kernel Team , Heiko Stuebner , Josua Mayer , Shawn Guo , "David S. Miller" Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 24/09/2020 21:24:53+0200, Jonathan Neusch=E4fer wrote: > With this driver, mainline Linux can keep its time and date in sync with > the vendor kernel. > = > Advanced functionality like alarm and automatic power-on is not yet > supported. > = > Signed-off-by: Jonathan Neusch=E4fer > --- > = > v3: > - Add email address to copyright line > - Remove OF compatible string and don't include linux/of_device.h > - Don't use a comma after sentinels > - Avoid ret |=3D ... pattern > - Move 8-bit register conversion to ntxec.h > - Relicense as GPLv2 or later I don't think you had to relicense. The kernel is GPL 2 only, you are free to license your code under GPL 2 only if that is what you desire. > = > v2: > - https://lore.kernel.org/lkml/20200905133230.1014581-7-j.neuschaefer@gmx= .net/ > - Rework top-of-file comment [Lee Jones] > - Sort the #include lines [Alexandre Belloni] > - don't align =3D signs in struct initializers [Uwe Kleine-K=F6nig] > - Switch to regmap > - Fix register number used to read minutes and seconds > - Prefix registers with NTXEC_REG_ > - Add help text to the Kconfig option > - Use devm_rtc_allocate_device and rtc_register_device, set ->range_min a= nd ->range_max > --- > drivers/rtc/Kconfig | 8 +++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-ntxec.c | 132 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 141 insertions(+) > create mode 100644 drivers/rtc/rtc-ntxec.c > = > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index 48c536acd777f..ae8f3dc36c9a3 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -1301,6 +1301,14 @@ config RTC_DRV_CROS_EC > This driver can also be built as a module. If so, the module > will be called rtc-cros-ec. > = > +config RTC_DRV_NTXEC > + tristate "Netronix embedded controller RTC driver" > + depends on MFD_NTXEC > + help > + Say yes here if you want to support the RTC functionality of the > + embedded controller found in certain e-book readers designed by the > + ODM Netronix. > + > comment "on-CPU RTC drivers" > = > config RTC_DRV_ASM9260 > diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile > index 880e08a409c3d..733479db18896 100644 > --- a/drivers/rtc/Makefile > +++ b/drivers/rtc/Makefile > @@ -111,6 +111,7 @@ obj-$(CONFIG_RTC_DRV_MT7622) +=3D rtc-mt7622.o > obj-$(CONFIG_RTC_DRV_MV) +=3D rtc-mv.o > obj-$(CONFIG_RTC_DRV_MXC) +=3D rtc-mxc.o > obj-$(CONFIG_RTC_DRV_MXC_V2) +=3D rtc-mxc_v2.o > +obj-$(CONFIG_RTC_DRV_NTXEC) +=3D rtc-ntxec.o > obj-$(CONFIG_RTC_DRV_OMAP) +=3D rtc-omap.o > obj-$(CONFIG_RTC_DRV_OPAL) +=3D rtc-opal.o > obj-$(CONFIG_RTC_DRV_PALMAS) +=3D rtc-palmas.o > diff --git a/drivers/rtc/rtc-ntxec.c b/drivers/rtc/rtc-ntxec.c > new file mode 100644 > index 0000000000000..af23c7cc76544 > --- /dev/null > +++ b/drivers/rtc/rtc-ntxec.c > @@ -0,0 +1,132 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +/* > + * The Netronix embedded controller is a microcontroller found in some > + * e-book readers designed by the ODM Netronix, Inc. It contains RTC, > + * battery monitoring, system power management, and PWM functionality. > + * > + * This driver implements access to the RTC time and date. > + * > + * Copyright 2020 Jonathan Neusch=E4fer > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +struct ntxec_rtc { > + struct device *dev; > + struct ntxec *ec; > +}; > + > +#define NTXEC_REG_WRITE_YEAR 0x10 > +#define NTXEC_REG_WRITE_MONTH 0x11 > +#define NTXEC_REG_WRITE_DAY 0x12 > +#define NTXEC_REG_WRITE_HOUR 0x13 > +#define NTXEC_REG_WRITE_MINUTE 0x14 > +#define NTXEC_REG_WRITE_SECOND 0x15 > + > +#define NTXEC_REG_READ_YM 0x20 > +#define NTXEC_REG_READ_DH 0x21 > +#define NTXEC_REG_READ_MS 0x23 > + > +static int ntxec_read_time(struct device *dev, struct rtc_time *tm) > +{ > + struct ntxec_rtc *rtc =3D dev_get_drvdata(dev); > + unsigned int value; > + int res; > + > + res =3D regmap_read(rtc->ec->regmap, NTXEC_REG_READ_YM, &value); > + if (res < 0) > + return res; > + > + tm->tm_year =3D (value >> 8) + 100; > + tm->tm_mon =3D (value & 0xff) - 1; > + > + res =3D regmap_read(rtc->ec->regmap, NTXEC_REG_READ_DH, &value); > + if (res < 0) > + return res; > + > + tm->tm_mday =3D value >> 8; > + tm->tm_hour =3D value & 0xff; > + > + res =3D regmap_read(rtc->ec->regmap, NTXEC_REG_READ_MS, &value); > + if (res < 0) > + return res; > + > + tm->tm_min =3D value >> 8; > + tm->tm_sec =3D value & 0xff; > + > + return 0; > +} > + > +static int ntxec_set_time(struct device *dev, struct rtc_time *tm) > +{ > + struct ntxec_rtc *rtc =3D dev_get_drvdata(dev); > + int res =3D 0; > + > + res =3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_YEAR, ntxec_reg8(= tm->tm_year - 100)); > + if (res) > + return res; > + > + res =3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_MONTH, ntxec_reg8= (tm->tm_mon + 1)); > + if (res) > + return res; > + > + res =3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_DAY, ntxec_reg8(t= m->tm_mday)); > + if (res) > + return res; > + > + res =3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_HOUR, ntxec_reg8(= tm->tm_hour)); > + if (res) > + return res; > + > + res =3D regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_MINUTE, ntxec_reg= 8(tm->tm_min)); > + if (res) > + return res; > + > + return regmap_write(rtc->ec->regmap, NTXEC_REG_WRITE_SECOND, ntxec_reg8= (tm->tm_sec)); > +} > + > +static const struct rtc_class_ops ntxec_rtc_ops =3D { > + .read_time =3D ntxec_read_time, > + .set_time =3D ntxec_set_time, > +}; > + > +static int ntxec_rtc_probe(struct platform_device *pdev) > +{ > + struct rtc_device *dev; > + struct ntxec_rtc *rtc; > + > + rtc =3D devm_kzalloc(&pdev->dev, sizeof(*rtc), GFP_KERNEL); > + if (!rtc) > + return -ENOMEM; > + > + rtc->dev =3D &pdev->dev; > + rtc->ec =3D dev_get_drvdata(pdev->dev.parent); > + platform_set_drvdata(pdev, rtc); > + > + dev =3D devm_rtc_allocate_device(&pdev->dev); > + if (IS_ERR(dev)) > + return PTR_ERR(dev); > + > + dev->ops =3D &ntxec_rtc_ops; > + dev->range_min =3D RTC_TIMESTAMP_BEGIN_2000; > + dev->range_max =3D 9025257599LL; /* 2255-12-31 23:59:59 */ > + > + return rtc_register_device(dev); > +} > + > +static struct platform_driver ntxec_rtc_driver =3D { > + .driver =3D { > + .name =3D "ntxec-rtc", > + }, > + .probe =3D ntxec_rtc_probe, > +}; > +module_platform_driver(ntxec_rtc_driver); > + > +MODULE_AUTHOR("Jonathan Neusch=E4fer "); > +MODULE_DESCRIPTION("RTC driver for Netronix EC"); > +MODULE_LICENSE("GPL"); > -- > 2.28.0 > = -- = Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel