From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F2EC4363D for ; Fri, 25 Sep 2020 12:39:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76A1120BED for ; Fri, 25 Sep 2020 12:39:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iRD6y4/D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76A1120BED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cdkEbyjeEgSU1zuuG7bb3tkuRZqgrn/Obz8H6Zkqfyc=; b=iRD6y4/DBoewcrtmsZUAQat0f hndmNohL6oaJ+th/NpQ4/Duz3e+DRe46yssf06wdxDadOfJEhrD/RhW26yyS8tN2cwZakA1VJdQxF 5xHDMgTJ34wcP7G9EgFKyeAv7xJkLsrwM5+aBBQyTIOLkvaYrNki3AJLa/4oTGPkgLtioamUJ/Dsg tYfWvU1QH9xAjLomnvFJ6RaLEeY5jVFHYa9clb5L9X1JDJHXu//IIW02EdU6U/EP54EAWDpM/XdJu DWMn/Wfr5BzHmRYBmXBP4CIp9gnSkksvA17mFwSKbth3xBO0VRFuusUuT+AE1tcnLegbzlp5J2Ab2 BZn56/SQQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLmzT-0001jX-Lf; Fri, 25 Sep 2020 12:38:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLmzQ-0001iS-CU for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 12:38:17 +0000 Received: from gaia (unknown [31.124.44.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 200A721D7A; Fri, 25 Sep 2020 12:38:12 +0000 (UTC) Date: Fri, 25 Sep 2020 13:38:10 +0100 From: Catalin Marinas To: Vincenzo Frascino Subject: Re: [PATCH v3 29/39] arm64: mte: Switch GCR_EL1 in kernel entry and exit Message-ID: <20200925123810.GL4846@gaia> References: <4e503a54297cf46ea1261f43aa325c598d9bd73e.1600987622.git.andreyknvl@google.com> <20200925113433.GF4846@gaia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_083816_519682_53DDF23D X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Elena Petrova , Andrey Konovalov , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 25, 2020 at 12:50:23PM +0100, Vincenzo Frascino wrote: > On 9/25/20 12:34 PM, Catalin Marinas wrote: > > On Fri, Sep 25, 2020 at 12:50:36AM +0200, Andrey Konovalov wrote: > >> + /* > >> + * Calculate and set the exclude mask preserving > >> + * the RRND (bit[16]) setting. > >> + */ > >> + mrs_s \tmp2, SYS_GCR_EL1 > >> + bfi \tmp2, \tmp, #0, #16 > >> + msr_s SYS_GCR_EL1, \tmp2 > >> + isb > >> +1: > >> +#endif > >> + .endm > >> + > >> + .macro mte_set_kernel_gcr, tsk, tmp, tmp2 > > > > What's the point of a 'tsk' argument here? > > It is unused. I kept the interface same in between kernel and user. > I can either add a comment or remove it. Which one do you prefer? Please remove it. Having the same interface is more confusing since you have a single kernel gcr_excl but multiple user gcr_excl. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel