From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0006DC4363D for ; Fri, 25 Sep 2020 16:11:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA43E235FD for ; Fri, 25 Sep 2020 16:11:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H8kdx3sz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="CRXaAJ/l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA43E235FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e8HxPOyMC8uY/SITpgHe7cq4CmmyLTFnkXls0/e6P1U=; b=H8kdx3szCPEIFFRqQ32ijlkU/ YIfPd43wEkx9gRalfjVSggHJovnp9+5IV5zovUu02nQ36hVsv3eYk+bCKfVkNtugJgizP2ZGBXQQE Cmt50/wx4co9UEyU74RsvicVXKTxcDY3oecAkQWYmoQA1RfBK9iZWUwwdSVeXMxb4L7lTyT4IZ1rq yJmzF8LwhssfGabeZDutxoANMjhAL0InQNGSD1GRtqb1KneuL5V8jQEYu0nIGmlQGuNvLGTHgFdmt 9gkKffz0Wy5Lv/wu13jTXOUtyWsecFFuM95cwAtVe168LVEWKqbQiIGtd5DO1C+ExSX6ctguoqh0T F8GymsrxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLqIh-0007QQ-Gx; Fri, 25 Sep 2020 16:10:23 +0000 Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLqGr-0006Yk-Nm for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 16:08:33 +0000 Received: from zn.tnic (p200300ec2f0b3a00329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:3a00:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C49621EC0284; Fri, 25 Sep 2020 18:08:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1601050104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=eqBo++0bLNLcrE7VXscLCEz7howWeoc6lAOi3PzLORk=; b=CRXaAJ/lHqqbjXX2EAfkl4LJ5fcoibyKjIKgvZyIkMi5tDvJcPiYVH4BR4J8TIS5r++kSI 00rKHSFQJ9i1M1sBEDC3bErbdmdbKqII/es2WtrnoNvfYPOrqlRC4gfCkBiBGmH/cM8VKm U8lDy27jIA6cZrQNNLxRAfDl0XzDYQ0= Date: Fri, 25 Sep 2020 18:08:17 +0200 From: Borislav Petkov To: Jonathan Cameron Subject: Re: [PATCH v10 2/6] x86: Support Generic Initiator only proximity domains Message-ID: <20200925160817.GJ16872@zn.tnic> References: <20200907140307.571932-1-Jonathan.Cameron@huawei.com> <20200907140307.571932-3-Jonathan.Cameron@huawei.com> <20200923160609.GO28545@zn.tnic> <20200925123226.0000636a@Huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200925123226.0000636a@Huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_120829_931518_73740E46 X-CRM114-Status: GOOD ( 23.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , linux-acpi@vger.kernel.org, rafael@kernel.org, linux-api@vger.kernel.org, x86@kernel.org, Hanjun Guo , linux-kernel@vger.kernel.org, linuxarm@huawei.com, linux-mm@kvack.org, Ingo Molnar , Brice Goglin , Bjorn Helgaas , Thomas Gleixner , Dan Williams , linux-arm-kernel@lists.infradead.org, Sean V Kelley Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 25, 2020 at 12:32:26PM +0100, Jonathan Cameron wrote: > I don't think we can. This is doing the same operation as > is done for memoryless cpu nodes in the init_cpu_to_node() call above > so it would make little sense from a code flow point of view, even if > it were possible. However it isn't possible as far as I can see. > > It is called after init_cpu_to_node() because... > * A GI node may also be a CPU node and / or a Memory Node, but we only > have to do anything extra if it has neither of these. > Easiest way to do that is use the same logic init_cpu_to_node() > does and rely on ordering wrt to the other two types of nodes that > have already been handled. We could have could just call it at the > end of init_cpu_to_node() but I'd not be happy doing so without renaming > that function and then we'd end up with a horrible name like > init_cpu_to_node_and_gi() as they are rather different things. > > It needs to happen before use is made of the node_data which is allocated > in init_gi_nodes() / init_memoryless_node() / alloc_node_data() Let's put the gist of this requirement in the comment above init_gi_nodes() for future reference. ... > It might be possible to allocate the zonelists for this special case later > in the boot flow, but it seems like we would be adding a lot of complexity > to avoid a single function call. Nah, probably not worth the hassle. > How about this? > > +/* > + * A node may exist which has one or more Generic Initiators but no > + * CPUs and no memory. > + * When this function is called, any nodes containing either memory > + * and/or CPUs will already be online and there is no need to do > + * anything extra, even if they also contain one or more Generic > + * Initiators. > + */ Yes, along with the above gist. Thx! -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel