From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 717FEC4363D for ; Fri, 25 Sep 2020 16:22:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C52322087D for ; Fri, 25 Sep 2020 16:22:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wbyr8ZCu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TN31U+/6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C52322087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JHszSRNEsE3W7htOyDEBjEOU4BMYAJnFv3mCcV+Ul6o=; b=Wbyr8ZCuefm0+/dlmMYnjcpYu +r+sUV3bbU98t67cgFZK1w2rHkiHS+CHII+5pnwnDPQp4bZRtdwXL+PjL1p9VxRFvYD1VRcvcRg5i JJ6Q2xEbuYLZcmds6tUiNCymTxR6Tzsrvs2d+HEbpsI1YVkrwiptjxn0YqP3iBEJAoyLD8yoy927X SYgO8xKr5Q41dJepHbEAZzGHb6NS+33hJxYsGm6N6o8I4/klBGJkhzYEvV3w8/JXikRgeTATbkWZI foaR+KIg1oPjQQLAAxd1VHSz75DGtRUbgHCnBuHKVmU0/J2tKjf4ldr5YBACxgu0I0aQWfuxAfwP3 ew7iZZdzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLqSr-00024D-7f; Fri, 25 Sep 2020 16:20:53 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kLqSo-00023S-JD for linux-arm-kernel@lists.infradead.org; Fri, 25 Sep 2020 16:20:51 +0000 Received: by mail-pg1-x542.google.com with SMTP id u24so3035051pgi.1 for ; Fri, 25 Sep 2020 09:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mm59MF34JUHn/sNG+XsAVRaMRhXvrdKO3x6Jkh5KNIA=; b=TN31U+/6fwbpL7vRkIEMAZpIiyeUg08+VGuPCowIt2N9N7PIQBHPotgYi3YdlESSQi qKFjVJHiGKcmqUHBuGecJdTOzJsFzWRdMFQomp0Tn17AONyZTyHN2ttRdM+rm5AbbmS4 NV+FIEm20YWPFYf2mPBFLCTnN3/XYvBV65hJcMZdbBCinFtXbRUv471wAXcUqiQSJYgD /JZJaGzLF/EkEPNP4BW03vVcuTC0ycTaK4QRBpXCfDoaK1b1gJNP7vf2l01qEwO+Tfmn EImVwevBDWx29QdQkh+Mc72YdLaSbjPZ99P4ZWroepy0nQzQyoLaknkqleEmf3qNFd5k 0S0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mm59MF34JUHn/sNG+XsAVRaMRhXvrdKO3x6Jkh5KNIA=; b=XDZmTGOqOl1iq3xWrUZ1qxWX5ekhScaS3OFb1Y5rmRIQgaSw5wtkyz3/AfMNBXhuMc QAta/k50yMjYeThPNUE7ksRXixtfmAmDWgEe0FQfwQl+uaDc1r/BL/bVIdvdz1QwniA2 IiSLePxpRliAJB8W2QdLRp6J9S5T2H0HC63cMLszYCTjLjb6pC9sITtlaZVj287ZsI6c DcM0Am5gD+BqGukeSdCvl4vPZSaozDeKSOFW/kL7Ia4xOVcjj5FlofVpYX00hSZIN3VE aQx35oTGwbWZneBqd9YKxyjnlAsS5KhzHiCaPTgf2Juf96GDnE7/fWnOe7f5ANOWEifR 0MVg== X-Gm-Message-State: AOAM530cOcHCqtzfDNq9IXR3oZewMimQ+gp5OdXNDlGg5EKD254yV8DC ncgNqXSYfUwa7h9b5T9M1TMBW9OEJInXoh4= X-Google-Smtp-Source: ABdhPJyoG/hQhlMEyUNWB3uBTgPZVsp0nko1WeZ01LzyYWkf415zmPMrp48gHZ+k8R5vamknCal3Nw== X-Received: by 2002:a62:1dc1:0:b029:13e:d13d:a051 with SMTP id d184-20020a621dc10000b029013ed13da051mr38090pfd.23.1601050846581; Fri, 25 Sep 2020 09:20:46 -0700 (PDT) Received: from linux ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id fw4sm2413372pjb.55.2020.09.25.09.20.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Sep 2020 09:20:45 -0700 (PDT) Date: Fri, 25 Sep 2020 21:50:40 +0530 From: Manivannan Sadhasivam To: Marek Vasut Subject: Re: [PATCH] ARM: dts: stm32: Enable thermal sensor support on stm32mp15xx-dhcor Message-ID: <20200925162040.GA4746@linux> References: <20200923232535.241437-1-marex@denx.de> <0D1E174A-2217-4785-B4E5-79135AAF76F1@linaro.org> <5d0c9b8f-8f6b-a4c7-dc80-638e23749310@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200925_122050_675426_1838D454 X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 25, 2020 at 01:12:12PM +0200, Marek Vasut wrote: > On 9/25/20 4:21 AM, Manivannan Sadhasivam wrote: > > > > > > On 24 September 2020 4:11:11 PM IST, Marek Vasut wrote: > >> On 9/24/20 7:16 AM, Manivannan Sadhasivam wrote: > >>> > >>> > >>> On 24 September 2020 4:55:35 AM IST, Marek Vasut > >> wrote: > >>>> Enable STM32 Digital Thermal Sensor driver for stm32mp15xx-dhcor > >> SoMs. > >>>> > >>>> Fixes: 94cafe1b6482 ("ARM: dts: stm32: Add Avenger96 devicetree > >> support > >>>> based on STM32MP157A") > >>> > >>> The change looks good but what does this patch fixes? > >> > >> The missing temp sensor, which helps you detect overheat of the SoC. > >> That is esp. important on the 800 MHz AV96. > > > > This doesn't quality as a "fix". Essentially you're just adding a missing feature and not fixing any issues. So please remove the fixes tag and resubmit. > > I would argue that if the system overheats and crashes, we want to know > about that, possibly in advance so thermal throttling can be applied. > Currently this is not possible and I think that is a bug. No, this is not a _bug_. This is a missing feature that the current kernel doesn't support and you know about that! The fact that you can trigger a crash due to hw limitation doesn't qualify as a bug IMO. And you can do that by other means also (CPU throttling without CPUFreq support etc...) Anyway, I'll stop here and let Alex to make a call. Either case, feel free to add: Reviewed-by: Manivannan Sadhasivam Thanks, Mani _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel