Re: [PATCH v2 2/7] drivers: mfd: Add a driver for iEi WT61P803 PUZZLE MCU

From: kernel test robot <lkp@intel.com>
To: Luka Kovacic <luka.kovacic@sartura.hr>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org
Cc: jdelvare@suse.com, kbuild-all@lists.01.org, robh+dt@kernel.org,
	dmurphy@ti.com, pavel@ucw.cz, lee.jones@linaro.org,
	linux@roeck-us.net
Subject: Re: [PATCH v2 2/7] drivers: mfd: Add a driver for iEi WT61P803 PUZZLE MCU
Date: Sun, 27 Sep 2020 03:16:16 +0800	[thread overview]
Message-ID: <202009270302.golHWFZD%lkp@intel.com> (raw)
In-Reply-To: <20200926135514.26189-3-luka.kovacic@sartura.hr>

[-- Attachment #1: Type: text/plain, Size: 2909 bytes --]

Hi Luka,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on lee-mfd/for-mfd-next pavel-linux-leds/for-next linus/master v5.9-rc6 next-20200925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luka-Kovacic/Add-support-for-the-iEi-Puzzle-M801-board/20200926-215756
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: x86_64-randconfig-s032-20200927 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.2-201-g24bdaac6-dirty
        # https://github.com/0day-ci/linux/commit/d025100057209ebc82b8dbc49aeff8c9acfc36f4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luka-Kovacic/Add-support-for-the-iEi-Puzzle-M801-board/20200926-215756
        git checkout d025100057209ebc82b8dbc49aeff8c9acfc36f4
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)

>> drivers/mfd/iei-wt61p803-puzzle.c:121:15: sparse: sparse: symbol 'iei_wt61p803_puzzle_checksum' was not declared. Should it be static?
>> drivers/mfd/iei-wt61p803-puzzle.c:305:5: sparse: sparse: symbol 'iei_wt61p803_puzzle_buzzer' was not declared. Should it be static?
>> drivers/mfd/iei-wt61p803-puzzle.c:344:5: sparse: sparse: symbol 'iei_wt61p803_puzzle_get_version' was not declared. Should it be static?
>> drivers/mfd/iei-wt61p803-puzzle.c:423:5: sparse: sparse: symbol 'iei_wt61p803_puzzle_get_mcu_status' was not declared. Should it be static?
>> drivers/mfd/iei-wt61p803-puzzle.c:472:5: sparse: sparse: symbol 'iei_wt61p803_puzzle_get_serial_number' was not declared. Should it be static?
>> drivers/mfd/iei-wt61p803-puzzle.c:499:5: sparse: sparse: symbol 'iei_wt61p803_puzzle_write_serial_number' was not declared. Should it be static?
>> drivers/mfd/iei-wt61p803-puzzle.c:547:5: sparse: sparse: symbol 'iei_wt61p803_puzzle_get_mac_addresses' was not declared. Should it be static?
>> drivers/mfd/iei-wt61p803-puzzle.c:584:5: sparse: sparse: symbol 'iei_wt61p803_puzzle_write_mac_address' was not declared. Should it be static?
>> drivers/mfd/iei-wt61p803-puzzle.c:633:5: sparse: sparse: symbol 'iei_wt61p803_puzzle_write_power_loss_recovery' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34195 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel