From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09800C2D0A8 for ; Mon, 28 Sep 2020 05:19:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFC5821548 for ; Mon, 28 Sep 2020 05:19:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vs0Gz98V"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oILbqk42" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFC5821548 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gPIMQ+PFOCIWhw6Kt5ztZsRVRXLOONGJ4rTlak/+tI4=; b=vs0Gz98VmfdS3Wc3DoN1sQd54 n1dfCTv0w+Cx5RvIWdQsudH/oHBgOWGT597WFgYaWqpgd6tLFj3yXMj0riW3nNNWYmN917z8r2BCY LBbCFUng4Esu+rMcW/jfXIWRYhfebfoWiHCHDfdGgAZU9P2KlW3dUcbT855sX83PHoWWWBTXvH1yX oxrMJ0oYVjyTYy6Jr6Meug2cGS53DVYfvCrkHiGtlSh7BuNnUT/ntReJTRaGWLmeS0lZN+W1a3haw poAcbFF9up4E505vneCtB9pcojg58wlMgMJsf4bXn3LNgoi7N9YZA1F8UStB36z48woMykD/Wpqnr leLuDAlyQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMlYB-0003qA-JY; Mon, 28 Sep 2020 05:18:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMlXu-0003li-Qr for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 05:18:01 +0000 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2572521548; Mon, 28 Sep 2020 05:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601270273; bh=dRyaItky7NDVsosujj6hxANM/My0xGr500c9g2v3K80=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oILbqk42mgFiC/0wm+Hq8xqNtKTVeaNHNJVlq/yEsH5vTjhMAUIQqI/9VQahtvo+v ZQiUNBezGR+zks7Tha4miUxcT84MSypgy/CgJ98lYqOGnKzJjrBNbNN8jwKz78NPY7 yGYEtpkqlY6gWDHQg+yTBHHqQ0RUqR+INn+RGTO4= Date: Mon, 28 Sep 2020 07:17:48 +0200 From: Greg KH To: Prasad Sodagudi Subject: Re: [PATCH] tracing: Add register read and write tracing support Message-ID: <20200928051748.GA767987@kroah.com> References: <1601253290-400618-1-git-send-email-psodagud@codeaurora.org> <1601253290-400618-2-git-send-email-psodagud@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1601253290-400618-2-git-send-email-psodagud@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_011755_052265_AAC5EE21 X-CRM114-Status: GOOD ( 17.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: saiprakash.ranjan@codeaurora.org, keescook@chromium.org, arnd@arndb.de, jim.cromie@gmail.com, linux-arm-msm@vger.kernel.org, anton@enomsg.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, ccross@android.com, joel@joelfernandes.org, jbaron@akamai.com, mingo@redhat.com, catalin.marinas@arm.com, joe@perches.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Sep 27, 2020 at 05:34:50PM -0700, Prasad Sodagudi wrote: > Add register read/write operations tracing support. > ftrace events helps trace register read and write > location details of memory mapped IO registers. Also > add _no_log variants the writel_relaxed/readl_relaed > APIs to avoid excessive logging for certain register > operations. > > Signed-off-by: Prasad Sodagudi > --- > arch/arm64/include/asm/io.h | 117 ++++++++++++++++++++++++++++++++++++++--- > include/linux/iorw.h | 20 +++++++ > include/trace/events/rwio.h | 51 ++++++++++++++++++ > kernel/trace/Kconfig | 11 ++++ > kernel/trace/Makefile | 1 + > kernel/trace/trace_readwrite.c | 30 +++++++++++ > 6 files changed, 222 insertions(+), 8 deletions(-) > create mode 100644 include/linux/iorw.h > create mode 100644 include/trace/events/rwio.h > create mode 100644 kernel/trace/trace_readwrite.c > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > index ff50dd7..db5acff 100644 > --- a/arch/arm64/include/asm/io.h > +++ b/arch/arm64/include/asm/io.h > @@ -9,6 +9,7 @@ > #define __ASM_IO_H > > #include > +#include > #include > > #include > @@ -24,24 +25,28 @@ > #define __raw_writeb __raw_writeb > static inline void __raw_writeb(u8 val, volatile void __iomem *addr) > { > + log_write_io(addr); > asm volatile("strb %w0, [%1]" : : "rZ" (val), "r" (addr)); You are just logging the address, what about the data written or read? Why throw away half of the information here? Oh, and sending patches that break the build is generally not a good thing to do :) thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel