From: Greg KH <gregkh@linuxfoundation.org>
To: Prasad Sodagudi <psodagud@codeaurora.org>
Cc: saiprakash.ranjan@codeaurora.org, keescook@chromium.org,
arnd@arndb.de, jim.cromie@gmail.com,
linux-arm-msm@vger.kernel.org, anton@enomsg.org,
linux-kernel@vger.kernel.org, rostedt@goodmis.org,
ccross@android.com, joel@joelfernandes.org, jbaron@akamai.com,
mingo@redhat.com, catalin.marinas@arm.com, joe@perches.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tracing: Add register read and write tracing support
Date: Mon, 28 Sep 2020 07:20:05 +0200 [thread overview]
Message-ID: <20200928052005.GB767987@kroah.com> (raw)
In-Reply-To: <1601253290-400618-2-git-send-email-psodagud@codeaurora.org>
On Sun, Sep 27, 2020 at 05:34:50PM -0700, Prasad Sodagudi wrote:
> +config TRACE_RW
> + bool "Register read/write tracing"
> + select TRACING
> + default n
n is always the default, no need to list it.
And you only did this for one arch, yet you made a generic kernel config
option, is that really wise?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-28 5:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 0:34 [PATCH] Register read and writes tracing Prasad Sodagudi
2020-09-28 0:34 ` [PATCH] tracing: Add register read and write tracing support Prasad Sodagudi
2020-09-28 2:37 ` kernel test robot
2020-09-28 5:17 ` Greg KH
2020-09-28 5:20 ` Greg KH [this message]
2020-09-28 10:06 ` kernel test robot
2020-09-28 14:55 ` Steven Rostedt
2020-09-28 5:45 ` [PATCH] Register read and writes tracing Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928052005.GB767987@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=ccross@android.com \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=psodagud@codeaurora.org \
--cc=rostedt@goodmis.org \
--cc=saiprakash.ranjan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).