From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80995C2D0A8 for ; Mon, 28 Sep 2020 08:44:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26820207E8 for ; Mon, 28 Sep 2020 08:44:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ElIVkWKa"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="pnNGbA6R"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="t2qgWJin" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26820207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T9oJvD40OfcLaK8zCphPuH/a+Uen0MdrZbf9vZl2dKE=; b=ElIVkWKaDf5DfSwYOOFs0+R4N /hrTNKDDHNGXt6zD+3EHl4RESq+uQYnbiO35LkgU92Z5dEs1ScGtEmHrWMvdmAiAJ0WzsLwnB7tIU HklOe89l6pdjmNRj8rmrGY5CBB3wFpTIDJDR2WR1nJpNinQLb8bPOCUnfK5uSsycwLYzm7ravmmfx C5KI+9EMuJGqBK6Fzxg4Gi4sFL3alt5fCRWqSVQB/V9fmBTSfikEZri7dQzh0EbI9eT4c/OJ3XiLD Hu/bG364/9I84FHd3uyqss+dMkb1nVo6Le8V22wAwxl92Zx4EaqN3icGIMB+GHD3RNc6jmIbUMsVv eoHLX1pxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMokl-0000Dk-3d; Mon, 28 Sep 2020 08:43:23 +0000 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMokh-0000CG-Pg for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 08:43:21 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 943AB2BD; Mon, 28 Sep 2020 04:43:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 28 Sep 2020 04:43:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=oxCK4wZOYpID0KZNTWauBK7/zlc BHvmxDD57Zu4cEmY=; b=pnNGbA6Rd0/uCTZbqMkjs3TBsnmQi5Dr0UcDALXDm5A h9MmxQojzlLgXVXeANvDCI30nfhO35jBHrOwgz0nYENDOTyUdlmkLGZllQkZXOhi LxjJRXxEuNq/rYKan5TQl76mBLlhi/kCRXh8T59OyuYd5IV5FQLxjAr3UPAL9NFP FvCscbTea0418vZMpBhAVHxkMXvL9KybOtc+iSPz50uYqLpMvQIfx9d21+f7GgBR thvZGJ25fvimeG/NSVoAjlegEbbeTuDRJEMPGxsPiv0Mlw2yY8vJvK9vS+MpgYaN v+kFDUqfriqimfYfHmiArCUaV0l5S6tATF5wmkyZ2FQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=oxCK4w ZOYpID0KZNTWauBK7/zlcBHvmxDD57Zu4cEmY=; b=t2qgWJinD9T7l3X1sihDHk ulEywM7SzPKT+6dU8eLtTG4gAK1VU+fyn/LlTwR1uvvi65awadNnc1p3QwCd/mb5 r8kXyzFHd5m+XiQZvHOmpm4+tmaZiI18rmWVV1D/hz89cl/y1bUNQGTPXPKfd4uH xO+emcKI7P8Amep8W6PaFRN701o5Z/F4mQZN2iAraCsadLA1THXn0XbRcFw1OpsD JSsXgEahaltzX5N6UbwiIUmFWLN4TB4DzwLQKcELnqr4mEnBguKPmgeaDuGxYBsO nmfLBxYD7kqR7Lg7VhpPsIq/iXeMIaoHXGfmYxDtIFBZL7RlpPRMgNM6xHH//ATQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeigddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeeutdfgjeeuudehvefgvedvtedtudelfffgffekledtffekgedukeejueevieeg udenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id A310C328005A; Mon, 28 Sep 2020 04:43:09 -0400 (EDT) Date: Mon, 28 Sep 2020 10:43:08 +0200 From: Maxime Ripard To: Jernej =?utf-8?Q?=C5=A0krabec?= Subject: Re: [PATCH v4 09/22] arm64: dts: allwinner: h6: Add HDMI audio node Message-ID: <20200928084308.eipnvlfqe3c5lfmg@gilmour.lan> References: <20200921102731.747736-1-peron.clem@gmail.com> <20200921135925.q7mde2cnt5jtzkb5@gilmour.lan> <59286578.E0qSRroNqr@kista> MIME-Version: 1.0 In-Reply-To: <59286578.E0qSRroNqr@kista> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_044319_968116_EFDB4BA2 X-CRM114-Status: GOOD ( 25.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Linux-ALSA , linux-sunxi , linux-kernel , Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , Marcus Cooper , Chen-Yu Tsai , Rob Herring , =?utf-8?B?Q2zDqW1lbnQgUMOpcm9u?= , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============1583916539618155651==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1583916539618155651== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nywbcxkwq6lidb2p" Content-Disposition: inline --nywbcxkwq6lidb2p Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 21, 2020 at 08:37:09PM +0200, Jernej =C5=A0krabec wrote: > Dne ponedeljek, 21. september 2020 ob 19:23:49 CEST je Cl=C3=A9ment P=C3= =A9ron=20 > napisal(a): > > Hi Maxime, > >=20 > > On Mon, 21 Sep 2020 at 15:59, Maxime Ripard wrote: > > > > > > On Mon, Sep 21, 2020 at 12:27:18PM +0200, Cl=C3=A9ment P=C3=A9ron wro= te: > > > > From: Jernej Skrabec > > > > > > > > Add a simple-soundcard to link audio between HDMI and I2S. > > > > > > > > Signed-off-by: Jernej Skrabec > > > > Signed-off-by: Marcus Cooper > > > > Signed-off-by: Cl=C3=A9ment P=C3=A9ron > > > > --- > > > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 ++++++++++++++++= ++++ > > > > 1 file changed, 33 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/ar= m64/ > boot/dts/allwinner/sun50i-h6.dtsi > > > > index 28c77d6872f6..a8853ee7885a 100644 > > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > > > @@ -67,6 +67,25 @@ de: display-engine { > > > > status =3D "disabled"; > > > > }; > > > > > > > > + hdmi_sound: hdmi-sound { > > > > + compatible =3D "simple-audio-card"; > > > > + simple-audio-card,format =3D "i2s"; > > > > + simple-audio-card,name =3D "sun50i-h6-hdmi"; > > > > + simple-audio-card,mclk-fs =3D <128>; > > > > + simple-audio-card,frame-inversion; > > > > + status =3D "disabled"; > > > > + > > > > + simple-audio-card,codec { > > > > + sound-dai =3D <&hdmi>; > > > > + }; > > > > + > > > > + simple-audio-card,cpu { > > > > + sound-dai =3D <&i2s1>; > > > > + dai-tdm-slot-num =3D <2>; > > > > + dai-tdm-slot-width =3D <32>; > > > > > > It looks weird to have both some TDM setup here, and yet the format in > > > i2s? > >=20 > > Yes, I agree I will check if it's really needed. >=20 > I think this was explained before. Possibly, but this should be in a comment or at least the commit log > Anyway, this is needed to force width to 32, no matter actual sample > width. That's a requirement of HDMI codec. I believe Marcus Cooper > have another codec which also needs fixed width. >=20 > There is no similar property for I2S, so TDM one is used here. Except it's really dedicated to the TDM mode and doesn't really make much sense here. If we have special requirements like this on the codec setup, that sounds like a good justification for creating a custom codec instead of shoehorning it into simple-card Maxime --nywbcxkwq6lidb2p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX3GiHAAKCRDj7w1vZxhR xWJJAP0VYV8qr8oRUJQXa1gO/KEHRiAM2KN5mADU4A/LD48/EwEA0ZjSWx11FGHU uKbSn9mGmvKiACaWrHELDAqBdx6ooA0= =GeNy -----END PGP SIGNATURE----- --nywbcxkwq6lidb2p-- --===============1583916539618155651== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1583916539618155651==--