From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC979C4727E for ; Mon, 28 Sep 2020 14:56:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CA3521974 for ; Mon, 28 Sep 2020 14:56:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VrD6HqqH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CA3521974 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bb4W5USeR76t1AICOYbP9xbTKnGbQ84pI8YGhk3lrAc=; b=VrD6HqqH/ef9Ku/DPdN+FAPe1 DvPfq/OSjXq4Qfcp9kAfUjgUKUvxInpN00iWPu/pGUKE4NSCRm8zoCbgAogTRt1z/YcBUOG3plSes G5/NS4W9k1S/bHa7qjTvV3KEjuWpKpzXUgZc2r5uf6q7sEx23ZyyFRly6GiFykUm6b5zeAAtU8ycu hSN5aa29rblJjvgyFVI/9y9lYPZ7SHVlLVQu/kxg72wXjtJ9FBX+p8z7p1JN9FGkgR1RxykcCVRUE m/r2SSPdq9xHiGxerGOoSNdRbg4Z4liiPGdSEbDLIce7XY5TQMB0PC0tSk4Q45vmq6Ij8gXf7TmGY 9UDebT7wg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMuYX-0001DG-Fv; Mon, 28 Sep 2020 14:55:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMuYU-0001CH-7C for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 14:55:07 +0000 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F03392083B; Mon, 28 Sep 2020 14:55:02 +0000 (UTC) Date: Mon, 28 Sep 2020 10:55:01 -0400 From: Steven Rostedt To: Prasad Sodagudi Subject: Re: [PATCH] tracing: Add register read and write tracing support Message-ID: <20200928105501.7e29df65@oasis.local.home> In-Reply-To: <1601253290-400618-2-git-send-email-psodagud@codeaurora.org> References: <1601253290-400618-1-git-send-email-psodagud@codeaurora.org> <1601253290-400618-2-git-send-email-psodagud@codeaurora.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_105506_405374_58F937C2 X-CRM114-Status: GOOD ( 22.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: saiprakash.ranjan@codeaurora.org, catalin.marinas@arm.com, keescook@chromium.org, arnd@arndb.de, jim.cromie@gmail.com, linux-arm-msm@vger.kernel.org, anton@enomsg.org, linux-kernel@vger.kernel.org, ccross@android.com, joel@joelfernandes.org, jbaron@akamai.com, mingo@redhat.com, gregkh@linuxfoundation.org, joe@perches.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 27 Sep 2020 17:34:50 -0700 Prasad Sodagudi wrote: > Add register read/write operations tracing support. > ftrace events helps trace register read and write > location details of memory mapped IO registers. Also > add _no_log variants the writel_relaxed/readl_relaed > APIs to avoid excessive logging for certain register > operations. As mentioned elsewhere, I don't see a reason for "nolog" variants if it is just to avoid logging too much. You can easily filter on the recording side. > --- /dev/null > +++ b/include/linux/iorw.h > @@ -0,0 +1,20 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * > + */ > +#ifndef __LOG_IORW_H__ > +#define __LOG_IORW_H__ > + > +#include > + > +#if IS_ENABLED(CONFIG_TRACE_RW) > +void log_write_io(volatile void __iomem *addr); > +void log_read_io(const volatile void __iomem *addr); So basically, this is always doing a function call, even when tracing is not enabled. You may want to turn this into a macro, and use the new interface I'm about to push: See https://lore.kernel.org/r/20200925211206.423598568@goodmis.org Although I'm about to push a v3 (found a config that breaks msr.h) #if IS_ENABLED(CONFIG_TRACE_RW) #include #include DECLARE_TRACEPOINT(rwio_write); DECLARE_TRACEPOINT(rwio_read); void __log_write_io(volatile void __iomem *addr); void __log_read_io(const volatile void __iomem *addr); #define log_write_io(addr) \ if (tracepoint_enabled(rwio_write) __log_write_io(addr) #define log_read_io(addr) \ if (tracepoint_enabled(rwio_read) __log_read_io(addr) > +#else > +static inline void log_write_io(volatile void __iomem *addr) > +{ } > +static inline void log_read_io(const volatile void __iomem *addr) > +{ } > +#endif /* CONFIG_TRACE_RW */ > + > +#endif /* __LOG_IORW_H__ */ > diff --git a/include/trace/events/rwio.h b/include/trace/events/rwio.h > new file mode 100644 > index 0000000..b829629 > --- /dev/null > +++ b/include/trace/events/rwio.h > @@ -0,0 +1,51 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM rwio > + > +#if !defined(_TRACE_RWIO_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_RWIO_H > + > +#include > + > +TRACE_EVENT(raw_write, "raw" is too generic. Call this rwio_write. > + > + TP_PROTO(unsigned long fn, volatile void __iomem *addr), > + > + TP_ARGS(fn, addr), > + > + TP_STRUCT__entry( > + __field(u64, fn) > + __field(u64, addr) > + ), > + > + TP_fast_assign( > + __entry->fn = fn; > + __entry->addr = (u64)addr; > + ), > + > + TP_printk("%pS write addr=%p\n", __entry->fn, __entry->addr) > +); > + > +TRACE_EVENT(raw_read, And this "rwio_read" -- Steve > + > + TP_PROTO(unsigned long fn, const volatile void __iomem *addr), > + > + TP_ARGS(fn, addr), > + > + TP_STRUCT__entry( > + __field(u64, fn) > + __field(u64, addr) > + ), > + > + TP_fast_assign( > + __entry->fn = fn; > + __entry->addr = (u64)addr; > + ), > + > + TP_printk("%pS read addr=%p\n", __entry->fn, __entry->addr) > +); > + > +#endif /* _TRACE_PREEMPTIRQ_H */ > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel