From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90850C2D0A8 for ; Mon, 28 Sep 2020 14:25:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1964421D46 for ; Mon, 28 Sep 2020 14:25:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1ndMaOMR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1964421D46 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q8NP56n0NqXmJ7oMowoRSgFUzrQh21MCGcoeHqa6lSE=; b=1ndMaOMR8AoucsI3r6ps+oBoP Zlc81iSKxtyc50cPpWDcBpg9l+xfMCTyYwJNhn0XjqSutOIRi9n5/qKw8Ym6OWGIVJhWPbCEdFxQ4 T00A0+4Rdp/PYLk5Uwiuo5yDXRHllbOsCq6u9XlWBmEkkqxYgTs9t114DVRuSRxwOdFM9Df7gYbof 93MVSrXfZ/DWPbB9s82svwLz2I3IMAz3+8K8WAADx60BTxwSyakZ2r9MMBZo2L5oYSpJNXRvcPeHZ cj1vcppfVQ16h1b2W2A2f/hmZH+12GN/PxqWuZmUZJVKqHNo59DJeYma1VH0F11eoyNBOxEzCrSZC Xz2lA5tfA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMu4A-0002fm-1W; Mon, 28 Sep 2020 14:23:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMu47-0002e2-KA for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 14:23:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 765FD1063; Mon, 28 Sep 2020 07:23:36 -0700 (PDT) Received: from localhost (unknown [10.1.199.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1756D3F73B; Mon, 28 Sep 2020 07:23:35 -0700 (PDT) Date: Mon, 28 Sep 2020 15:23:34 +0100 From: Ionela Voinescu To: Dietmar Eggemann Subject: Re: [PATCH 3/3] arm64: rebuild sched domains on invariance status changes Message-ID: <20200928142334.GA19372@arm.com> References: <20200924123937.20938-1-ionela.voinescu@arm.com> <20200924123937.20938-4-ionela.voinescu@arm.com> <20200924133925.GC3920949@google.com> <20200924161002.GC17927@arm.com> <20200925135900.GA11648@google.com> <626062da-1d0e-3095-dd6f-f909a60a7de3@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <626062da-1d0e-3095-dd6f-f909a60a7de3@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_102343_757636_819F2DE5 X-CRM114-Status: GOOD ( 26.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vincent.guittot@linaro.org, Quentin Perret , peterz@infradead.org, catalin.marinas@arm.com, linux-pm@vger.kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, mingo@redhat.com, viresh.kumar@linaro.org, will@kernel.org, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi guys, On Monday 28 Sep 2020 at 13:55:49 (+0200), Dietmar Eggemann wrote: > On 25/09/2020 15:59, Quentin Perret wrote: > > Hey Ionela, > > > > On Thursday 24 Sep 2020 at 17:10:02 (+0100), Ionela Voinescu wrote: > >> I'm not sure what is a good way of fixing this.. I could add more info > >> to the warning to suggest it might be temporary ("Disabling EAS: > >> frequency-invariant load tracking currently not supported"). For further > >> debugging there are the additional prints guarded by sched_debug(). > >> > >> I'll look over the code some more to see if other ideas pop out. Any > >> suggestions are appreciated. > > > > Right, I'm not seeing anything perfect here, but I think I'd be > > personally happy with this message being entirely guarded by > > sched_debug(), like we do for asym CPU capacities for instance. > > > > It's not easy to see if EAS has started at all w/o sched debug anyway, > > so I expect folks who need it to enable the debug stuff during > > bring-up. With a descriptive enough warn message, that should be just > > fine. But that's my 2p, so I'm happy to hear if others disagree. > > Are you discussing a scenario where the system doesn't have FI via > CPUfreq but only via AMU? And then we would get the pr_warn > > "rd %*pbl: Disabling EAS: frequency-invariant load tracking not > supported" > Yes, that is correct. Unfortunately for !sched_debug, even if we have FI via AMUs, the EAS enablement message "sched_energy_set: starting EAS" won't appear, and therefore one would only see the warnings above, giving the wrong impression that EAS is disabled. > in (1)-(3)? > > (1) initial sd build > (2) update_topology_flags_workfn() > (3) rebuild_sched_domains_energy() > (4) init_amu_fie() > > Today (e.g. on Juno( we start EAS within (1) > > root@juno:~# dmesg | grep "build_perf_domains\|EAS" > [ 3.491304] *** build_perf_domains: rd 0-5 > [ 3.574226] sched_energy_set: starting EAS <--- !!! > [ 3.847584] *** build_perf_domains: rd 0-5 > [ 3.928227] *** build_perf_domains: rd 0-5 > > And on a future AMU FI only system it would look like: > > Disabling EAS: frequency-invariant load tracking not supported" > Disabling EAS: frequency-invariant load tracking not supported" > Disabling EAS: frequency-invariant load tracking not supported" > sched_energy_set: starting EAS > Correct (with the same mention that "sched_energy_set: starting EAS" is guarded by sched debug). > I guess it's a good idea to put all those warnings which indicate why > EAS can't be started under sched_debug(). > > The warning "rd %*pbl: CPUs do not have asymmetric capacities" already > is. This one is actually very similar to the FI related one, since > 'asymmetric capacities' could only exist starting with (2) (big.LITTLE > based entirely on CPUfreq diffs) Yes, this seems the right solution, as suggested by Quentin as well. I'll do this together with the other suggestions and submit v2. Thank you both, Ionela. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel