From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3096CC2D0A8 for ; Mon, 28 Sep 2020 15:31:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C89FC21548 for ; Mon, 28 Sep 2020 15:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jnBWsS/S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C89FC21548 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P+h65jhX/GxsPwfFDIHesi1b3fbefNeHp83KiIpfg68=; b=jnBWsS/SsK+xqU/MaaNXBfUR7 JR1cnGi3tcPLmJWJUGl1sVmb1qUJJOhEZoQZx5tnTxHRxXdyfel24V6I0DDubU1n3orqwqucv0MsI 9gm3dUuCLQhfNEqDl2p247I2mfc81KrHQ4RWVCenC12Ru1jB9fGGIqdIUQyfNUMK+OqtCOTZ3AMnk O/Z4bAQh4kuCIGJmeUnNCFkY1TjX33jxMgl++b6kEbRvF3CkStyoft/RtRfpglKlKPgszl2pGbJlK KqzDTuaTYP9mtTIb6GA4RA9rBk1yVYkTuAa7/nu8ox2nQxZYAhgE5jdE8g7mEAVrFQnlYOtYFrdU9 2WYsV9ilQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMv6L-0003vG-TJ; Mon, 28 Sep 2020 15:30:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMv6I-0003tg-Oo for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 15:30:03 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3F8931B; Mon, 28 Sep 2020 08:30:01 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.46.178]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 954783F70D; Mon, 28 Sep 2020 08:30:00 -0700 (PDT) Date: Mon, 28 Sep 2020 16:29:58 +0100 From: Mark Rutland To: Christoph Hellwig Subject: Re: [PATCH 11/13] arm64: uaccess: remove set_fs() Message-ID: <20200928152958.GD30613@C02TD0UTHF1T.local> References: <20200925160722.27155-1-mark.rutland@arm.com> <20200925160722.27155-12-mark.rutland@arm.com> <20200928070443.GA15967@lst.de> <20200928090218.GA30613@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200928090218.GA30613@C02TD0UTHF1T.local> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_113002_906127_F8029D02 X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 28, 2020 at 10:02:28AM +0100, Mark Rutland wrote: > On Mon, Sep 28, 2020 at 09:04:43AM +0200, Christoph Hellwig wrote: > > > +static inline void init_hw_uaccess_state(void) > > > { > > > + asm(ALTERNATIVE("nop", SET_PSTATE_PAN(1), ARM64_HAS_PAN)); > > > + asm(ALTERNATIVE("nop", SET_PSTATE_UAO(0), ARM64_HAS_UAO)); > > > } > > > > The way I read this code it is about per-task state, maybe that > > could be reflected in the name? init_task_hw_access_state or > > init_task_uaccess_flags? > > My intent writing this was that this resets the HW into the expected > ambient state common to all tasks, so I don't think about this as a > per-task thing (but I agree the transient PAN toggling for atomics means > PAN is per-task state). > > I'd prefer not to put 'task' in the name as to me that implies messing > with something like task_struct or other SW state, but if you have > strong feeling about this, I think something like > init_task_hw_access_state() would be fine. Luckily this disappeared entirely as part of removing the vestigal UAO support, so no need to debate the name. ;) Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel