linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: bcm2835: Change firmware compatible from simple-bus to simple-mfd
@ 2020-09-24  8:26 Maxime Ripard
  2020-09-28 16:19 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Maxime Ripard @ 2020-09-24  8:26 UTC (permalink / raw)
  To: Mark Rutland, Rob Herring, Frank Rowand, Florian Fainelli,
	Nicolas Saenz Julienne, Ray Jui, Scott Branden
  Cc: devicetree, Maxime Ripard, Eric Anholt, bcm-kernel-feedback-list,
	linux-rpi-kernel, linux-arm-kernel, Stefan Wahren

The current binding for the RPi firmware uses the simple-bus compatible as
a fallback to benefit from its automatic probing of child nodes.

However, simple-bus also comes with some constraints, like having the ranges,
our case.

Let's switch to simple-mfd that provides the same probing logic without
those constraints.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml        | 4 ++--
 arch/arm/boot/dts/bcm2835-rpi.dtsi                            | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
index 17e4f20c8d39..6834f5e8df5f 100644
--- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
@@ -23,7 +23,7 @@ properties:
   compatible:
     items:
       - const: raspberrypi,bcm2835-firmware
-      - const: simple-bus
+      - const: simple-mfd
 
   mboxes:
     $ref: '/schemas/types.yaml#/definitions/phandle'
@@ -57,7 +57,7 @@ required:
 examples:
   - |
     firmware {
-        compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
+        compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
         mboxes = <&mailbox>;
 
         firmware_clocks: clocks {
diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index f7ae5a4530b8..d94357b21f7e 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -13,7 +13,7 @@ act {
 
 	soc {
 		firmware: firmware {
-			compatible = "raspberrypi,bcm2835-firmware", "simple-bus";
+			compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
 			#address-cells = <1>;
 			#size-cells = <1>;
 
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: bcm2835: Change firmware compatible from simple-bus to simple-mfd
  2020-09-24  8:26 [PATCH] ARM: dts: bcm2835: Change firmware compatible from simple-bus to simple-mfd Maxime Ripard
@ 2020-09-28 16:19 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-09-28 16:19 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: linux-arm-kernel, devicetree, Florian Fainelli, Scott Branden,
	Ray Jui, Eric Anholt, Rob Herring, bcm-kernel-feedback-list,
	Stefan Wahren, Mark Rutland, Frank Rowand, Nicolas Saenz Julienne,
	linux-rpi-kernel

On Thu, 24 Sep 2020 10:26:42 +0200, Maxime Ripard wrote:
> The current binding for the RPi firmware uses the simple-bus compatible as
> a fallback to benefit from its automatic probing of child nodes.
> 
> However, simple-bus also comes with some constraints, like having the ranges,
> our case.
> 
> Let's switch to simple-mfd that provides the same probing logic without
> those constraints.
> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---
>  .../bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml        | 4 ++--
>  arch/arm/boot/dts/bcm2835-rpi.dtsi                            | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-28 16:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-24  8:26 [PATCH] ARM: dts: bcm2835: Change firmware compatible from simple-bus to simple-mfd Maxime Ripard
2020-09-28 16:19 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).