Re: [PATCH v11 2/6] x86: Support Generic Initiator only proximity domains

Borislav Petkov
2020-09-28T17:36:49Z

On Mon, Sep 28, 2020 at 08:52:31PM +0800, Jonathan Cameron wrote:
> In common with memoryless domains we only register GI domains
^^^^

> if the proximity node is not online. If a domain is already
> a memory containing domain, or a memoryless domain there is
> nothing to do just because it also contains a Generic Initiator.

...

> +/*
> + * A node may exist which has one or more Generic Initiators but no CPUs and no
> + * memory.
> + *
> + * This function must be called after init_cpu_to_node() to ensure that we have
^^^

You love that "we". :)

Pls use passive voice in your commit message: no "we" or "I", etc, and
describe your changes in imperative mood.

Also, pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst for more details.

Bottom line is: personal pronouns are ambiguous in text, especially with
so many parties/companies/etc developing the kernel so let's avoid them
please.

Thx.

--
Regards/Gruss,
Boris.