From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01409C2D0A8 for ; Mon, 28 Sep 2020 18:49:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97D65207D8 for ; Mon, 28 Sep 2020 18:49:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BwMI/Aa2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eebkfwy/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97D65207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8pQ0LtMWeVBWuYSAPm/aqKbdqwEZX2sa7Sn+y7Drz0U=; b=BwMI/Aa2YJPEdFynTwn6wzlQh wNSr7JwoV/XJWnk6+03isyTAbDZrhf16ZgqCgBLb3Pch7ClfU5Com2TlA3VlEkM86i3IxcK4ypvSb wv4si82W3yIvDUzHv7G/UDLTf/TuPeaBWZ6EQzuFevep17EMjkgLPXZf3D9FrZ7rK7A9RUKlXO+kk Kp4XzbSf4ceMV9pgSLAgCqJw4ffTajFk3bdCB80LvtAgyPEnKdSdu1EI0oFj1LIeP1Fe8Vx5Oah+9 gYL3Jb1Vja9p3GQioVeHIX+kSOJgv/Zayc+tmUonE9AMZYzleL13euuhwCl7UkiASptsr0fm/uY/O 6BH3bEAGw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMyBp-0001H6-JB; Mon, 28 Sep 2020 18:47:57 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMyBm-0001G7-Sb for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 18:47:55 +0000 Received: by mail-oi1-x243.google.com with SMTP id i17so2459894oig.10 for ; Mon, 28 Sep 2020 11:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Uy1ZmYHkl5eezp3nevvQWT2UA23xSL/opYDEOBgpQN4=; b=eebkfwy/dDOX0Rlv25j+42kAS2Fi3j9bnitcRWet2Q5aW4J0uPRStucw8vUZ+l1zhW qtAYTHeCR2WWqA8W0R2mxMH8YdD0flqCTWeIb7TbB3tyqGCFhshVpcAnbhnpkGii+VSK NK17NmX1ISzNHNyv/6PG2sbJIz47qtgeIuFtOHIKaCxfMYL9ZEYu+h4+rCepY6ZtWFJh K6mzA2mJdTEZ+sdOYYU+kg4/mwJRtCEJCnw3VLOpR4qkl7sjRJGgHBh/fRQvijcIfxao asCPBVfSI6WIr6WMl+AJlnuV7tsmhO0gb4QYg81SHgzjR5VYsVVayvLziizLAXUpFOql Iyyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Uy1ZmYHkl5eezp3nevvQWT2UA23xSL/opYDEOBgpQN4=; b=N9OcYG+AIYQrJli5hhZ9qvHmufCohi8QtFAhlOMaj0hdOBJqRrEnCU2EIrDZD+qh2h CgGqi3mk0rJle5GgGwhLrFi+YJrHgXK1yi+k45VxwLKcvDY0aD7WsRznV0u3NtKT/v7A uO+HWSytvsR5ewr5EOfOCZADyZNuCV617sTtLC1OhhrbucOTnBCfXa3lRwDNT9ed0xyz SwXS0qXlxZea66+QzwPqGodQjkHKu+WWja34sOF5lRGUxMEVfVNiNgMF8TodmKRcvMx7 GZIl5ZpjyuMZ2CkVgViocIo1FAOScqpdbYWkudjIaNuqaxrs0wcZcHwUynij3h0Ijkrx Pv5w== X-Gm-Message-State: AOAM532lBA5NBL9iFOhYSUodwvMceNZYCA4sboywpCk9V4NnMS8XlW+a lw0W73AY+UDisIt1XyXGBbVHeA== X-Google-Smtp-Source: ABdhPJwS2D9oyta/Wy8WhjS8IjtuM1KLnjkUekELwNKURqSpX6PjLMnZB91s0nj853RAVk6BSh+ghA== X-Received: by 2002:aca:ac8e:: with SMTP id v136mr151341oie.113.1601318871887; Mon, 28 Sep 2020 11:47:51 -0700 (PDT) Received: from builder.lan (99-135-181-32.lightspeed.austtx.sbcglobal.net. [99.135.181.32]) by smtp.gmail.com with ESMTPSA id a2sm2270797ooo.26.2020.09.28.11.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2020 11:47:51 -0700 (PDT) Date: Mon, 28 Sep 2020 13:43:22 -0500 From: Bjorn Andersson To: Varadarajan Narayanan Subject: Re: [PATCH 5/7] pinctrl: qcom: Add IPQ5018 pinctrl driver Message-ID: <20200928184322.GB71055@builder.lan> References: <1601270140-4306-1-git-send-email-varada@codeaurora.org> <1601270140-4306-6-git-send-email-varada@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1601270140-4306-6-git-send-email-varada@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_144754_935537_C6956BF2 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, nsekar@codeaurora.org, sboyd@kernel.org, catalin.marinas@arm.com, mturquette@baylibre.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, agross@kernel.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, sricharan@codeaurora.org, will@kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 28 Sep 00:15 CDT 2020, Varadarajan Narayanan wrote: > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c [..] > +static const struct msm_function ipq5018_functions[] = { [..] > + FUNCTION(qspi_clk), > + FUNCTION(qspi_cs), > + FUNCTION(qspi0), > + FUNCTION(qspi1), > + FUNCTION(qspi2), > + FUNCTION(qspi3), Instead of having one function name per pin it typically leads to cleaner DT if you group these under the same name (i.e. "qspi") Same seems to apply to sdc, wci, xfem at least. > + FUNCTION(reset_out), > + FUNCTION(sdc1_clk), > + FUNCTION(sdc1_cmd), > + FUNCTION(sdc10), > + FUNCTION(sdc11), > + FUNCTION(sdc12), > + FUNCTION(sdc13), > + FUNCTION(wci0), > + FUNCTION(wci1), > + FUNCTION(wci2), > + FUNCTION(wci3), > + FUNCTION(wci4), > + FUNCTION(wci5), > + FUNCTION(wci6), > + FUNCTION(wci7), > + FUNCTION(wsa_swrm), > + FUNCTION(wsi_clk3), > + FUNCTION(wsi_data3), > + FUNCTION(wsis_reset), > + FUNCTION(xfem0), > + FUNCTION(xfem1), > + FUNCTION(xfem2), > + FUNCTION(xfem3), > + FUNCTION(xfem4), > + FUNCTION(xfem5), > + FUNCTION(xfem6), > + FUNCTION(xfem7), > +}; > +static const struct msm_pingroup ipq5018_groups[] = { > + PINGROUP(0, atest_char0, _, qdss_cti_trig_out_a0, wci0, wci0, xfem0, What's up with wci0 being both function 4 and 5? > + _, _, _), > + PINGROUP(1, atest_char1, _, qdss_cti_trig_in_a0, wci1, wci1, xfem1, > + _, _, _), Please don't like break these, better blow the line length limit in favor or readability. > + PINGROUP(2, atest_char2, _, qdss_cti_trig_out_a1, wci2, wci2, xfem2, > + _, _, _), > + PINGROUP(3, atest_char3, _, qdss_cti_trig_in_a1, wci3, wci3, xfem3, > + _, _, _), Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel