From: Will Deacon <will@kernel.org>
To: Sumit Garg <sumit.garg@linaro.org>, alexandru.elisei@arm.com
Cc: mark.rutland@arm.com, daniel.thompson@linaro.org,
linux-kernel@vger.kernel.org, peterz@infradead.org,
catalin.marinas@arm.com, alexandru.elisei@arm.com,
dianders@chromium.org, acme@kernel.org, swboyd@chromium.org,
alexander.shishkin@linux.intel.com, mingo@redhat.com,
julien.thierry.kdev@gmail.com, namhyung@kernel.org,
tglx@linutronix.de, jolsa@redhat.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] arm64: Enable perf events based hard lockup detector
Date: Mon, 28 Sep 2020 22:56:23 +0100 [thread overview]
Message-ID: <20200928215622.GA12677@willie-the-truck> (raw)
In-Reply-To: <1599204397-17596-1-git-send-email-sumit.garg@linaro.org>
On Fri, Sep 04, 2020 at 12:56:37PM +0530, Sumit Garg wrote:
> With the recent feature added to enable perf events to use pseudo NMIs
> as interrupts on platforms which support GICv3 or later, its now been
> possible to enable hard lockup detector (or NMI watchdog) on arm64
> platforms. So enable corresponding support.
>
> One thing to note here is that normally lockup detector is initialized
> just after the early initcalls but PMU on arm64 comes up much later as
> device_initcall(). So we need to re-initialize lockup detection once
> PMU has been initialized.
>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
>
> Changes in v3:
> - Rebased to latest pmu NMI patch-set [1].
> - Addressed misc. comments from Stephen.
>
> [1] https://lkml.org/lkml/2020/8/19/671
>
> Changes since RFC:
> - Rebased on top of Alex's WIP-pmu-nmi branch.
> - Add comment for safe max. CPU frequency.
> - Misc. cleanup.
>
> arch/arm64/Kconfig | 2 ++
> arch/arm64/kernel/perf_event.c | 41 +++++++++++++++++++++++++++++++++++++++--
> drivers/perf/arm_pmu.c | 9 +++++++++
> include/linux/perf/arm_pmu.h | 2 ++
> 4 files changed, 52 insertions(+), 2 deletions(-)
It would be great to have Alexandru's ack on this, since it builds directly
on top of his code.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-28 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 7:26 [PATCH v3] arm64: Enable perf events based hard lockup detector Sumit Garg
2020-09-28 21:56 ` Will Deacon [this message]
2020-09-30 13:04 ` Alexandru Elisei
2020-10-01 10:08 ` Sumit Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200928215622.GA12677@willie-the-truck \
--to=will@kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jolsa@redhat.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=sumit.garg@linaro.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox