From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069EFC4346E for ; Tue, 29 Sep 2020 08:06:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5917F2075F for ; Tue, 29 Sep 2020 08:06:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lTFoONPe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="CmNpGbvA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5917F2075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UXPzjWczwtgGAANx3OdR1v6OJX+fhRjVMfiK2SCwq/s=; b=lTFoONPewposnju+pvNCcpRD4 V10AXefh5Bm+05reaTWnNcgUXTrh94QhqKxUMwNR4id4ay2h/eb4tDhnZRt1taYNEOiPWHnDqO3be tWGmIOCG53S0E8o/chlVEXPonELt4/S7iPRLp/rmpi+j+GJja30qkZhUNmQk4sqsr4oTgqQjbcgT9 huWelaGoN2jjX81nWAKJqvvS2NqTlVwFeZ19Zn/3u3XYApMe+/LP5LU66LT6NYvT7jGH1/uGspIas ZI7Ve1kLq8FaIlp0bQBMr2//7aSIGJoY9YTnl5fBHTeZ9GhMhmDprI5oLjAEd+LILpd98cfWcgp9d RTgHqKogQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNAdU-0006yO-FZ; Tue, 29 Sep 2020 08:05:20 +0000 Received: from m42-4.mailgun.net ([69.72.42.4]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNAdJ-0006wP-MJ for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 08:05:14 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601366713; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=r+8Y1/iTY5V2CVTSF4MuhfKKHmbWKG8EGomgri5/hVc=; b=CmNpGbvA3UeJEJzxk3ZLl94dfggB20pLYqq09mymYNMCBMazmtOGiF7mvHAWiGowRE+PHcNM ily7hn/eHsCR9ULPbFwrCf7wz0PIIWISlczxsFbg7DxuXPXQrlHW5DNl1T09bXLX/xHXeGmu kr6os8FQwIJkTcjRZKmG0jPvuWI= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 5f72ea9570602555f5035d0d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 29 Sep 2020 08:04:37 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6FCB3C43385; Tue, 29 Sep 2020 08:04:36 +0000 (UTC) Received: from codeaurora.org (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: varada) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2D953C433CA; Tue, 29 Sep 2020 08:04:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2D953C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=varada@codeaurora.org Date: Tue, 29 Sep 2020 13:34:26 +0530 From: Varadarajan Narayanan To: Bjorn Andersson Subject: Re: [PATCH 5/7] pinctrl: qcom: Add IPQ5018 pinctrl driver Message-ID: <20200929080425.GA21805@codeaurora.org> References: <1601270140-4306-1-git-send-email-varada@codeaurora.org> <1601270140-4306-6-git-send-email-varada@codeaurora.org> <20200928184322.GB71055@builder.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200928184322.GB71055@builder.lan> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_040513_767528_503838CC X-CRM114-Status: GOOD ( 17.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, nsekar@codeaurora.org, sboyd@kernel.org, catalin.marinas@arm.com, mturquette@baylibre.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, agross@kernel.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, sricharan@codeaurora.org, will@kernel.org, linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 28, 2020 at 01:43:22PM -0500, Bjorn Andersson wrote: > On Mon 28 Sep 00:15 CDT 2020, Varadarajan Narayanan wrote: > > diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c > [..] > > +static const struct msm_function ipq5018_functions[] = { > [..] > > + FUNCTION(qspi_clk), > > + FUNCTION(qspi_cs), > > + FUNCTION(qspi0), > > + FUNCTION(qspi1), > > + FUNCTION(qspi2), > > + FUNCTION(qspi3), > > Instead of having one function name per pin it typically leads to > cleaner DT if you group these under the same name (i.e. "qspi") Ok. > Same seems to apply to sdc, wci, xfem at least. > > > + FUNCTION(reset_out), > > + FUNCTION(sdc1_clk), > > + FUNCTION(sdc1_cmd), > > + FUNCTION(sdc10), > > + FUNCTION(sdc11), > > + FUNCTION(sdc12), > > + FUNCTION(sdc13), > > + FUNCTION(wci0), > > + FUNCTION(wci1), > > + FUNCTION(wci2), > > + FUNCTION(wci3), > > + FUNCTION(wci4), > > + FUNCTION(wci5), > > + FUNCTION(wci6), > > + FUNCTION(wci7), > > + FUNCTION(wsa_swrm), > > + FUNCTION(wsi_clk3), > > + FUNCTION(wsi_data3), > > + FUNCTION(wsis_reset), > > + FUNCTION(xfem0), > > + FUNCTION(xfem1), > > + FUNCTION(xfem2), > > + FUNCTION(xfem3), > > + FUNCTION(xfem4), > > + FUNCTION(xfem5), > > + FUNCTION(xfem6), > > + FUNCTION(xfem7), > > +}; Ok. > > +static const struct msm_pingroup ipq5018_groups[] = { > > + PINGROUP(0, atest_char0, _, qdss_cti_trig_out_a0, wci0, wci0, xfem0, > > What's up with wci0 being both function 4 and 5? Will check this. > > + _, _, _), > > + PINGROUP(1, atest_char1, _, qdss_cti_trig_in_a0, wci1, wci1, xfem1, > > + _, _, _), > > Please don't like break these, better blow the line length limit in > favor or readability. > > > + PINGROUP(2, atest_char2, _, qdss_cti_trig_out_a1, wci2, wci2, xfem2, > > + _, _, _), > > + PINGROUP(3, atest_char3, _, qdss_cti_trig_in_a1, wci3, wci3, xfem3, > > + _, _, _), Ok. > Regards, > Bjorn Will post updated patches soon. Thanks Varada -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel