From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937B2C47420 for ; Tue, 29 Sep 2020 18:37:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 194D52074A for ; Tue, 29 Sep 2020 18:37:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hHHxL01C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 194D52074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UHMoTwXYvO8+Ic6LccvnEx4v09t2BgU72HXcrGvCCt8=; b=hHHxL01Cr/X6zHG4BymU0gpQc iCMa+mv4MJyWYE7aeSewNA7yO5uwtaHbV5csOJ+/Mn+2jANlUUWS/Lko+XPIXBStl9fs8rMjUvCmI +lH9P+/Z16ZI0s9NgdTHJy8GrTOYi4iulZSBwdcDuf+yI7g7AcfVkQRnGsz3/e3poQ6Vm6duqvWZp bjFcLwY29ILifPBfexm0b3wYyygI+SnQuIpg28Co+7JtDtkFuTYQFtGMFYOQFn70TzC2ptGqnf0jj MakF1/sIiUZ4n5ycnCldAhVlw63MWHHZgAhZhP1oPkoQws7Zi6dS8vGMkafojdCqjpFu1oHfCWH7f l188N6dhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNKTx-0005Vr-FH; Tue, 29 Sep 2020 18:36:09 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNKTs-0005T6-4o for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 18:36:06 +0000 Received: by mail-ot1-f68.google.com with SMTP id m12so5478193otr.0 for ; Tue, 29 Sep 2020 11:36:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IlSkqdphqKTO009g0fq1K14KI/lnuHp40ufCtsxgDoU=; b=hf1Ml82rta0rhCxqL6C1DIDWhYZs0xGuQAPet9RSCTD+eDimAZWmP6aeGpO7tSm5aQ wIynK7ILefnvm2CHsTD0XdvW3iJBxJwsDlWwQ4vY69ddmux/b0fSGkmM29720wyEo/gT frNjkg29IQqE8xJfmQ1u2rJ/gdtlhBmgMxgM7D2nyNnJOa5n0kVJ/7xoXZvVGMwm4ZVr MaZge1VXyndpgpcYMFEZjkJEyLyAErJtSxi//iWfmli0273g2EfSlUZyL+Rx9yAh+ceK LbFINSjTPF/ZRSlswYbn/u7gJZPMY+OpD/22RDmMgz9X+qmVsXD6DrUjHXqduVEcwHzB PTEQ== X-Gm-Message-State: AOAM532qZiy3t0BntxeudwCQN/N9vExgggvkdC46UyegxkLRSGBf7tbi pyMZUI+87/4Lj+Nd9lP7q72wSiuAUZtI X-Google-Smtp-Source: ABdhPJwCAWMgESySEtLvlkXxZ5yrYSY7bUzq09eQIT1AyxZwXp1XoWNRQ5Gm5RAiEdzvVCRYVIv+IQ== X-Received: by 2002:a9d:77d3:: with SMTP id w19mr3789573otl.44.1601404563208; Tue, 29 Sep 2020 11:36:03 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id i205sm1172128oih.23.2020.09.29.11.36.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 11:36:02 -0700 (PDT) Received: (nullmailer pid 926876 invoked by uid 1000); Tue, 29 Sep 2020 18:36:01 -0000 Date: Tue, 29 Sep 2020 13:36:01 -0500 From: Rob Herring To: Ben Levinsky Subject: Re: [PATCH v16 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Message-ID: <20200929183601.GA892636@bogus> References: <20200922223930.4710-1-ben.levinsky@xilinx.com> <20200922223930.4710-5-ben.levinsky@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200922223930.4710-5-ben.levinsky@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_143604_244102_1ECD7461 X-CRM114-Status: GOOD ( 31.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanos@xilinx.com, emooring@xilinx.com, michael.auchter@ni.com, mathieu.poirier@linaro.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Wendy Liang , michals@xilinx.com, Jason Wu , Michal Simek , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 22, 2020 at 03:39:29PM -0700, Ben Levinsky wrote: > Add binding for ZynqMP R5 OpenAMP. > > Represent the RPU domain resources in one device node. Each RPU > processor is a subnode of the top RPU domain node. > > Signed-off-by: Jason Wu > Signed-off-by: Wendy Liang > Signed-off-by: Michal Simek > Signed-off-by: Ben Levinsky > --- > v3: > - update zynqmp_r5 yaml parsing to not raise warnings for extra > information in children of R5 node. The warning "node has a unit > name, but no reg or ranges property" will still be raised though > as this particular node is needed to describe the > '#address-cells' and '#size-cells' information. > v4:: > - remove warning '/example-0/rpu@ff9a0000/r5@0: > node has a unit name, but no reg or ranges property' > by adding reg to r5 node. > v5: > - update device tree sample and yaml parsing to not raise any warnings > - description for memory-region in yaml parsing > - compatible string in yaml parsing for TCM > v6: > - remove coupling TCM nodes with remoteproc > - remove mailbox as it is optional not needed > v7: > - change lockstep-mode to xlnx,cluster-mode > v9: > - show example IPC nodes and tcm bank nodes > v11: > - add property meta-memory-regions to illustrate link > between r5 and TCM banks > - update so no warnings from 'make dt_binding_check' > v14: > - concerns were raised about the new property meta-memory-regions. > There is no clear direction so for the moment I kept it in the series > - place IPC nodes in RAM in the reserved memory section > v15: > - change lockstep-mode prop as follows: if present, then RPU cluster is in > lockstep mode. if not present, cluster is in split mode. > --- > .../xilinx,zynqmp-r5-remoteproc.yaml | 120 ++++++++++++++++++ > 1 file changed, 120 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml b/Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml > new file mode 100644 > index 000000000000..ce02e425692e > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml > @@ -0,0 +1,120 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/remoteproc/xilinx,zynqmp-r5-remoteproc.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Xilinx R5 remote processor controller bindings > + > +description: > + This document defines the binding for the remoteproc component that loads and > + boots firmwares on the Xilinx Zynqmp and Versal family chipset. > + > + Note that the Linux has global addressing view of the R5-related memory (TCM) > + so the absolute address ranges are provided in TCM reg's. blank line needed. TCMs specifically I'm concerned about how they are represented in system DT and here... > +maintainers: > + - Ed Mooring > + - Ben Levinsky > + > +properties: > + compatible: > + const: "xlnx,zynqmp-r5-remoteproc-1.0" Don't need quotes. The use of version numbers was allowed for Xilinx programmable IP. I don't think this falls into that category. > + > + lockstep-mode: > + description: > + If this property is present, then the configuration is lock-step. boolean... > + Otherwise RPU is split. > + maxItems: 1 ...or an array? Either way, doesn't work for TI R5. > + > + interrupts: > + description: > + Interrupt mapping for remoteproc IPI. It is required if the > + user uses the remoteproc driver with the RPMsg kernel driver. > + maxItems: 6 > + > + memory-region: > + description: > + collection of memory carveouts used for elf-loading and inter-processor > + communication. > + maxItems: 4 > + minItems: 4 Need to define what each region is. One blank line between properties. > + meta-memory-regions: > + description: > + collection of memories that are not present in the top level memory > + nodes' mapping. For example, R5s' TCM banks. These banks are needed > + for R5 firmware meta data such as the R5 firmware's heap and stack Humm, needs a better explanation. > + pnode-id: > + maxItems: 1 What's this? > + mboxes: > + maxItems: 2 Need to define what each one is. > + mbox-names: > + maxItems: 2 Need to define the names. > + > +examples: > + - | > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + elf_load: rproc@3ed000000 { > + no-map; > + reg = <0x3ed00000 0x40000>; > + }; > + > + rpu0vdev0vring0: rpu0vdev0vring0@3ed40000 { > + no-map; > + reg = <0x3ed40000 0x4000>; > + }; > + rpu0vdev0vring1: rpu0vdev0vring1@3ed44000 { > + no-map; > + reg = <0x3ed44000 0x4000>; > + }; > + rpu0vdev0buffer: rpu0vdev0buffer@3ed48000 { > + no-map; > + reg = <0x3ed48000 0x100000>; > + }; > + > + }; > + > + /* > + * Below nodes are required if using TCM to load R5 firmware > + * if not, then either do not provide nodes are label as disabled in > + * status property > + */ > + tcm0a: tcm_0a@ffe00000 { > + reg = <0xffe00000 0x10000>; > + pnode-id = <0xf>; > + no-map; > + status = "okay"; > + phandle = <0x40>; > + compatible = "xlnx,tcm"; TCM is a Xilinx specific thing? > + }; > + tcm0b: tcm_1a@ffe20000 { > + reg = <0xffe20000 0x10000>; > + pnode-id = <0x10>; > + no-map; > + status = "okay"; > + compatible = "xlnx,tcm"; > + phandle = <0x41>; > + }; > + > + rpu { > + compatible = "xlnx,zynqmp-r5-remoteproc-1.0"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + lockstep-mode; > + r5_0 { > + ranges; > + #address-cells = <1>; > + #size-cells = <1>; > + memory-region = <&elf_load>, > + <&rpu0vdev0vring0>, > + <&rpu0vdev0vring1>, > + <&rpu0vdev0buffer>; > + meta-memory-regions = <&tcm_0a>, <&tcm_0b>; > + pnode-id = <0x7>; > + }; > + }; > + > +... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel