From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62A84C4727F for ; Wed, 30 Sep 2020 13:04:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C15E320709 for ; Wed, 30 Sep 2020 13:04:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CAE8HkUn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C15E320709 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ofzyT+ETfzpwcaRm1O05Nosw7r7LYP6LTmdp68VlglI=; b=CAE8HkUnWCrB02mO7qMnsGnrD 6H0yemOPOU3atCJKiUOOunuJ0VMOLeMlblU/H9KLvA1z6RZ7qGoxv+yOctnQyGDmTVN7wEiNopvA7 yyjU/N+YGh0CAlTL91xhebnZ3jI4kWRgbXBoP+3SM+fYk7wpWAHmuKiTy11BRH5r/zDKpJU4iSxAm WTC3WvVMWSucoePJyOMekTcyx7sKUVsJ4kzx6fYFIwMyYH6OVgDREinRBNYDi95SOKrRDkhNSDf7P X47nwZZkt7k3FEScaERDOx3Ldozx5XQfMTMIFWmX79yUtEuEEBQLVoY5M53xOeVzSWQzMqUoZIsGR dwBCsJZIA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNbl7-0005WI-1d; Wed, 30 Sep 2020 13:03:01 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNbl4-0005Vd-DU for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 13:02:59 +0000 X-Originating-IP: 90.65.88.165 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 167E01C000B; Wed, 30 Sep 2020 13:02:54 +0000 (UTC) Date: Wed, 30 Sep 2020 15:02:54 +0200 From: Alexandre Belloni To: Alexandru Ardelean Subject: Re: [PATCH v3 3/4] iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove of_match_ptr() Message-ID: <20200930130254.GG2804081@piout.net> References: <20200930125216.90424-1-alexandru.ardelean@analog.com> <20200930125216.90424-4-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930125216.90424-4-alexandru.ardelean@analog.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_090258_553124_F038E2ED X-CRM114-Status: GOOD ( 23.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org, jic23@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/09/2020 15:52:15+0300, Alexandru Ardelean wrote: > This tries to solve a warning reported by the lkp bot: > > >> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable > >> 'at91_adc_dt_ids' [-Wunused-const-variable] > static const struct of_device_id at91_adc_dt_ids[] = { > ^ > 1 warning generated. > > This warning has appeared after the AT91_ADC driver compilation has been > enabled via the COMPILE_TEST symbol dependency. > > The warning is caused by the 'of_match_ptr()' helper which returns NULL if > OF is undefined. This driver should build only for device-tree context, so > a dependency on the OF Kconfig symbol has been added. > Also, the usage of of_match_ptr() helper has been removed since it > shouldn't ever return NULL (because the driver should not be built for the > non-OF context). > > Fixes: 4027860dcc4c ("iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver") > Reported-by: kernel test robot > Signed-off-by: Alexandru Ardelean Reviewed-by: Alexandre Belloni > --- > drivers/iio/adc/Kconfig | 2 +- > drivers/iio/adc/at91_adc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 91ae90514aff..17e9ceb9c6c4 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -295,7 +295,7 @@ config ASPEED_ADC > config AT91_ADC > tristate "Atmel AT91 ADC" > depends on ARCH_AT91 || COMPILE_TEST > - depends on INPUT && SYSFS > + depends on INPUT && SYSFS && OF > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 7d846a2852a5..473bffe84fbd 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > .id_table = at91_adc_ids, > .driver = { > .name = DRIVER_NAME, > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > + .of_match_table = at91_adc_dt_ids, > .pm = &at91_adc_pm_ops, > }, > }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel