From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE14C4727E for ; Wed, 30 Sep 2020 13:09:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70AFA2075F for ; Wed, 30 Sep 2020 13:09:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sSFIk3Rk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70AFA2075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DgZYIPvJTyrT5/7yUVwOuOUy30KFiAOo6FwhfMfWk6g=; b=sSFIk3RkCJRkp0yJEVYlA8qC5 qZ6myoaqhDWEXVbJJLR8iqh/xXug4NHqZZHUYbMrcMsnIHTpBWsM5jCP2mCU7gvVGTTqPMX2/9Yk+ gS6cHZSYCHxboDnNWP/IT6oy6ENZ1r573uS6UuUN+L42+vC6d9JdI30L6he+MYBbNY94kucwZJEnl 3leozVJ8gZyeuxOlcFcWWOxthx/cpIzbYLFaQwKT8pFs8Plg3WPyXEV167e/HSvUGCm73ummt/2XP VhZZJt/QvDeA2+jRQINRob/Laz6W49xDQ6puM4tpVdomiiZlolxbBh1SnjDlq/ahL/a2tpLdb5O/K sbMmVdIaQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNbpj-0006Zr-58; Wed, 30 Sep 2020 13:07:47 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNbpf-0006YH-R9 for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 13:07:45 +0000 X-Originating-IP: 90.65.88.165 Received: from localhost (lfbn-lyo-1-1908-165.w90-65.abo.wanadoo.fr [90.65.88.165]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 6470224001C; Wed, 30 Sep 2020 13:07:38 +0000 (UTC) Date: Wed, 30 Sep 2020 15:07:37 +0200 From: Alexandre Belloni To: Alexandru Ardelean Subject: Re: [PATCH v3 4/4] iio: adc: at91_adc: remove platform data and move defs in driver file Message-ID: <20200930130737.GH2804081@piout.net> References: <20200930125216.90424-1-alexandru.ardelean@analog.com> <20200930125216.90424-5-alexandru.ardelean@analog.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930125216.90424-5-alexandru.ardelean@analog.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_090744_092439_19167289 X-CRM114-Status: GOOD ( 30.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org, jic23@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/09/2020 15:52:16+0300, Alexandru Ardelean wrote: > The AT91 ADC driver no longer uses the 'at91_add_device_adc' platform data > type. This is no longer used (at least in mainline drivers). s/drivers/boards/ > > This change removes the platform-data initialization from the driver, since > it is mostly dead code now. It is definitively dead code, it has been a while that board file support has been removed for the platforms with this ADC. > > Some definitions [from the platform data at91_adc.h include] have been to > be moved in the driver, since they are needed in the driver. s/to be// > > Signed-off-by: Alexandru Ardelean > --- > drivers/iio/adc/at91_adc.c | 51 ++++++++++---------------- > include/linux/platform_data/at91_adc.h | 49 ------------------------- > 2 files changed, 20 insertions(+), 80 deletions(-) > delete mode 100644 include/linux/platform_data/at91_adc.h > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 473bffe84fbd..d0e56b1b5949 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -22,8 +22,6 @@ > #include > #include > > -#include > - > #include > #include > #include > @@ -153,6 +151,25 @@ > #define TOUCH_SHTIM 0xa > #define TOUCH_SCTIM_US 10 /* 10us for the Touchscreen Switches Closure Time */ > > +enum atmel_adc_ts_type { > + ATMEL_ADC_TOUCHSCREEN_NONE = 0, > + ATMEL_ADC_TOUCHSCREEN_4WIRE = 4, > + ATMEL_ADC_TOUCHSCREEN_5WIRE = 5, > +}; > + > +/** > + * struct at91_adc_trigger - description of triggers > + * @name: name of the trigger advertised to the user > + * @value: value to set in the ADC's trigger setup register > + to enable the trigger > + * @is_external: Does the trigger rely on an external pin? > + */ > +struct at91_adc_trigger { > + const char *name; > + u8 value; > + bool is_external; > +}; > + > /** > * struct at91_adc_reg_desc - Various informations relative to registers > * @channel_base: Base offset for the channel data registers > @@ -957,30 +974,6 @@ static int at91_adc_probe_dt(struct iio_dev *idev, > return ret; > } > > -static int at91_adc_probe_pdata(struct at91_adc_state *st, > - struct platform_device *pdev) > -{ > - struct at91_adc_data *pdata = pdev->dev.platform_data; > - > - if (!pdata) > - return -EINVAL; > - > - st->caps = (struct at91_adc_caps *) > - platform_get_device_id(pdev)->driver_data; > - > - st->use_external = pdata->use_external_triggers; > - st->vref_mv = pdata->vref; > - st->channels_mask = pdata->channels_used; > - st->num_channels = st->caps->num_channels; > - st->startup_time = pdata->startup_time; > - st->trigger_number = pdata->trigger_number; > - st->trigger_list = pdata->trigger_list; > - st->registers = &st->caps->registers; > - st->touchscreen_type = pdata->touchscreen_type; > - > - return 0; > -} > - > static const struct iio_info at91_adc_info = { > .read_raw = &at91_adc_read_raw, > }; > @@ -1157,11 +1150,7 @@ static int at91_adc_probe(struct platform_device *pdev) > > st = iio_priv(idev); > > - if (pdev->dev.of_node) > - ret = at91_adc_probe_dt(idev, pdev); > - else > - ret = at91_adc_probe_pdata(st, pdev); > - > + ret = at91_adc_probe_dt(idev, pdev); > if (ret) { > dev_err(&pdev->dev, "No platform data available.\n"); > return -EINVAL; You can simply do: if (ret) return ret; The debug message is not relevant anymore. You can also remove: if (!node) return -EINVAL; from at91_adc_probe_dt, there is no way the driver will probe without a DT node. > diff --git a/include/linux/platform_data/at91_adc.h b/include/linux/platform_data/at91_adc.h > deleted file mode 100644 > index f20eaeb827ce..000000000000 > --- a/include/linux/platform_data/at91_adc.h > +++ /dev/null > @@ -1,49 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0-or-later */ > -/* > - * Copyright (C) 2011 Free Electrons > - */ > - > -#ifndef _AT91_ADC_H_ > -#define _AT91_ADC_H_ > - > -enum atmel_adc_ts_type { > - ATMEL_ADC_TOUCHSCREEN_NONE = 0, > - ATMEL_ADC_TOUCHSCREEN_4WIRE = 4, > - ATMEL_ADC_TOUCHSCREEN_5WIRE = 5, > -}; > - > -/** > - * struct at91_adc_trigger - description of triggers > - * @name: name of the trigger advertised to the user > - * @value: value to set in the ADC's trigger setup register > - to enable the trigger > - * @is_external: Does the trigger rely on an external pin? > - */ > -struct at91_adc_trigger { > - const char *name; > - u8 value; > - bool is_external; > -}; > - > -/** > - * struct at91_adc_data - platform data for ADC driver > - * @channels_used: channels in use on the board as a bitmask > - * @startup_time: startup time of the ADC in microseconds > - * @trigger_list: Triggers available in the ADC > - * @trigger_number: Number of triggers available in the ADC > - * @use_external_triggers: does the board has external triggers availables > - * @vref: Reference voltage for the ADC in millivolts > - * @touchscreen_type: If a touchscreen is connected, its type (4 or 5 wires) > - */ > -struct at91_adc_data { > - unsigned long channels_used; > - u8 startup_time; > - struct at91_adc_trigger *trigger_list; > - u8 trigger_number; > - bool use_external_triggers; > - u16 vref; > - enum atmel_adc_ts_type touchscreen_type; > -}; > - > -extern void __init at91_add_device_adc(struct at91_adc_data *data); > -#endif > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel