From: Dan Carpenter <dan.carpenter@oracle.com>
To: robin.murphy@arm.com
Cc: linux-arm-kernel@lists.infradead.org
Subject: [bug report] perf: Add Arm CMN-600 PMU driver
Date: Wed, 30 Sep 2020 17:36:01 +0300 [thread overview]
Message-ID: <20200930143601.GA651785@mwanda> (raw)
Hello Robin Murphy,
The patch 0ba64770a2f2: "perf: Add Arm CMN-600 PMU driver" from Sep
18, 2020, leads to the following static checker warning:
drivers/perf/arm-cmn.c:1252 arm_cmn_init_dtc()
warn: unsigned 'dtc->irq' is never less than zero.
drivers/perf/arm-cmn.c
1245 static int arm_cmn_init_dtc(struct arm_cmn *cmn, struct arm_cmn_node *dn, int idx)
1246 {
1247 struct arm_cmn_dtc *dtc = cmn->dtc + idx;
1248 struct arm_cmn_node *xp;
1249
1250 dtc->base = dn->pmu_base - CMN_PMU_OFFSET;
1251 dtc->irq = platform_get_irq(to_platform_device(cmn->dev), idx);
1252 if (dtc->irq < 0)
^^^^^^^^^^^^
"dtc->irq" is unsigned.
1253 return dtc->irq;
1254
1255 writel_relaxed(0, dtc->base + CMN_DT_PMCR);
1256 writel_relaxed(0x1ff, dtc->base + CMN_DT_PMOVSR_CLR);
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-09-30 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 14:36 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-09-30 14:34 [bug report] perf: Add Arm CMN-600 PMU driver Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930143601.GA651785@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).