From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF7BC4727E for ; Wed, 30 Sep 2020 14:37:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32EBC206D4 for ; Wed, 30 Sep 2020 14:37:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bV4GzN8B"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="UXZDQBse" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32EBC206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=6AMOCJ8sJ5tiG21DogZ2phnYDtXiWepmDuB2dcB4fQs=; b=bV4GzN8BTqg9yIA+q+sCxQtnH8 6Gj54PrY57tAW3vSCC0kOMfLGpk2g/FYAXN97DjJP4RoCmY7bkJIQTjeG16ERGv9hCMw4ER6T80Mq m1y+e97uAM8nARSPb6Euc233hkblYutFD8VgFjrjWos1wS1dfQK2RaNelko/sym7NpkNkKyRIsE0H 3wMktaYpMbBMsBhg6X3upbFBPEqIG2W3vGikMFRD+bgaprlzgTnhYWLMAQY6VFfy4+gt9Q48ZzZbE th4nsBicspBCGXaqBm59Ib/jSK+i8XaI70uT1MPzrfrmlvskisXA98ShmSOQPvsY7h7ZpfK48o5Ca MLrfuv7Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNdDK-0007Th-2N; Wed, 30 Sep 2020 14:36:14 +0000 Received: from aserp2120.oracle.com ([141.146.126.78]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNdDH-0007Sv-GP for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 14:36:12 +0000 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UETZnW081579; Wed, 30 Sep 2020 14:36:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2020-01-29; bh=N+b7er83cx7THZczIw4nLsA8uAC0iV0hpANl59mXIVg=; b=UXZDQBseASkizF+yJTTW6YGhGt6zo0sVVUVfr8EBoMx7T1Op1iQPzCJ6qbZhDFGamVq4 2tXJW+6dacV5hJDNLWsSdqpVJs34qu1HseVmBAlKAtTN8S3vKpU5VJDme1TTLRqe/Qop WW2RQ+o+Q7JyrwyTbCcQoP2hBn4EwMetDW3DpMsDHD1EzsFKjDE15ETJ/a6LuA6UyujM /LYT3YsXtEBoWQ7hTfPjCeE52a87jyol5h99gryMNV4TagaDmdihwpf50KAYwyWpP9zm rjnDa1AitsKtHTEO2Q12DbIuScbW3WLfcIsAiMPMknPhYa3GV9SdxtbU8oCailBRdFBy IQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 33swkm0vbx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 30 Sep 2020 14:36:08 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08UEYtkb013109; Wed, 30 Sep 2020 14:36:08 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 33uv2ff6g0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Sep 2020 14:36:08 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08UEa6So006476; Wed, 30 Sep 2020 14:36:06 GMT Received: from mwanda (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 Sep 2020 07:36:06 -0700 Date: Wed, 30 Sep 2020 17:36:01 +0300 From: Dan Carpenter To: robin.murphy@arm.com Subject: [bug report] perf: Add Arm CMN-600 PMU driver Message-ID: <20200930143601.GA651785@mwanda> MIME-Version: 1.0 Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9759 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=3 malwarescore=0 bulkscore=0 mlxlogscore=925 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300117 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9759 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=3 mlxlogscore=940 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009300116 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_103611_636036_3AF5F8B2 X-CRM114-Status: GOOD ( 13.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Robin Murphy, The patch 0ba64770a2f2: "perf: Add Arm CMN-600 PMU driver" from Sep 18, 2020, leads to the following static checker warning: drivers/perf/arm-cmn.c:1252 arm_cmn_init_dtc() warn: unsigned 'dtc->irq' is never less than zero. drivers/perf/arm-cmn.c 1245 static int arm_cmn_init_dtc(struct arm_cmn *cmn, struct arm_cmn_node *dn, int idx) 1246 { 1247 struct arm_cmn_dtc *dtc = cmn->dtc + idx; 1248 struct arm_cmn_node *xp; 1249 1250 dtc->base = dn->pmu_base - CMN_PMU_OFFSET; 1251 dtc->irq = platform_get_irq(to_platform_device(cmn->dev), idx); 1252 if (dtc->irq < 0) ^^^^^^^^^^^^ "dtc->irq" is unsigned. 1253 return dtc->irq; 1254 1255 writel_relaxed(0, dtc->base + CMN_DT_PMCR); 1256 writel_relaxed(0x1ff, dtc->base + CMN_DT_PMOVSR_CLR); regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel