From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C25C4741F for ; Thu, 1 Oct 2020 11:05:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC3A720B1F for ; Thu, 1 Oct 2020 11:05:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Afk4IhWT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="G8hISO9G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC3A720B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=uMUbSTMcXmGf5epqjFE3NMDQvdb9COzOEABFyAWzYTc=; b=Afk4IhWT7cb9F+mit1cVtqXr/6 dDZUGxcwmPuT6RagibzhmUDd7JisC2qgwHfyHptRcntPJXAMkUHQy/+ratVtQ7YeJHaj/5KO49lM3 +hSx1YprIO5XgEnv0tydAtqA8HCZl7vILfhtJwZm6a+Sz5rPGfOnki1vjZGRlxNA+uk2/8gXf4Zn3 NG8lh+flCya/gvVDxQRmKjL/MlfehzRQfcEgOrQxWMi83KhOXIYffdTO2y4AFmUkTKTaVmKDxNVyA whUukQGCnqBsnQBV3y2oYkMbjpDaV/sBvlnQorbx8WqN/EjHLlFDLmUaI5P0q875V5Bgn6urGso7F 3PpFmntA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNwNi-0001Rx-5L; Thu, 01 Oct 2020 11:04:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNwNe-0001Qd-Rn for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 11:04:11 +0000 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16F9F2087D; Thu, 1 Oct 2020 11:04:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601550249; bh=Dh944qtzDOkUSzC3mPCUvToCF/VP5rzlxA47YFrL89U=; h=From:To:Cc:Subject:Date:From; b=G8hISO9G1JFNnG41IE5VIU61KtF7488pUY4aNw9H1iU5jZs2szPV1mI4eCdApwlqj TnOOL/aELiovYeXnHdqNSeIL29SJc9cUskIIRQH4EYcckOOpMENjhDBzkmMdK/Wcr2 HWea44OKQuD6rYCWN7ahkLuuOiIPEBec36TowYbI= From: Will Deacon To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2] arm64: dbm: Invalidate local TLB when setting TCR_EL1.HD Date: Thu, 1 Oct 2020 12:04:05 +0100 Message-Id: <20201001110405.18617-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_070410_975054_F9DD854F X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Catalin Marinas , Will Deacon Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TCR_EL1.HD is permitted to be cached in a TLB, so invalidate the local TLB after setting the bit when detected support for the feature. Although this isn't strictly necessary, since we can happily operate with the bit effectively clear, the current code uses an ISB in a half-hearted attempt to make the change effective, so let's just fix that up. Cc: Catalin Marinas Signed-off-by: Will Deacon --- v1 -> v2: Retain isb() prior to TLB invalidation. arch/arm64/kernel/cpufeature.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c index 6424584be01e..a474a4f39c95 100644 --- a/arch/arm64/kernel/cpufeature.c +++ b/arch/arm64/kernel/cpufeature.c @@ -1443,6 +1443,7 @@ static inline void __cpu_enable_hw_dbm(void) write_sysreg(tcr, tcr_el1); isb(); + local_flush_tlb_all(); } static bool cpu_has_broken_dbm(void) -- 2.28.0.709.gb0816b6eb0-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel