From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26AC1C4741F for ; Thu, 1 Oct 2020 12:30:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2E0B2087D for ; Thu, 1 Oct 2020 12:30:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n/J8shZt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="R+6pgUx1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2E0B2087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2T+Bfd9nrYtY5RqLCktIWvt8lf0T0/yPqURxcYJkJRE=; b=n/J8shZtg/sB+br8rdr7k79Dy j6v3rRcoRvj11hiozxID4agYVTh60tEBbmtz+fijtpad4Dag/C0f1eXOsgnQla+6nkeVQycnBpgpo s3QKK1DOG0VaQzeurZik7uaBWNhXIZsoHn2ytxI/MeRfmpwb2FKEEVDDtMf4K85TC0UHLTGpwqD2F GQBvxghXF3lrc6MspTCMSOWN7O4Be0XvPyny05GIAZIskeAuz6quNAUZRMkOtFzw+cjIERvFcDWr1 1e8u2IHKHP0g5Df590ElMW1iqvZgtlakmA5PB0Avnmoew+SuUKCU1xQo4J8EIn5UoVDwy2jA8QOHL RJ3ccWO4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNxhZ-0002Xq-R9; Thu, 01 Oct 2020 12:28:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNxhW-0002WN-Pn for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 12:28:48 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C5282087D; Thu, 1 Oct 2020 12:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601555326; bh=2G4KQGBkH0ZzuyyHWBGZvRU+lHyI2UfSVgymrWTOHpg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R+6pgUx1U00BYyDzGVaywzFyyFbWcYmcjPfu+ELEZQSUeqtaCyFMX9+wNNZGaQNAX QYOvk4W/je7GyOilaSgafT55hVCxrooJKOboPJ3+KWjbewsSC8HlTmFwz9T1oEaFdG EnNnDIz2W61VlGznONE2w+QEVet4dqFDyScvQwv0= Date: Thu, 1 Oct 2020 13:28:41 +0100 From: Will Deacon To: Alexandru Elisei Subject: Re: [PATCH v5 00/21] KVM: arm64: Rewrite page-table code and fault handling Message-ID: <20201001122840.GA18789@willie-the-truck> References: <20200911132529.19844-1-will@kernel.org> <4d89869a-3c36-eadf-ba44-0a65a1fa7d19@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4d89869a-3c36-eadf-ba44-0a65a1fa7d19@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_082846_935455_B64E3AB9 X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gavin Shan , Suzuki Poulose , Marc Zyngier , Quentin Perret , James Morse , Andrew Scull , Catalin Marinas , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alex, On Thu, Oct 01, 2020 at 11:21:43AM +0100, Alexandru Elisei wrote: > On 9/11/20 2:25 PM, Will Deacon wrote: > > It's me again, with version five of the KVM page-table rework previously > > seen at: > > > > v1: https://lore.kernel.org/r/20200730153406.25136-1-will@kernel.org > > v2: https://lore.kernel.org/r/20200818132818.16065-1-will@kernel.org > > v3: https://lore.kernel.org/r/20200825093953.26493-1-will@kernel.org > > v4: https://lore.kernel.org/r/20200907152344.12978-1-will@kernel.org > > > > Changes since v4 include: > > > > * Add comments to the kerneldoc describing alignment behaviour for > > addresses and size parameters > > * Fix formatting of IPA size messages > > * Fix handling of unaligned addresses in kvm_phys_addr_ioremap() > > * Add DSB after zeroing stage-2 PGD pages > > * Add reviewer tags > > > > Once again, thanks to Alex, Gavin and Andrew for their comments. > > I didn't realize that there won't be another iteration of the series. I reviewed > all the patches with the exception of patch #5 ("KVM: arm64: Use generic allocator > for hyp stage-1 page-tables") because I don't know much about what needs to mapped > at EL2 stage 1, everything else looks alright to me. If the commit message can be > modified, you can add my Reviewed-by tag to the series (sans #5); it's fine if > that's not possible. The patches ended up in kvmarm/next as the remaining comments were pretty minor, so I've just been sending patches on top to clear up the leftovers (e.g. passing the TLBI level when handling a stage-2 permission fault). Cheers for your review, the series definitely ended up in a much better shape for it. The hyp code is a walk in the park compared with the stage-2 parts, so don't worry about skipping that. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel