From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F29DC4727F for ; Thu, 1 Oct 2020 14:03:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C966220872 for ; Thu, 1 Oct 2020 14:03:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ca3b++4W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C966220872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=OgD7Vdrlp3SEpP8rR62hLCzzefllEOp6ny+hO6Vf1LY=; b=Ca3b++4W3k27H9XJzN+amYo8jb oSCFx+Bjg2fgzAza+LlnapVW+15Ja7cv+2bUdli0XciKsiA2oYKB6GSyFS9eN/shzFNS4rutwkpCT Ugupd2LjyKxgYhmRRjM4kDLvwNJy97tEmCWau84oSGvZmD8l3YXT0eLffj7bMr7+1zw11vzwjTuG6 vQ3ekl71kKU7BcPjKG+nd+hvK47Ezn2qS4s4x1DPkvEwsHoGr+ooVKvJW83viBdcTp7u1Vk7FSwKo 6bq+AcKjvbn9plGIq2qEIZZ+bfyYHXJL8+WG52fTRZ70S/A2BHPU435iZkVgSSTbmHpmpDXtUsIIH EWgKqnUQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNz97-0005xR-Ke; Thu, 01 Oct 2020 14:01:21 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNz95-0005wk-6R for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 14:01:20 +0000 Received: by mail-ot1-f66.google.com with SMTP id h17so5487805otr.1 for ; Thu, 01 Oct 2020 07:01:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jhNdGeKB6aMIHB2cQa7PQRkWF7QSFmx3FEuDcb+C3Sk=; b=ADCOA+zX7bqSNVzzdAkSlS7TDSvHWPH3HHI93D9ngZhvLPW+iNxcinu4W/L1ubbTUk 0yH+vTH3XzJLn+ZJw57qQ5Ga7Oolz+/EzGuxY+6bX93xTGfSavmX3wYI4O6Lf7+kxj2e 4gQ4K0haKiex7RvUNIi1B6UcqPoUxpplNXp3t9WA1/fh+2n1xFf7bksmim75T9CMZB7T DaPpJIjw06Qzk8FQN0Z8YsLHS1WalxEFP7NZAvtm3QJNoBh57qDvmFtvQ6tA78tcp5q8 yPPKAXvQyNJcGZ7bC20FIsuVHnNNcy30zJ7WkeOKynZFcD46iBVOCV3CmbrCFpypKCzG ayfw== X-Gm-Message-State: AOAM530oxvrLslQ72oS7wIPUj4x2hTEt53nsN13IZrMG1uA0uFsyN2Rv XAsj3yo2t0hE9MBXF/s5wjf9nTbqBj5Y X-Google-Smtp-Source: ABdhPJwN2o+SFKQxpDKHd/CKMtJdtaefrQLrQfmZ9Tetge9Ui/bGp0biTvl3OiztDHjNX4iPEuz3sw== X-Received: by 2002:a9d:ae7:: with SMTP id 94mr5201610otq.283.1601560878234; Thu, 01 Oct 2020 07:01:18 -0700 (PDT) Received: from xps15.herring.priv (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.googlemail.com with ESMTPSA id q81sm1032138oia.46.2020.10.01.07.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 07:01:17 -0700 (PDT) From: Rob Herring To: Will Deacon , Catalin Marinas , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Jiri Olsa Subject: [PATCH v4 0/9] libperf and arm64 userspace counter access support Date: Thu, 1 Oct 2020 09:01:07 -0500 Message-Id: <20201001140116.651970-1-robh@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_100119_244014_D765D142 X-CRM114-Status: GOOD ( 22.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Ian Rogers , Alexander Shishkin , linux-kernel@vger.kernel.org, honnappa.nagarahalli@arm.com, Raphael Gault , Jonathan Cameron , Namhyung Kim , Itaru Kitayama , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is resurrecting Raphael's series[1] to enable userspace counter access on arm64. My previous versions are here[2][3][4]. A git branch is here[5]. Changes in v4: - Dropped 'arm64: pmu: Add hook to handle pmu-related undefined instructions'. The onus is on userspace to pin itself to a homogeneous subset of CPUs and avoid any aborts on heterogeneous systems, so the hook is not needed. - Make perf_evsel__mmap() take pages rather than bytes for size - Fix building arm64 heterogeneous test. Changes in v3: - Dropped removing x86 rdpmc test until libperf tests can run via 'perf test' - Added verbose prints for tests - Split adding perf_evsel__mmap() to separate patch The following changes to the arm64 support have been made compared to Raphael's last version: The major change is support for heterogeneous systems with some restrictions. Specifically, userspace must pin itself to like CPUs, open a specific PMU by type, and use h/w specific events. The tests have been reworked to demonstrate this. Chained events are not supported. The problem with supporting chained events was there's no way to distinguish between a chained event and a native 64-bit counter. We could add some flag, but do self monitoring processes really need that? Native 64-bit counters are supported if the PMU h/w has support. As there's already an explicit ABI to request 64-bit counters, userspace can request 64-bit counters and if user access is not enabled, then it must retry with 32-bit counters. Prior versions broke the build on arm32 (surprisingly never caught by 0-day). As a result, event_mapped and event_unmapped implementations have been moved into the arm64 code. There was a bug in that pmc_width was not set in the user page. The tests now check for this. The documentation has been converted to rST. I've added sections on chained events and heterogeneous. The tests have been expanded to test the cycle counter access. Rob [1] https://lore.kernel.org/linux-arm-kernel/20190822144220.27860-1-raphael.gault@arm.com/ [2] https://lore.kernel.org/linux-arm-kernel/20200707205333.624938-1-robh@kernel.org/ [3] https://lore.kernel.org/linux-arm-kernel/20200828205614.3391252-1-robh@kernel.org/ [4] https://lore.kernel.org/linux-arm-kernel/20200911215118.2887710-1-robh@kernel.org/ [5] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git user-perf-event-v4 Raphael Gault (3): arm64: pmu: Add function implementation to update event index in userpage arm64: perf: Enable pmu counter direct access for perf event on armv8 Documentation: arm64: Document PMU counters access from userspace Rob Herring (6): tools/include: Add an initial math64.h libperf: Add libperf_evsel__mmap() libperf: tests: Add support for verbose printing libperf: Add support for user space counter access libperf: Add arm64 support to perf_mmap__read_self() perf: arm64: Add test for userspace counter access on heterogeneous systems Documentation/arm64/index.rst | 1 + .../arm64/perf_counter_user_access.rst | 56 ++++++ arch/arm64/include/asm/mmu.h | 5 + arch/arm64/include/asm/mmu_context.h | 2 + arch/arm64/include/asm/perf_event.h | 14 ++ arch/arm64/kernel/perf_event.c | 62 ++++++ include/linux/perf/arm_pmu.h | 2 + tools/include/linux/math64.h | 75 +++++++ tools/lib/perf/Documentation/libperf.txt | 1 + tools/lib/perf/evsel.c | 34 ++++ tools/lib/perf/include/internal/evsel.h | 2 + tools/lib/perf/include/internal/mmap.h | 3 + tools/lib/perf/include/internal/tests.h | 32 +++ tools/lib/perf/include/perf/evsel.h | 2 + tools/lib/perf/libperf.map | 1 + tools/lib/perf/mmap.c | 188 ++++++++++++++++++ tools/lib/perf/tests/Makefile | 4 +- tools/lib/perf/tests/test-evsel.c | 63 ++++++ tools/perf/arch/arm64/include/arch-tests.h | 7 + tools/perf/arch/arm64/tests/Build | 1 + tools/perf/arch/arm64/tests/arch-tests.c | 4 + tools/perf/arch/arm64/tests/user-events.c | 170 ++++++++++++++++ 22 files changed, 728 insertions(+), 1 deletion(-) create mode 100644 Documentation/arm64/perf_counter_user_access.rst create mode 100644 tools/include/linux/math64.h create mode 100644 tools/perf/arch/arm64/tests/user-events.c -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel