* Re: [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code
2020-09-18 3:08 [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code Liu Shixin
@ 2020-09-18 16:50 ` Ray Jui
2020-10-01 14:36 ` Rob Herring
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Ray Jui @ 2020-09-18 16:50 UTC (permalink / raw)
To: Liu Shixin, Lorenzo Pieralisi, Rob Herring, Bjorn Helgaas,
Ray Jui, Scott Branden, bcm-kernel-feedback-list
Cc: linux-pci, linux-kernel, linux-arm-kernel
On 9/17/2020 8:08 PM, Liu Shixin wrote:
> module_bcma_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> drivers/pci/controller/pcie-iproc-bcma.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-iproc-bcma.c b/drivers/pci/controller/pcie-iproc-bcma.c
> index aa55b064f64d..56b8ee7bf330 100644
> --- a/drivers/pci/controller/pcie-iproc-bcma.c
> +++ b/drivers/pci/controller/pcie-iproc-bcma.c
> @@ -94,18 +94,7 @@ static struct bcma_driver iproc_pcie_bcma_driver = {
> .probe = iproc_pcie_bcma_probe,
> .remove = iproc_pcie_bcma_remove,
> };
> -
> -static int __init iproc_pcie_bcma_init(void)
> -{
> - return bcma_driver_register(&iproc_pcie_bcma_driver);
> -}
> -module_init(iproc_pcie_bcma_init);
> -
> -static void __exit iproc_pcie_bcma_exit(void)
> -{
> - bcma_driver_unregister(&iproc_pcie_bcma_driver);
> -}
> -module_exit(iproc_pcie_bcma_exit);
> +module_bcma_driver(iproc_pcie_bcma_driver);
>
> MODULE_AUTHOR("Hauke Mehrtens");
> MODULE_DESCRIPTION("Broadcom iProc PCIe BCMA driver");
>
Looks good to me. Thanks.
Acked-by: Ray Jui <ray.jui@broadcom.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code
2020-09-18 3:08 [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code Liu Shixin
2020-09-18 16:50 ` Ray Jui
@ 2020-10-01 14:36 ` Rob Herring
2020-10-02 11:46 ` Lorenzo Pieralisi
2020-10-02 11:50 ` Lorenzo Pieralisi
3 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2020-10-01 14:36 UTC (permalink / raw)
To: Liu Shixin
Cc: Lorenzo Pieralisi, Scott Branden, linux-pci, linux-kernel,
bcm-kernel-feedback-list, Ray Jui, Bjorn Helgaas,
linux-arm-kernel
On Fri, 18 Sep 2020 11:08:29 +0800, Liu Shixin wrote:
> module_bcma_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> drivers/pci/controller/pcie-iproc-bcma.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code
2020-09-18 3:08 [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code Liu Shixin
2020-09-18 16:50 ` Ray Jui
2020-10-01 14:36 ` Rob Herring
@ 2020-10-02 11:46 ` Lorenzo Pieralisi
2020-10-02 11:50 ` Lorenzo Pieralisi
3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2020-10-02 11:46 UTC (permalink / raw)
To: Liu Shixin
Cc: Rob Herring, Scott Branden, linux-pci, linux-kernel,
bcm-kernel-feedback-list, Ray Jui, Bjorn Helgaas,
linux-arm-kernel
On Fri, Sep 18, 2020 at 11:08:29AM +0800, Liu Shixin wrote:
> module_bcma_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> drivers/pci/controller/pcie-iproc-bcma.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
Applied to pci/iproc, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pcie-iproc-bcma.c b/drivers/pci/controller/pcie-iproc-bcma.c
> index aa55b064f64d..56b8ee7bf330 100644
> --- a/drivers/pci/controller/pcie-iproc-bcma.c
> +++ b/drivers/pci/controller/pcie-iproc-bcma.c
> @@ -94,18 +94,7 @@ static struct bcma_driver iproc_pcie_bcma_driver = {
> .probe = iproc_pcie_bcma_probe,
> .remove = iproc_pcie_bcma_remove,
> };
> -
> -static int __init iproc_pcie_bcma_init(void)
> -{
> - return bcma_driver_register(&iproc_pcie_bcma_driver);
> -}
> -module_init(iproc_pcie_bcma_init);
> -
> -static void __exit iproc_pcie_bcma_exit(void)
> -{
> - bcma_driver_unregister(&iproc_pcie_bcma_driver);
> -}
> -module_exit(iproc_pcie_bcma_exit);
> +module_bcma_driver(iproc_pcie_bcma_driver);
>
> MODULE_AUTHOR("Hauke Mehrtens");
> MODULE_DESCRIPTION("Broadcom iProc PCIe BCMA driver");
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code
2020-09-18 3:08 [PATCH -next] PCI: iproc: use module_bcma_driver to simplify the code Liu Shixin
` (2 preceding siblings ...)
2020-10-02 11:46 ` Lorenzo Pieralisi
@ 2020-10-02 11:50 ` Lorenzo Pieralisi
3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Pieralisi @ 2020-10-02 11:50 UTC (permalink / raw)
To: Liu Shixin
Cc: Rob Herring, Scott Branden, linux-pci, linux-kernel,
bcm-kernel-feedback-list, Ray Jui, Bjorn Helgaas,
linux-arm-kernel
On Fri, Sep 18, 2020 at 11:08:29AM +0800, Liu Shixin wrote:
> module_bcma_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> drivers/pci/controller/pcie-iproc-bcma.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
Applied to pci/mobiveil, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/pcie-iproc-bcma.c b/drivers/pci/controller/pcie-iproc-bcma.c
> index aa55b064f64d..56b8ee7bf330 100644
> --- a/drivers/pci/controller/pcie-iproc-bcma.c
> +++ b/drivers/pci/controller/pcie-iproc-bcma.c
> @@ -94,18 +94,7 @@ static struct bcma_driver iproc_pcie_bcma_driver = {
> .probe = iproc_pcie_bcma_probe,
> .remove = iproc_pcie_bcma_remove,
> };
> -
> -static int __init iproc_pcie_bcma_init(void)
> -{
> - return bcma_driver_register(&iproc_pcie_bcma_driver);
> -}
> -module_init(iproc_pcie_bcma_init);
> -
> -static void __exit iproc_pcie_bcma_exit(void)
> -{
> - bcma_driver_unregister(&iproc_pcie_bcma_driver);
> -}
> -module_exit(iproc_pcie_bcma_exit);
> +module_bcma_driver(iproc_pcie_bcma_driver);
>
> MODULE_AUTHOR("Hauke Mehrtens");
> MODULE_DESCRIPTION("Broadcom iProc PCIe BCMA driver");
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread