From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C74C4727C for ; Thu, 1 Oct 2020 15:41:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BFE2206C1 for ; Thu, 1 Oct 2020 15:41:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OZG27J2+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FI2TU76O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BFE2206C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u1ZqyktP0wOvex8hSv1LV4roNQZq+GB1bHMaQ2Jx0vE=; b=OZG27J2+B3GUQvP+xfnwMXbtT ROHY5S/S7sSrTf9gcPPBpN8y0yubeQ9EDf9lpM9DE8aopmw5yNlIyzHqdZ0l6abjHXbGsZl/Z4L1K TAELLSaKLjlQnCcaetNZdcTGmEu4cw8s62nJcAIZPpRB8JHxnqzq9i74lBLvpx/U8tEGt9KC94oAe 1W+i6CR/ZRJfVbO28VwK/jdn82+5DuzgovBVki9oJvQfYXNvWzVxFlu9PSNBr6gtZmMhm/XDTGEf6 jnGEhKavdlVgBYQrOy8y2Nfmey0pA3pexmjBiaaEshFJ7uje4lzlJnWqT/7s85UqAO9BZ1sS+W8Ff 2qy4BNuDw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO0gR-0006Kk-Kl; Thu, 01 Oct 2020 15:39:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO0gO-0006Jh-HR for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 15:39:49 +0000 Received: from embeddedor (187-162-31-110.static.axtel.net [187.162.31.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4E979206C1; Thu, 1 Oct 2020 15:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601566787; bh=VJGNA6Q5f/Yc4M/OAmSvr0CgwCyDXE5jldHokQXqMQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FI2TU76ODBwVCBBKiJmpTG7fQ+ohm0ArDvU+3qdrfin/Vr4Da+W6ihgrZ4VbsrEq7 40e/EKe+HAXkP/VvjnMxk8HJDQS19fg1ljJL9r4K2bkFX8UfaNnDSIgikgHghRhWmj MxG2g3pvVGzCghLGHBkmM1/B7+Wz/WZhSXR/+FWY= Date: Thu, 1 Oct 2020 10:45:33 -0500 From: "Gustavo A. R. Silva" To: Will Deacon Subject: Re: [PATCH 1/2] perf: arm-cmn: Fix unsigned comparison to less than zero Message-ID: <20201001154533.GA11717@embeddedor> References: <20201001110315.18505-1-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201001110315.18505-1-will@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_113948_641760_65868D35 X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 01, 2020 at 12:03:14PM +0100, Will Deacon wrote: > Ensure that the 'irq' field of 'struct arm_cmn_dtc' is a signed int > so that it can be compared '< 0'. > > Link: https://lore.kernel.org/r/20200929170835.GA15956@embeddedor > Addresses-Coverity-ID: 1497488 ("Unsigned compared against 0") > Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") > Reported-by: Gustavo A. R. Silva > Signed-off-by: Will Deacon Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index e824b5b83ea2..cd4da4c5dac0 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -217,7 +217,7 @@ struct arm_cmn_node { > > struct arm_cmn_dtc { > void __iomem *base; > - unsigned int irq; > + int irq; > int irq_friend; > bool cc_active; > > -- > 2.28.0.709.gb0816b6eb0-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel