From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5296AC47423 for ; Thu, 1 Oct 2020 17:41:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EBB072054F for ; Thu, 1 Oct 2020 17:41:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yLyqXleo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ptyqzr5K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBB072054F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lQ37QATiGdQWQeD6L0VLjEpso0ed/AmPir6GtrlGFbU=; b=yLyqXleo+YY/JosoSGV8gcVjN eCJvkxMoMrFKly0EUtpfOnURBUPJig+SUCxhtYxkrL7HVgOgQTCzuGmsRzo3f8nm8bUtNzWvy8UTq 2e5QA3P9MfPg+dvscd6EpmjNQ2eiJJj5nrX81LmsEZIFHmet8+/feqRaPoQdMOu8HZmwSg68m3LLn Agg+/QAsi1g1VscsgM5CXUUEmwBHLmUsKKtSMFbVkCqrr7/7Nh8nuwB1KB7NjRdunldHrzRVJd3P5 meS99FtkMDCj649vW3fQmPXPlc7rrxSjr8TsDi2znv7O8gwLZDaLmcxIbvxjX+zBz6KV0Jpnuimbp HiuK+Le8Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO2Yf-0003X4-18; Thu, 01 Oct 2020 17:39:57 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO2Yc-0003Vq-0V for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 17:39:54 +0000 Received: by mail-wr1-x443.google.com with SMTP id j2so6779291wrx.7 for ; Thu, 01 Oct 2020 10:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7216dcRRE3Wn/EM/apMUAUVbD6PsUdlPnAr0Igr7XOw=; b=ptyqzr5KlaqwXGCWxthcuEXOqWrP87iiVAPL53D3y6ROp4TSs/wZ78d9mRg7iQLTJx 6UeLl1ARtrStVJglbLLkIMWz/LNq+uHsiqrgXo0L80r6jfucTEmW5ib6fGkNVF4DTG6w hXv+8awczmTdAvLTgmWg7wIMkdOI3vPiyF8C1kzIddtqx/n0yp/gHjrTDjweG05vpfol ddjCbjuniqlDqPv3Sm92UqyGncDUAIT2+Qe6rfG9DByFQCnodOC22MMqTfJ60CXQgh+r JQ98cfavwZAELBnvwIbaQN2Xj/EOzXLAz7hazRs4KHapIezwYD7g/MJTof55xYdJTGz0 P6xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7216dcRRE3Wn/EM/apMUAUVbD6PsUdlPnAr0Igr7XOw=; b=HwRcxC+UQpETweC49phkWunuvivGxINM4L8lGXS3cGuX/X5DnzSWnu7q5KVFyADNNs hdneVVTVSk47/cantyUOrFkiHXxbZBOSh6+Ewa3rrfIrj88lw4Bpdx60y04AJT2Py1eA tUD4SVQ6QpB1+c1emdlv3l4fYy7cvqEKNIa2a3ue043tefnXAupHZy08I+ytOTDU+iDv XnRehvkHPMbOxv6RU4oByTJX0WkbFSNlMgvd0l2v5XG+vtSLLfey6UsBmQ7l9biYpLdK xLHkBwcncybkvQI4LCP0P8GjiaGgPRMQhR82vwkT/XZL+gQq1lhhlm/ySxPPEglfbfLZ VaLQ== X-Gm-Message-State: AOAM531q7ad/2yjP1irn5YNczrB83hsaxXm/ChvSbXjztygz2yh8VxYx lsdX6cPjbRjigvLf3iGaNL/DEA== X-Google-Smtp-Source: ABdhPJzJbvJMOEyc/fQ30bJrPNU6qkZ+WL5VMh3wle0oInfm6VZiuVKwbb5VAADZcWx+eKbi219y+w== X-Received: by 2002:a5d:4151:: with SMTP id c17mr11009569wrq.302.1601573992713; Thu, 01 Oct 2020 10:39:52 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id y14sm854478wma.48.2020.10.01.10.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 10:39:51 -0700 (PDT) Date: Thu, 1 Oct 2020 19:39:45 +0200 From: elver@google.com To: Andrey Konovalov Subject: Re: [PATCH v3 11/39] kasan: don't duplicate config dependencies Message-ID: <20201001173945.GI4162920@elver.google.com> References: <728981bdedbca9dc1e4cca853699b6a6e8f244e0.1600987622.git.andreyknvl@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <728981bdedbca9dc1e4cca853699b6a6e8f244e0.1600987622.git.andreyknvl@google.com> User-Agent: Mutt/1.14.5 (2020-06-23) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_133954_108582_C7C88209 X-CRM114-Status: GOOD ( 19.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Elena Petrova , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 25, 2020 at 12:50AM +0200, Andrey Konovalov wrote: > Both KASAN_GENERIC and KASAN_SW_TAGS have common dependencies, move > those to KASAN. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino Reviewed-by: Marco Elver But see comment below: > --- > Change-Id: I77e475802e8f1750b9154fe4a6e6da4456054fcd > --- > lib/Kconfig.kasan | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index e1d55331b618..b4cf6c519d71 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -24,6 +24,9 @@ menuconfig KASAN > (HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS) > depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > depends on CC_HAS_WORKING_NOSANITIZE_ADDRESS > + select SLUB_DEBUG if SLUB > + select CONSTRUCTORS > + select STACKDEPOT In the later patch your move 'select SLUB_DEBUG' back to where they were here it seems. The end result is the same, so I leave it to you if you want to change it. > help > Enables KASAN (KernelAddressSANitizer) - runtime memory debugger, > designed to find out-of-bounds accesses and use-after-free bugs. > @@ -46,10 +49,6 @@ choice > config KASAN_GENERIC > bool "Generic mode" > depends on HAVE_ARCH_KASAN && CC_HAS_KASAN_GENERIC > - depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > - select SLUB_DEBUG if SLUB > - select CONSTRUCTORS > - select STACKDEPOT > help > Enables generic KASAN mode. > > @@ -70,10 +69,6 @@ config KASAN_GENERIC > config KASAN_SW_TAGS > bool "Software tag-based mode" > depends on HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS > - depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > - select SLUB_DEBUG if SLUB > - select CONSTRUCTORS > - select STACKDEPOT > help > Enables software tag-based KASAN mode. > > -- > 2.28.0.681.g6f77f65b4e-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel