From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA65C4727E for ; Thu, 1 Oct 2020 17:46:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4958820759 for ; Thu, 1 Oct 2020 17:46:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3DbjgmKM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="HIqQhj0r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4958820759 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0M02YR/IDKKp75T5h6yD/7rR+Wg/2JGLMCKYLIl0t2g=; b=3DbjgmKMtmYC9qNSJtDNyjl2m a0AgjCT1kkJct9OPeyi3GLsOycZuS4WgZXUpzhSohQeE0S1qju9AVCUhf0DrTVDL9Z7/o8I+4AROe kX5pDbW454mn2s9Jj+wiwfoH8sIqtbcyJzzOk0Y6zd50arUEDmOSjyJM2bdrJ2rWpyFlQ5JgRT8qI +KEHpZstj+PVjU61vcXBzUD9fNFgRxlJli06+NFkA5hEs+HxiXYjz+qhB8+lFclAx55XkvjVsP3Qy zErTQrW9FFFVva7VysLpRZG1k/q+vWXuo2NSRJJk0QN3x/XcBL1hGf4aMCSxJCjuhJBxZ7nY2+7OG yJmV7Qopw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO2ds-0004ev-62; Thu, 01 Oct 2020 17:45:20 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kO2dp-0004db-A5 for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 17:45:18 +0000 Received: by mail-wr1-x442.google.com with SMTP id j2so6796463wrx.7 for ; Thu, 01 Oct 2020 10:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SdTU4gQ/GSNzMeDvk9Yhuq+mmVJCx1AqWYuvXYSPp6E=; b=HIqQhj0r1gGYdw02V45ahQXi4QGLOB4PIPtcQRi7iRuA7fmkkN9svVGzTK1Y/rlcjA SPIdxpDNZQuuL+0BJjIgAMejpVODY6Fx47ubXD+cidu8YMiaR+omZqX6YldhiwKGbxob mUGHU6oINAGWbbhYD+l/Cz9z8q1AGWDxsX84tyYAIO3wg8Ta3LJRUVIDkLWRBvfeAjv9 pa0y/97UbN4botFE7fHjk/2zLdDTWd2IXAHCRUJRCjcWFwoMZ4ZysMnbM8bHX3nXQe71 cHpil8dlEuf+yZHPo+9tkopf+DMn/w3sVWswIXj5N+QXOjgK+wRQLErcpeMBMfU1Jq2N UPLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SdTU4gQ/GSNzMeDvk9Yhuq+mmVJCx1AqWYuvXYSPp6E=; b=OuECsJAHeJvjXtlg4ZzNTemuQNTeO2fyBAV/8pkiu0G4IY4h4p1z2vfDSfL1nd+hLp 0MzXWIinPPbZ71nqJU7XiUujZLlQnji6Otlg08w0tGyMBLrP67CMroFyE0K/ifTZi2Hn w2q79syiQt9F528+lfeLYcBEM5i1dOft8EwhPON/Pw+AoPnx2RG2ncu5Puwkq505kkcF 2sdD+cYkBLhxgi1ZltfDEWMZawbI6YBepuoenHIIPvy+jRIIdsqbUj8q8VUKxDBDvEcp fq61EPwQvHVyoLWk+1nLy7ZB7NNEIi8ufg2bAfgYPyvksMrVbxHtjtcn6m6VuTr36V23 T0bg== X-Gm-Message-State: AOAM532QzR9LbafIm2GI/ZAosGOr17QGPVMiPAP3TuKxMt22rtKWk3aj c9zcXhtKx4XA7NtmduJUx+J+sA== X-Google-Smtp-Source: ABdhPJzJmTheU5+EobBQTbg33EPACuLKFxTHdCBuGuc/t70VfL3q1/rNXGQEbgHtlTe5XcWvcpQN+g== X-Received: by 2002:adf:f6c8:: with SMTP id y8mr10971682wrp.217.1601574315975; Thu, 01 Oct 2020 10:45:15 -0700 (PDT) Received: from elver.google.com ([100.105.32.75]) by smtp.gmail.com with ESMTPSA id w7sm9695314wrm.92.2020.10.01.10.45.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 10:45:15 -0700 (PDT) Date: Thu, 1 Oct 2020 19:45:09 +0200 From: elver@google.com To: Andrey Konovalov Subject: Re: [PATCH v3 16/39] kasan: rename addr_has_shadow to addr_has_metadata Message-ID: <20201001174509.GL4162920@elver.google.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.5 (2020-06-23) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_134517_388094_A7D1A923 X-CRM114-Status: GOOD ( 26.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Branislav Rankov , Elena Petrova , Catalin Marinas , Kevin Brodsky , Will Deacon , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 25, 2020 at 12:50AM +0200, 'Andrey Konovalov' via kasan-dev wrote: > This is a preparatory commit for the upcoming addition of a new hardware > tag-based (MTE-based) KASAN mode. > > Hardware tag-based KASAN won't be using shadow memory, but will reuse > this function. Rename "shadow" to implementation-neutral "metadata". > > No functional changes. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino Reviewed-by: Marco Elver > --- > Change-Id: I03706fe34b38da7860c39aa0968e00001a7d1873 > --- > mm/kasan/kasan.h | 2 +- > mm/kasan/report.c | 6 +++--- > mm/kasan/report_generic.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 8dfacc0f73ea..0bf669fad345 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -146,7 +146,7 @@ static inline const void *kasan_shadow_to_mem(const void *shadow_addr) > << KASAN_SHADOW_SCALE_SHIFT); > } > > -static inline bool addr_has_shadow(const void *addr) > +static inline bool addr_has_metadata(const void *addr) > { > return (addr >= kasan_shadow_to_mem((void *)KASAN_SHADOW_START)); > } > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index 91b869673148..145b966f8f4d 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -329,7 +329,7 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, > untagged_addr = reset_tag(tagged_addr); > > info.access_addr = tagged_addr; > - if (addr_has_shadow(untagged_addr)) > + if (addr_has_metadata(untagged_addr)) > info.first_bad_addr = find_first_bad_addr(tagged_addr, size); > else > info.first_bad_addr = untagged_addr; > @@ -340,11 +340,11 @@ static void __kasan_report(unsigned long addr, size_t size, bool is_write, > start_report(&flags); > > print_error_description(&info); > - if (addr_has_shadow(untagged_addr)) > + if (addr_has_metadata(untagged_addr)) > print_tags(get_tag(tagged_addr), info.first_bad_addr); > pr_err("\n"); > > - if (addr_has_shadow(untagged_addr)) { > + if (addr_has_metadata(untagged_addr)) { > print_address_description(untagged_addr, get_tag(tagged_addr)); > pr_err("\n"); > print_shadow_for_address(info.first_bad_addr); > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c > index 42b2b5791733..ff067071cd28 100644 > --- a/mm/kasan/report_generic.c > +++ b/mm/kasan/report_generic.c > @@ -117,7 +117,7 @@ const char *get_bug_type(struct kasan_access_info *info) > if (info->access_addr + info->access_size < info->access_addr) > return "out-of-bounds"; > > - if (addr_has_shadow(info->access_addr)) > + if (addr_has_metadata(info->access_addr)) > return get_shadow_bug_type(info); > return get_wild_bug_type(info); > } > -- > 2.28.0.681.g6f77f65b4e-goog > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/fd0103571c825317241bfdc43ef19766fd370e4f.1600987622.git.andreyknvl%40google.com. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel