From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD353C4727E for ; Fri, 2 Oct 2020 02:04:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 593B920708 for ; Fri, 2 Oct 2020 02:04:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lvpfJtGf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lasWYSqL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 593B920708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e2DZLftLg+qVFfJoWNq5kAIZ/F4aM32A/6qGsmuYCbY=; b=lvpfJtGfA+xZWwBLc8kpDmGTW xj1714c0wri5Z9PmKFEkwfJSnGZQhwtjO84/xP9lOHbqTF3E0xWzDamahf6RAWKDC0sGGorT+DgW+ oYZauc2s+jwu2uLZSGyKycMci33tMoEnhNlSmv7x+rHin9r8AGldfk/cv5YqoLtnKHZCKgIjsJV97 WXr1rgV+bUj31HK7GVo12Q9K5K+grUo5+acBP8U6wIZp0qHM/KgcsC/6HulMqFm/xsNJKlx7MuoOx 7JWnyjgACr814/g3pfCkRmmMNEe/SGrjyhgFKNw96rwwdy3rcrlqG64nQuWgz0rq+8FxplVNS6MuD RYABp3VmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOAQ3-0002xG-TO; Fri, 02 Oct 2020 02:03:35 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOAQ0-0002wH-Rs for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 02:03:33 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AA7EF528; Fri, 2 Oct 2020 04:03:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1601604206; bh=Ife6AOKSz1yLDqr0XawviHdGiWNIv1jH0uvLYdRZtlM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lasWYSqLneJlsXBLxscVGuOD/XNXH+Abh0TitNhRJdc+M9p4lK/eXlP0MKvND++Wn XrdLdEpD/heMImgxZdenzPuJIKjICNVTNi3EuqkF+CATSwJsAunxYECt/ycxVt72I7 T6Vc+Dow77WLuyfYJ+Sg6TmH/3RQKPRftsiLb528= Date: Fri, 2 Oct 2020 05:02:49 +0300 From: Laurent Pinchart To: Michal Simek Subject: Re: [PATCH] arm64: dts: zynqmp: Fix pcie ranges description Message-ID: <20201002020249.GU3722@pendragon.ideasonboard.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_220333_020529_3897A654 X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, monstr@monstr.eu, Rajan Vaja , Nava kishore Manne , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Michael Tretter , Rob Herring , Manish Narani , git@xilinx.com, Kalyani Akula , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, Thank you for the patch. On Tue, Sep 29, 2020 at 01:43:22PM +0200, Michal Simek wrote: > DT schema is checking tuples which should be properly separated. The patch > is doing this separation to avoid the following warning: > ..yaml: axi: pcie@fd0e0000:ranges: [[33554432, 0, 3758096384, 0, > 3758096384, 0, 268435456, 1124073472, 6, 0, 6, 0, 2, 0]] is not valid under > any of the given schemas (Possible causes of the failure): > ...dt.yaml: axi: pcie@fd0e0000:ranges: True was expected > ...dt.yaml: axi: pcie@fd0e0000:ranges:0: [33554432, 0, 3758096384, 0, > 3758096384, 0, 268435456, 1124073472, 6, 0, 6, 0, 2, 0] is too long I would keep the error message unwrapped as it's a bit confusing to read, even if it exceeds the normal 72 columns limit of commit messaged. > Signed-off-by: Michal Simek Reviewed-by: Laurent Pinchart > --- > > I have seen one conversation about it but don't have link which I can point > to. > --- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 771f60e0346d..98073f3223e5 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -542,8 +542,8 @@ pcie: pcie@fd0e0000 { > <0x0 0xfd480000 0x0 0x1000>, > <0x80 0x00000000 0x0 0x1000000>; > reg-names = "breg", "pcireg", "cfg"; > - ranges = <0x02000000 0x00000000 0xe0000000 0x00000000 0xe0000000 0x00000000 0x10000000 /* non-prefetchable memory */ > - 0x43000000 0x00000006 0x00000000 0x00000006 0x00000000 0x00000002 0x00000000>;/* prefetchable memory */ > + ranges = <0x02000000 0x00000000 0xe0000000 0x00000000 0xe0000000 0x00000000 0x10000000>,/* non-prefetchable memory */ > + <0x43000000 0x00000006 0x00000000 0x00000006 0x00000000 0x00000002 0x00000000>;/* prefetchable memory */ > bus-range = <0x00 0xff>; > interrupt-map-mask = <0x0 0x0 0x0 0x7>; > interrupt-map = <0x0 0x0 0x0 0x1 &pcie_intc 0x1>, -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel