From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D9DCC4363D for ; Fri, 2 Oct 2020 08:21:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CA7B206A2 for ; Fri, 2 Oct 2020 08:21:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xsv4mQAL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CA7B206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n3vUKKIn/pqSMnDS4nGl0RYMmvlFrQ6gCqlh4kH+13w=; b=Xsv4mQALpd4+P/2IM3wVYZ83r k4UGxgbUcdeYGz/uy1wMzOCg9VDufeKhLqvat75F6zIXUvMV0t+bwMyyw/xftv/BjzJVQw8XyzQ0g 2ISTLwglEr7Qy3MKaojFnz8qssvvNRwRj8q7vDfkbQv6x31byyyMOjOCFKuiFSC8tERnC7Ty53ipx OBJKWDHWAKE1mifeGaLmn7ssix0wZF/lDgMPlEhkUc4bPpu14gmz2IaqZpijZ3Ljv7C8t2E32N9j7 +iHfN31BFXeAU/FTfOYH9WyJY/83iYm7wyjCcbKtT4st3/JZBUemjesAoRxgl3gW8QmcY3scPLzk3 Nd5Q6SqrA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOGIp-0004Sn-0e; Fri, 02 Oct 2020 08:20:31 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOGIa-0004N6-SB for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 08:20:18 +0000 Received: by mail-ed1-f67.google.com with SMTP id l17so759508edq.12 for ; Fri, 02 Oct 2020 01:20:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bkh1SP/RxLZt/FHcHaOcXfHwmKZUTF99Sb6EVCBToAI=; b=eDAf24Wzgocu5m5eseGY0q+Nsj7VqbwjAZzb9eNoSrp0rKSSIEgnYO01U/JgFmmeMi gq7U8kfEL7lJ7p6bRKJ1FJURQKLWpBMM7WEWFadE663GYSVUzvTSUNk9310mmF9gA2yw PmO7wHMPC6783JBzlpuMhuxI/YTRXMFhqkvqC2auAdPqOt1Z4XJ0fCmvvQ4YIuEpSwZX gADvKRdUNuRBnn2mxmC0u2v4WLQchdUdKgHJmWfamqq9D/HcE1zFF9mn0L/jmT7/RqFg 2chtIzT9MIN9xBV0RYCKXekC6f/gnxkMZYVNAMLg0Yp0NY/Fua0j3G6x3+qmD5wMhSzi 24gw== X-Gm-Message-State: AOAM53382cg7DYK+99p4VNyg0/UegU+MTOYZGan8tvDDhYQR9ZuXqMDn kY5xQmbNOhN7KfU5asBQ5YQ= X-Google-Smtp-Source: ABdhPJxX55AwyVhonHu2pITZEj1/D9GVJtA481IouPj2agmtzYOF7zuZPrsa4fVc+noKKiqP5rLSgA== X-Received: by 2002:aa7:d1d5:: with SMTP id g21mr1145493edp.348.1601626815502; Fri, 02 Oct 2020 01:20:15 -0700 (PDT) Received: from pi3 ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id y25sm633136edv.15.2020.10.02.01.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 01:20:14 -0700 (PDT) Date: Fri, 2 Oct 2020 10:20:12 +0200 From: Krzysztof Kozlowski To: Ahmad Fatoum Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles Message-ID: <20201002082012.GA6605@pi3> References: <20200930190143.27032-1-krzk@kernel.org> <20200930190143.27032-9-krzk@kernel.org> <0a0afea6-8cbb-3e89-5a4f-89660c942ca3@pengutronix.de> <20201001073208.GA5208@kozik-lap> <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de> <20201001103704.GA26287@kozik-lap> <7fcea21d-4651-9ba7-5331-86530296a847@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7fcea21d-4651-9ba7-5331-86530296a847@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_042016_937459_86AAEE2E X-CRM114-Status: GOOD ( 22.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Robert Jones , Stefan Riedmueller , Anson Huang , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Li Yang , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Andreas Kemnade , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2020 at 09:41:28AM +0200, Ahmad Fatoum wrote: > Hello, > > On 10/1/20 12:37 PM, Krzysztof Kozlowski wrote: > >> The existing binding doesn't cover these boards then and needs to be > >> extended, no? How about following patch? > > > > What do you mean it doesn't cover? It was added exactly to handle them: > > + - technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf > > + - technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit > > + - technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph > > + - technexion,imx6q-pico-pi # TechNexion i.MX6Q Pico-Pi > > > > Still they are unused. So I'd think these boards should be handled like boards > that predated bindings: a binding is written that doesn't break existing users. OK, let's assume the binding is not correct and DTSes are good. > > >> [I guess we need to keep the two-compatible list they were originally > >> in for compatibility even if it's unused among upstream device trees?] > > > > You want to change both the binding (thus breaking the ABI) and update > > the DTS to reflect new ABI. Then why having a binding at all? > > If we leave the old two-compatible enumeration intact, there is no ABI broken. Just to clarify, because I don't get here the "no ABI broken" part: ABI is the binding, not the DTS. We can change intree DTS as we like, replace compatibles, add nodes, remove nodes. There is no stability requirement for DTS contents. If we leave two-compatible binding intact, it is a broken binding since beginning. Removing non-working, fake ABI is not breaking it because it could never work. > > > I would assume that either binding is correct or DTS. You propose that > > both are wrong and both need changes... in such case this is clearly > > broken. > > IMO the DTS is the correct one. If you want to honor the author's intention > that each base board has a different compatible, it should be an extra > compatible and not replace the existing one that may be already in use. OK, we can go with DTS approach. I fixed few of such cases as well, assuming that DTS was intended and binding was incorrect. In such case all boards will be documented under one compatible technexion,imx6q-pico and DTS will not be changed. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel