From: Sudeep Holla <sudeep.holla@arm.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: ulf.hansson@linaro.org, arnd@arndb.de,
lakshmi.bai.raja.subramanian@intel.com,
linux-mmc@vger.kernel.org, adrian.hunter@intel.com,
linux-kernel@vger.kernel.org,
wan.ahmad.zainie.wan.mohamad@intel.com,
muhammad.husaini.zulkifli@intel.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call
Date: Fri, 2 Oct 2020 11:58:40 +0100 [thread overview]
Message-ID: <20201002105840.GE906@bogus> (raw)
In-Reply-To: <ce2bcac9-8341-d7c1-0652-309ca4e9413c@xilinx.com>
Hi Michal,
On Fri, Oct 02, 2020 at 10:23:02AM +0200, Michal Simek wrote:
> Hi Sudeep,
>
> On 01. 10. 20 17:35, Sudeep Holla wrote:
[...]
> >
> > What are the other uses of this KEEMBAY_SIP_* ?
> > For now I tend to move this to the driver making use of it using
> > arm_smccc_1_1_invoke directly if possible. I don't see the need for this
> > to be separate driver. But do let us know the features implemented in the
> > firmware. If it is not v1.1+, reasons for not upgrading as you need v1.1
> > for some CPU errata implementation.
>
> This driver has been created based on my request to move it out the mmc
> driver. It looks quite hacky to have arm_smccc_res and call
> arm_smccc_smc() also with some IDs where it is visible that the part of
> ID is just based on any spec.
OK, driver is fine but no dt-bindings as it is discoverable. It can
also be just a wrapper library instead as it needs no explicit
initialisation like drivers to setup.
> Also in v1 he is just calling SMC. But maybe there is going a need to
> call HVC instead which is something what device driver shouldn't decide
> that's why IMHO doing step via firmware driver is much better approach.
Agreed and one must use arm_smccc_get_conduit or something similar. No
additional bindings for each and ever platform and driver that uses SMCCC
please.
> Of course if there is a better/cleaner way how this should be done I am
> happy to get more information about it.
>
Let me know what you think about my thoughts stated above.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-02 11:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 14:21 [PATCH v2 0/3] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
2020-10-01 14:21 ` [PATCH v2 1/3] dt-bindings: arm: firmware: Add binding for Keem Bay Firmware Support muhammad.husaini.zulkifli
2020-10-01 14:21 ` [PATCH v2 2/3] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call muhammad.husaini.zulkifli
2020-10-01 15:35 ` Sudeep Holla
2020-10-02 8:23 ` Michal Simek
2020-10-02 10:22 ` Zulkifli, Muhammad Husaini
2020-10-02 11:00 ` Sudeep Holla
2020-10-02 10:58 ` Sudeep Holla [this message]
2020-10-02 13:53 ` Michal Simek
2020-10-02 14:51 ` Sudeep Holla
2020-10-05 8:37 ` Zulkifli, Muhammad Husaini
2020-10-05 8:44 ` Sudeep Holla
2020-10-05 17:04 ` Zulkifli, Muhammad Husaini
2020-10-05 20:07 ` Sudeep Holla
2020-10-06 1:14 ` Zulkifli, Muhammad Husaini
2020-10-06 1:22 ` Zulkifli, Muhammad Husaini
2020-10-06 11:13 ` Sudeep Holla
2020-10-06 11:46 ` Michal Simek
2020-10-06 12:08 ` Michal Simek
2020-10-01 14:21 ` [PATCH v2 3/3] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002105840.GE906@bogus \
--to=sudeep.holla@arm.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).