From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5650DC4363D for ; Fri, 2 Oct 2020 11:00:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 026F120719 for ; Fri, 2 Oct 2020 11:00:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P8k5aSt1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 026F120719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KOLEPrW3icj/gbUv1TbrUiFPGa5t/DqDTKfo5PJMw1c=; b=P8k5aSt1ip3vVL+2Cfwainhd8 2bfZVoZ3CqLQamWcZ6v8hio5a8fwWd/j5EOTW49IMpZnmMzjW1SYdBJ7Q8QmcdLHBXNI1K8MJOt9l 1/F/T4SP0MAAGm8hjjd3HkkrZwgeGFx/jW0wKGeCwPqrtgEeFQ0OGAK8GsdO6znmAqcGFN8Gonc2c SsuiEDrCyhb83QxBXmCGRxPiQAvJp28l+GBJeu4mp6w5jlbdV/cvIdUJrUilZIhut4DvQ+Iq4XBBr NnZSXqIWvoY3FpVQ2j6g6IuL65tmZ+BsUzEsiHdbsCSs9RwpcR7JF/cPuKSGDRqmgFOeR5Y4cFL1A Hfgs2ktYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOIm2-0006z5-6Z; Fri, 02 Oct 2020 10:58:50 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOIm0-0006xK-0z for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 10:58:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 687C731B; Fri, 2 Oct 2020 03:58:44 -0700 (PDT) Received: from bogus (unknown [10.57.48.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C03A13F73B; Fri, 2 Oct 2020 03:58:42 -0700 (PDT) Date: Fri, 2 Oct 2020 11:58:40 +0100 From: Sudeep Holla To: Michal Simek Subject: Re: [PATCH v2 2/3] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call Message-ID: <20201002105840.GE906@bogus> References: <20201001142149.23445-1-muhammad.husaini.zulkifli@intel.com> <20201001142149.23445-3-muhammad.husaini.zulkifli@intel.com> <20201001153526.GD906@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_065848_157822_1F68C765 X-CRM114-Status: GOOD ( 24.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, arnd@arndb.de, lakshmi.bai.raja.subramanian@intel.com, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, wan.ahmad.zainie.wan.mohamad@intel.com, muhammad.husaini.zulkifli@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michal, On Fri, Oct 02, 2020 at 10:23:02AM +0200, Michal Simek wrote: > Hi Sudeep, > > On 01. 10. 20 17:35, Sudeep Holla wrote: [...] > > > > What are the other uses of this KEEMBAY_SIP_* ? > > For now I tend to move this to the driver making use of it using > > arm_smccc_1_1_invoke directly if possible. I don't see the need for this > > to be separate driver. But do let us know the features implemented in the > > firmware. If it is not v1.1+, reasons for not upgrading as you need v1.1 > > for some CPU errata implementation. > > This driver has been created based on my request to move it out the mmc > driver. It looks quite hacky to have arm_smccc_res and call > arm_smccc_smc() also with some IDs where it is visible that the part of > ID is just based on any spec. OK, driver is fine but no dt-bindings as it is discoverable. It can also be just a wrapper library instead as it needs no explicit initialisation like drivers to setup. > Also in v1 he is just calling SMC. But maybe there is going a need to > call HVC instead which is something what device driver shouldn't decide > that's why IMHO doing step via firmware driver is much better approach. Agreed and one must use arm_smccc_get_conduit or something similar. No additional bindings for each and ever platform and driver that uses SMCCC please. > Of course if there is a better/cleaner way how this should be done I am > happy to get more information about it. > Let me know what you think about my thoughts stated above. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel