From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B000C4363D for ; Fri, 2 Oct 2020 14:12:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2612E206DB for ; Fri, 2 Oct 2020 14:12:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="z3bzcoPE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2612E206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h9wUoPV7OefZmmSkStAmsBGwuFvPy0YEEXEKlE5tYqU=; b=z3bzcoPEOtBda2kqF/Fm+YJXC Lxq8CdoPnyZ+JM8tDvMsUgaWnGi4eZF2/3TzGUmbrIRm8z5RLE3merpfPX5T93ODArrKDEVwD2DyG +hXC+i0tUM2jGP7QLYjKJEkYNfwG8HdlhJbwqlSDIm23noJ11IBSz/hs5rXzOaEe8cIk7zkt0St2Z C/8LRM2nf05eoMq4zLde36YXYcwhTnywOfifLmw0Sl7zcoDZb/H0w44VhowA3nwQEzznVLn7+LA2p yonK77a/KoT12A9cGiwfwnB8jsaJO1wH4ZSrunV8Sw8AtfUg+S4nGZB7Q5t3s9Oz8FnTkGDNUHU5E wcXL1UYYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOLm3-0006Th-GE; Fri, 02 Oct 2020 14:11:03 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOLm0-0006Sz-NG for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 14:11:01 +0000 Received: from gaia (unknown [95.149.105.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7543C206DB; Fri, 2 Oct 2020 14:10:57 +0000 (UTC) Date: Fri, 2 Oct 2020 15:10:55 +0100 From: Catalin Marinas To: Andrey Konovalov Subject: Re: [PATCH v4 30/39] arm64: kasan: Enable TBI EL1 Message-ID: <20201002141054.GH7034@gaia> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_101100_819804_F6AE252A X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Marco Elver , Elena Petrova , Kevin Brodsky , Will Deacon , Branislav Rankov , kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Potapenko , Evgenii Stepanov , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2020 at 01:10:31AM +0200, Andrey Konovalov wrote: > From: Vincenzo Frascino > > Hardware tag-based KASAN relies on Memory Tagging Extension (MTE) that is > built on top of the Top Byte Ignore (TBI) feature. > > Enable in-kernel TBI when CONFIG_KASAN_HW_TAGS is turned on by enabling > the TCR_TBI1 bit in proc.S. > > Signed-off-by: Vincenzo Frascino > Co-developed-by: Andrey Konovalov > Signed-off-by: Andrey Konovalov > --- > Change-Id: I91944903bc9c9c9044f0d50e74bcd6b9971d21ff > --- > arch/arm64/mm/proc.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/proc.S b/arch/arm64/mm/proc.S > index 6c1a6621d769..7c3304fb15d9 100644 > --- a/arch/arm64/mm/proc.S > +++ b/arch/arm64/mm/proc.S > @@ -46,7 +46,7 @@ > #endif > > #ifdef CONFIG_KASAN_HW_TAGS > -#define TCR_KASAN_HW_FLAGS SYS_TCR_EL1_TCMA1 > +#define TCR_KASAN_HW_FLAGS SYS_TCR_EL1_TCMA1 | TCR_TBI1 > #else > #define TCR_KASAN_HW_FLAGS 0 > #endif Please merge this patch with the one one introducing TCR_KASAN_HW_FLAGS, no need to have both around. You can add my Reviewed-by on that one. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel