From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C01C4363D for ; Fri, 2 Oct 2020 15:04:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DB25206CA for ; Fri, 2 Oct 2020 15:04:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p0fQXI71" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DB25206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nrvmxvl3ojGd9po6k1RXe5sUS3/sX4vra5lptTWN1jc=; b=p0fQXI71R05ebIlPpZat8UiAP q6bDjn5uyDkUtfXKQLYMfvDNjmP9+TiRWqdp/hZ9L2BDDJhqC09JzEzC1k2kCEPufJEXcB0vEDOwT MK6QDk4QQRE0DWjdQDQr/BLwrBkuG8g8ScHHKIoVc365zZmTqdfHEhwGb240V//u3QvidPojyytaV 83OUrLIeYr8coqWHBiYoo+oN8h4139vasyJ1vl6K/VvfJUQNZYzd6MxreaG11p9Y0isu/0C4QziYx PZjIYpu0XVXwrbZMOym1xcJAHnH8IHIRchi+kyUt1NkrkPZLoOQ81DZsYB7fcdu9OalOJ69R9jdu/ Htea7I+EQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOMaj-0007wR-7r; Fri, 02 Oct 2020 15:03:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOMaf-0007vm-WD for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 15:03:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7C8171396; Fri, 2 Oct 2020 08:03:20 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1116B3F73B; Fri, 2 Oct 2020 08:03:18 -0700 (PDT) Date: Fri, 2 Oct 2020 16:03:09 +0100 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF Message-ID: <20201002150300.GA25684@e121166-lin.cambridge.arm.com> References: <20200902144344.16684-1-pali@kernel.org> <20201002133713.GA24425@e121166-lin.cambridge.arm.com> <20201002142616.dxgdneg2lqw4pxie@pali> <20201002143851.GA25575@e121166-lin.cambridge.arm.com> <20201002145237.r2troxmgbq2bf3ep@pali> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201002145237.r2troxmgbq2bf3ep@pali> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_110322_181458_452D8B93 X-CRM114-Status: GOOD ( 29.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Rob Herring , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , Miquel Raynal , Bjorn Helgaas , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2020 at 04:52:37PM +0200, Pali Roh=E1r wrote: > On Friday 02 October 2020 15:38:51 Lorenzo Pieralisi wrote: > > On Fri, Oct 02, 2020 at 04:26:16PM +0200, Pali Roh=E1r wrote: > > > On Friday 02 October 2020 14:37:13 Lorenzo Pieralisi wrote: > > > > On Wed, Sep 02, 2020 at 04:43:42PM +0200, Pali Roh=E1r wrote: > > > > > This patch series fixes regression introduced in commit 366697018= c9a > > > > > ("PCI: aardvark: Add PHY support") which caused aardvark driver > > > > > initialization failure on EspressoBin board with factory version = of > > > > > Arm Trusted Firmware provided by Marvell. > > > > > = > > > > > Second patch depends on the first patch, so please add appropriate > > > > > Fixes/Cc:stable@ tags to have both patches correctly backported to > > > > > stable kernels. > > > > > = > > > > > I have tested both patches with Marvell ATF firmware ebin-17.10-u= art.zip > > > > > and with upstream ATF+uboot and aardvark was initialized successf= ully. > > > > > Without this patch series on ebin-17.10-uart.zip aardvark initial= ization > > > > > failed. > > > > > = > > > > > Pali Roh=E1r (2): > > > > > phy: marvell: comphy: Convert internal SMCC firmware return cod= es to > > > > > errno > > > > > PCI: aardvark: Fix initialization with old Marvell's Arm Trusted > > > > > Firmware > > > > > = > > > > > drivers/pci/controller/pci-aardvark.c | 4 +++- > > > > > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 14 +++++++++++--- > > > > > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 14 +++++++++++--- > > > > > 3 files changed, 25 insertions(+), 7 deletions(-) > > > > = > > > > Applied to pci/aardvark (both patches), thanks. > > > = > > > Ok! For second patch would be needed to put CC:stable line with > > > specifying prerequisite of first patch as written in document: > > > = > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.ht= ml > > > = > > > If I understood it correctly, second patch needs following line: > > > = > > > Cc: # : comphy: err= no return codes > > > = > > > where is commit id of PATCH 1/2. > > > = > > > (correct me if I'm wrong) > > > = > > > Now when first commit has commit id, could you update second commit to > > > include this information about prerequisite? > > = > > No I can't because they will be merged at the same time. > = > And it is a problem? Git commit id of first patch would not be changed, > so referencing to it is now possible from second commit (unless you do > rebasing). > = > > What we can do is mark the second patch for stable > = > This is done by adding "Cc: " line to second > patch which I suggested, right? I will apply the stable tag and dependency, it should be fine. Please ensure you follow up stable updates especially in case patches don't backport properly (ie please try). Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel