From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D3FFC4363C for ; Sun, 4 Oct 2020 09:28:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D1FE206A1 for ; Sun, 4 Oct 2020 09:28:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p+8d9eYY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="jMk4keie" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D1FE206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1g5aO9l5Y2FW2YuW2kqx0lkIuSAHf/5ucrwoKMQAr3U=; b=p+8d9eYYm42VuRMj7fW1ODeAQ HHQv53lSHgsOQDbHfyYj+b/2LtFdv7sPc0PnTqSNxnBulExm6/KW0zZiJbuJ4ssdx5AYqSK6x1/nx h+FaiCjdlKuUDyDwLXbZIJs4gVMI0DmSEEgUeJXaZ8p1kr6G1ydgEAs4gTzMqyUTF8Q/lgIWBZNCv 4zRGBgFF3Ki5OscrlbBPEUh79oQqLPeGGBKkuLNEumui8uHQS+uHT2tRdrtt7rh0HlgXHPJ9QsEf6 ZPBmYB26cmii5LaAW8+/4T3AqTrnnlCJH9wdDTL/SRXlPzD+FhdclJkf/RXgsNOvj2cAaF5LWrXf+ WKtcIhRHA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kP0IJ-0003JX-RZ; Sun, 04 Oct 2020 09:27:03 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kP0IH-0003Ax-E0 for linux-arm-kernel@lists.infradead.org; Sun, 04 Oct 2020 09:27:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uk61xPxvfvQYj4ScWiDcE+iDq+hfu82CzM2wpEZmDpY=; b=jMk4keie6G55oRdb4YXWPQXyC d/EeFgJhUCL4RpjOXxCn+Ix6k89x+OmAihD2hYeSLtvsy/hQlPA2kL3258dAAo7FwVexxBbdP43td 8jx6E70m0ByhCR2UkKPTDXjRLkyXZD24/wcDrTXfRzbt0jsQyx4aeyN/lhNwNzckdtMgJY0hv+0s1 mbBvj65A6/IIhoBNuwtxTGWsuZMn8G0akJaJTE6eKllm2YWlsQowPezZzgF4MBMdB1fJyhMxs1Dlm P0ngGgFVLMkmpBqoxHMteX7nw+gYyR+PK7y01AXRqfUItHb0q8ZlGknNYGj85jY+jPs0v3gCdkmCD URMuYqlSQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41774) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kP0GG-00005h-Es; Sun, 04 Oct 2020 10:24:56 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kP0GF-00061D-T1; Sun, 04 Oct 2020 10:24:55 +0100 Date: Sun, 4 Oct 2020 10:24:55 +0100 From: Russell King - ARM Linux admin To: Codrin Ciubotariu Subject: Re: [PATCH v2] i2c: pxa: move to generic GPIO recovery Message-ID: <20201004092455.GI1551@shell.armlinux.org.uk> References: <20201004091656.1004575-1-codrin.ciubotariu@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201004091656.1004575-1-codrin.ciubotariu@microchip.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201004_052701_481810_496F964A X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wsa@kernel.org, alpawi@amazon.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 04, 2020 at 12:16:56PM +0300, Codrin Ciubotariu wrote: > Starting with > commit 75820314de26 ("i2c: core: add generic I2C GPIO recovery") > GPIO bus recovery is supported by the I2C core, so we can remove the > driver implementation and use that one instead. > > Signed-off-by: Codrin Ciubotariu > --- > > This patch is not tested. > > Changes in v2: > - readded the pinctrl state change to default from the > unprepare_recovery callback; I don't think you've build tested this patch... > diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c > index 35ca2c02c9b9..006cc1d5931f 100644 > --- a/drivers/i2c/busses/i2c-pxa.c > +++ b/drivers/i2c/busses/i2c-pxa.c > @@ -264,9 +264,6 @@ struct pxa_i2c { > u32 hs_mask; > > struct i2c_bus_recovery_info recovery; > - struct pinctrl *pinctrl; > - struct pinctrl_state *pinctrl_default; > - struct pinctrl_state *pinctrl_recovery; i2c_pxa_unprepare_recovery() refers to pinctrl and pinctrl_default which you've retained in this version of the patch, but you've deleted the members from this structure - which will lead to a build error. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel