From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF28C4363A for ; Mon, 5 Oct 2020 11:59:41 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1BB120774 for ; Mon, 5 Oct 2020 11:59:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V7vicnBr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pFNObrq2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1BB120774 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WXp1mQR1rtsU7WH+gaewyfUQSgLkMQL+rcr9jGg9pzY=; b=V7vicnBrKWy6+U5NyzHzh4S7Q Md6Ejo3ng/qDk9QD219TAbNVckG2uFTYI1cev6kxexWAW9nSOs4Nnj/1vVOrRu2gNnzKq3qRSLK/k lYvuLwE+eaHRzfPZzjieCfeXGIyQW0dUZjzm4IJaPDtCP7gh+04ABPJJzAW64ndukJnsB7HLVgw1z y3XyUsSefdPyZwk9vdMsOEnIz6fm+7GTFBCKaNzqwU052jyp//2HSE8tusxlJKEGGBejjdUEyks5u RkTRuSD0NNaWkeLTosqClX+Eyzx60toCYbFeNGccIEUH3xlnX9uxA+OM/4xRfEGx3GAjsnj+eUpX/ fbqEOQQgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPP89-00046d-3B; Mon, 05 Oct 2020 11:58:13 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPP86-000467-CS for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 11:58:11 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 095Bw6Ip043067; Mon, 5 Oct 2020 06:58:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1601899086; bh=2aQlBRVkqm7tCgrVtYFnKACp9DuQDSDBLtTfAYARDzs=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=pFNObrq2uKoPCWI+w1EWi/4+4SF+zGHPgU2rsfQAovAt8ufIKZN9FUmq9lhcZEjcX Uy8C/SH5qd0kM5WXmga2hRtQuCN/HCu6LVIXrffNioTqqZyzWWYrObNYw39E+a9viu FXvFM0zWEF+MNwG2DNKNUKXKt0Oht2t1mUACaSkk= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 095Bw5FH067227 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Oct 2020 06:58:06 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 5 Oct 2020 06:58:05 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 5 Oct 2020 06:58:05 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 095Bw5UG034528; Mon, 5 Oct 2020 06:58:05 -0500 Date: Mon, 5 Oct 2020 06:58:05 -0500 From: Nishanth Menon To: Peter Ujfalusi Subject: Re: [PATCH] arm64: dts: ti: k3-j7200-main: Add McASP nodes Message-ID: <20201005115805.d6yhykn7oc6x2tbu@charm> References: <20201005074850.11247-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201005074850.11247-1-peter.ujfalusi@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_075810_552957_8A076887 X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: t-kristo@ti.com, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10:48-20201005, Peter Ujfalusi wrote: > Add the nodes for McASP 0-2 and keep them disabled because several > required properties are not present as they are board specific. > > Signed-off-by: Peter Ujfalusi > --- > arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 57 +++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > index 72d6496e88dd..cc6c2a81887a 100644 > --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi > @@ -446,4 +446,61 @@ usb0: usb@6000000 { > dr_mode = "otg"; > }; > }; > + > + mcasp0: mcasp@02b00000 { > + compatible = "ti,am33xx-mcasp-audio"; > + reg = <0x0 0x02b00000 0x0 0x2000>, > + <0x0 0x02b08000 0x0 0x1000>; > + reg-names = "mpu","dat"; > + interrupts = , > + ; > + interrupt-names = "tx", "rx"; > + > + dmas = <&main_udmap 0xc400>, <&main_udmap 0x4400>; > + dma-names = "tx", "rx"; > + > + clocks = <&k3_clks 174 40>; > + clock-names = "fck"; > + power-domains = <&k3_pds 174 TI_SCI_PD_EXCLUSIVE>; > + > + status = "disabled"; I see that there is inconsistent usage of "disabled" in our SoC.dts Our generic rule has been set them to disabled in board.dtsi McASP and DSS for existing SoC dts do not follow this.. which is a tad confusing.. (considering that not even all uarts come out on every board and every uart needs pinmux to function..) Tero: Thoughts? [...] -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel