From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20DCFC46466 for ; Mon, 5 Oct 2020 17:39:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAF09207BC for ; Mon, 5 Oct 2020 17:39:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sb6J9DDI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAF09207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uwPfX/8/d41y+nQIHDHbs7sfkf8mWsO85kpcv+vpSq8=; b=Sb6J9DDI7a3dHcvSWlsLmPawZ jdmqyZmJWqVoK1KbgAujSzH86vQsV08pq02o137XH1yhQxzLnLtR5iqMWTX73LdYPX2P+vBskpp6g /LhHYeilgDbXhovf0I2cQWFKz3r6SRJx500I3DG3WSDd/PEU3zR0+tfrFjeUlNlfle4YyG0bBOfne w3xCdxLnbh878YwSiQIACMSpSU473VCR+2o+CqIBqAiE5mnbXLLPjVWg/JijmzjEjsOaXuoBj74Dr pOrClGGBIiZTayh5u8ZdqSgah6G6QqpP5N2U3YpOjJ0kFcmUlVxutdZT1EOKLgfdUITJhkJig2DED g3zDoSR6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPUQw-0007lG-37; Mon, 05 Oct 2020 17:37:58 +0000 Received: from mail-pg1-f193.google.com ([209.85.215.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPUQl-0007g9-EQ for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 17:37:48 +0000 Received: by mail-pg1-f193.google.com with SMTP id g9so5930539pgh.8 for ; Mon, 05 Oct 2020 10:37:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wdqITJDQRbpmmuyzbiSajCMT3fTgONqCxlfl7IqR5tU=; b=ncfzhr6wEiQoS2lkdlN/VwyIn56EmjAuFel/7hfsfhcwvyUATb7MF9uVoyc0OIBZzy M62l5B7nUmZG0RJ7ocxXG6Hpfr1tqJpqfTvq5imfmvgbhNlqx7qP3fW9VSY5pMfe3vzu d3dCrOtTiUkL8MCUwSIGrV3Pb6XORFkexBBDdsLdl9wZg8Eu776gFyOTUMGZN/YxAEcX la/rQBye6BcORaet/g2/NjsxH0GrvWIW677XAu7Y4PwBRn7pBQExfc0kk6Bjm4Xz0tVp DxiXI1q90TjDBCEDamBGf3Um1PBFZDIWtxJ947gesaf7u8y1YpTWa5F4QXdVaOcV1LFQ aWNQ== X-Gm-Message-State: AOAM5324geIr7W5KXS183MdYzMWn6Yrq4/GDWwZHCyPH5owwvzKLQaKJ 6FAwfRi6uwemzAuQ050/TPA= X-Google-Smtp-Source: ABdhPJyEAGXc53tWtwzjvRMpUKdIkNcVVRhtV1iI9clNxea1rhdeEQ09BgMlQgzbOvT87bj9SQxytQ== X-Received: by 2002:a63:3d8c:: with SMTP id k134mr592201pga.22.1601919466093; Mon, 05 Oct 2020 10:37:46 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id g9sm225231pgm.79.2020.10.05.10.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 10:37:45 -0700 (PDT) From: Moritz Fischer To: linux-fpga@vger.kernel.org Subject: [PATCH v2 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration Date: Mon, 5 Oct 2020 10:37:27 -0700 Message-Id: <20201005173735.162408-3-mdf@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005173735.162408-1-mdf@kernel.org> References: <20201005173735.162408-1-mdf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_133747_502432_5686C06F X-CRM114-Status: GOOD ( 14.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: russell.h.weight@intel.com, trix@redhat.com, michal.simek@xilinx.com, matthew.gerlach@intel.com, linux-kernel@vger.kernel.org, Moritz Fischer , linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Simplify registration by using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/altera-ps-spi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c index 0221dee8dd4c..23bfd4d1ad0f 100644 --- a/drivers/fpga/altera-ps-spi.c +++ b/drivers/fpga/altera-ps-spi.c @@ -307,18 +307,7 @@ static int altera_ps_probe(struct spi_device *spi) if (!mgr) return -ENOMEM; - spi_set_drvdata(spi, mgr); - - return fpga_mgr_register(mgr); -} - -static int altera_ps_remove(struct spi_device *spi) -{ - struct fpga_manager *mgr = spi_get_drvdata(spi); - - fpga_mgr_unregister(mgr); - - return 0; + return devm_fpga_mgr_register(&spi->dev, mgr); } static const struct spi_device_id altera_ps_spi_ids[] = { @@ -337,7 +326,6 @@ static struct spi_driver altera_ps_driver = { }, .id_table = altera_ps_spi_ids, .probe = altera_ps_probe, - .remove = altera_ps_remove, }; module_spi_driver(altera_ps_driver) -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel