From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D37C4363A for ; Mon, 5 Oct 2020 17:39:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A679207BC for ; Mon, 5 Oct 2020 17:39:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bFR6X3nx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A679207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gcCaRsmkpAffqs704P5bqpRtcYolAQlmG1IVIjkwP2A=; b=bFR6X3nxzPFJVbePuKAafdzdt tdJ/suBa58Eny/l+K9d1DaYot3kt+EIO3HzuJTUax9kI1nlu+V+xFvKz1uydF+5N3tXm+QUHaevEH qunPh2Ktpx8DlxuMmyu+hRoaURDz6oGkyUNA3i1HYaDQKChdnbVD5ic8vY41/E71rcAEdJf5mSBty ASoYPnd7xcel6wMbd0uFxvOLfWEm1hHOIrnQoozfl1Z+sJgtnXffUThXPAq4IvOpIJ8j0ZdXOymU6 OqG2fe3nLNGC+EU/tnhZ/WMuXPAE35nD0bT5G5h1859SmMGjUkZ/wleyXa1LC6ZQ35QR2nfLskNoH F478ETwRw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPURC-0007rM-E2; Mon, 05 Oct 2020 17:38:14 +0000 Received: from mail-pj1-f47.google.com ([209.85.216.47]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPUQp-0007iD-4z for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 17:37:52 +0000 Received: by mail-pj1-f47.google.com with SMTP id x2so219044pjk.0 for ; Mon, 05 Oct 2020 10:37:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PJinqLCKTDe+aRSItigFp/wrvpdMWTGVdNBIcRnfBzA=; b=qW32BqVjAGG/MgWgCXmemNyH9ZAcfpJ8FStv4/hOfJaKCcduCfEp4M9+zNi56nyaRf yRuN/Okrq3dRhaKF9MalfJm0RP6Nsd737sK69RvMHJZiqh3qTqGYLmGNzKbuzpl2Z3g0 Th4C4lbCaK9bhv245rNSxwXXnbCsx0Jo8q6tB4t84Cy0ulWxAC8gRoG2VW6QlSGrLJRO TAUnQXdzf9l+q5QYiqZRxKwL36VIulhU6qsrv2bSaRzrM0IOBkLqtZ2ohCm65LBo1PSh CSJzvYtNMIEYfhnnaiwwCJOKKKvkajEkEG2SVwMyayvgb1VfwNiPDppcR2lzXYmAZ7eE njJA== X-Gm-Message-State: AOAM5310x/pR99XFIwzj370UmxrJkckoAyvE6An2zVpBd+RvJO1+3Adg DsxeISK04/sbuytC5HkF4rI= X-Google-Smtp-Source: ABdhPJwdvnEtZIDBh4qK3r1xDzccd0E4i+usLvtnb/8vdfe8iRjZfHrJt9UaCm9t4fceQLtH0RmFZA== X-Received: by 2002:a17:90b:f8b:: with SMTP id ft11mr544364pjb.8.1601919469830; Mon, 05 Oct 2020 10:37:49 -0700 (PDT) Received: from localhost ([2601:647:5b00:1161:a4cc:eef9:fbc0:2781]) by smtp.gmail.com with ESMTPSA id az18sm181250pjb.35.2020.10.05.10.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 10:37:49 -0700 (PDT) From: Moritz Fischer To: linux-fpga@vger.kernel.org Subject: [PATCH v2 05/10] fpga: fpga-mgr: machxo2-spi: Simplify registration Date: Mon, 5 Oct 2020 10:37:30 -0700 Message-Id: <20201005173735.162408-6-mdf@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201005173735.162408-1-mdf@kernel.org> References: <20201005173735.162408-1-mdf@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_133751_250760_58D0FE17 X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: russell.h.weight@intel.com, trix@redhat.com, michal.simek@xilinx.com, matthew.gerlach@intel.com, linux-kernel@vger.kernel.org, Moritz Fischer , linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/machxo2-spi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index b316369156fe..114a64d2b7a4 100644 --- a/drivers/fpga/machxo2-spi.c +++ b/drivers/fpga/machxo2-spi.c @@ -371,18 +371,7 @@ static int machxo2_spi_probe(struct spi_device *spi) if (!mgr) return -ENOMEM; - spi_set_drvdata(spi, mgr); - - return fpga_mgr_register(mgr); -} - -static int machxo2_spi_remove(struct spi_device *spi) -{ - struct fpga_manager *mgr = spi_get_drvdata(spi); - - fpga_mgr_unregister(mgr); - - return 0; + return devm_fpga_mgr_register(dev, mgr); } static const struct of_device_id of_match[] = { @@ -403,7 +392,6 @@ static struct spi_driver machxo2_spi_driver = { .of_match_table = of_match_ptr(of_match), }, .probe = machxo2_spi_probe, - .remove = machxo2_spi_remove, .id_table = lattice_ids, }; -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel