From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AE5EC4363A for ; Mon, 5 Oct 2020 20:09:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FC1A21481 for ; Mon, 5 Oct 2020 20:09:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qAR9WuLN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FC1A21481 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WTGDX6ZYbc3mol9XHT6VDB/txkF2kCmhAPZxKTFtK1Y=; b=qAR9WuLN/FF2BCTwy+LDSfFAd 4SAQQ0wm4qB012tTRxWnAyp3HmExm3HbUJHXgbRxcuJttQklHdISkJ/tWf6dRrhPjR8Pc9vTya8zF ExGPnDcaHNYzdaHmIQcBhBmhUpEDcKc0Rzky0KrBUc+kK/Zzeo7vKhIq+yiAhjEQ+xI7Z2zvNHPCi KdMLyEr5kiz/3YUSH5aa9jjRJNDYr5cfdrSiMUoAEWvKMnRBvxXnmsgTiF2Xsof6WzoUOTYP1J0ub w2RfxKlKlT77wgJB1Mp+PCDVHYaPr13AvcMjf4QTPB91Xct9VPuBwH3K2UPWbzSSeKpILR+6i2DFi UFYQmaMJw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPWm8-0002zM-7N; Mon, 05 Oct 2020 20:08:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kPWm5-0002yR-RZ for linux-arm-kernel@lists.infradead.org; Mon, 05 Oct 2020 20:07:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 888B211D4; Mon, 5 Oct 2020 13:07:55 -0700 (PDT) Received: from bogus (unknown [10.57.48.110]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7923E3F70D; Mon, 5 Oct 2020 13:07:53 -0700 (PDT) Date: Mon, 5 Oct 2020 21:07:44 +0100 From: Sudeep Holla To: "Zulkifli, Muhammad Husaini" Subject: Re: [PATCH v2 2/3] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call Message-ID: <20201005200744.robd42nkt6ahg52x@bogus> References: <20201001142149.23445-1-muhammad.husaini.zulkifli@intel.com> <20201001142149.23445-3-muhammad.husaini.zulkifli@intel.com> <20201001153526.GD906@bogus> <20201002105840.GE906@bogus> <1b714566-d6dd-ead1-322e-f92847b923f3@xilinx.com> <20201002145115.GA6520@bogus> <20201005084441.znou7licvvtomva4@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201005_160757_966444_568C73A8 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ulf.hansson@linaro.org" , "arnd@arndb.de" , "Raja Subramanian, Lakshmi Bai" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michal Simek , "Wan Mohamad, Wan Ahmad Zainie" , "Hunter, Adrian" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 05, 2020 at 05:04:10PM +0000, Zulkifli, Muhammad Husaini wrote: > To be clarify keembay_sd_voltage_selection function as Michal's prefers is > actually using the firmware driver. This function located in firmware > driver. OK, it can be just one function place it in any file you think is more appropriate need not be arasan controller driver. Any reasons why this can't work ? Can even be in some header. int keembay_sd_voltage_selection(int volt) { int res; arm_smccc_1_1_invoke(KEEMBAY_SET_SD_VOLTAGE_FUNC_ID, volt, &res) /* appropriate error check if needed here */ return res; } > I will call this func during voltage switching from arasan controller. I > believe this implementation require DT to specify the compatible name and > method use either smc/hvc. No, use the standard one as detected by arm_smccc_1_1_invoke (It calls arm_smccc_get_conduit internally and use SMC/HVC based on that) > > Are you saying that by using simple smcc based function library I should > call below func() in arasan controller. For example > 1) arm_smccc_get_version(void) > 2) arm_smccc_version_init(arm_smccc_get_version(), SMCCC_CONDUIT_SMC); Nope > 3) arm_smccc_1_1_invoke(KEEMBAY_SET_SD_VOLTAGE_FUNC_ID, voltage_value , &res); Just this. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel